feat(@angular/cli): always use new compiler with Angular 5

Author: filipesilva

packages/@angular/cli/commands/build.ts

@@ -2,7 +2,6 @@ import { CliConfig } from '../models/config';
 import { BuildOptions } from '../models/build-options';
 import { Version } from '../upgrade/version';
 import { oneLine } from 'common-tags';
-import { AngularCompilerPlugin } from '@ngtools/webpack';
 
 const Command = require('../ember-cli/lib/models/command');
 
@@ -178,13 +177,6 @@ export const baseBuildCommandOptions: any = [
     description: 'Use file name for lazy loaded chunks.',
     default: buildConfigDefaults['namedChunks']
   },
-  {
-    name: 'experimental-angular-compiler',
-    type: Boolean,
-    // aliases: ['eac'],  // We should not have shorthand aliases for experimental flags.
-    description: '(Experimental) Use new Angular Compiler (Angular version 5 and greater only).',
-    default: AngularCompilerPlugin.isSupported()
-  },
   {
     name: 'subresource-integrity',
     type: Boolean,

packages/@angular/cli/models/build-options.ts

@@ -27,6 +27,5 @@ export interface BuildOptions {
   showCircularDependencies?: boolean;
   buildOptimizer?: boolean;
   namedChunks?: boolean;
-  experimentalAngularCompiler?: boolean;
   subresourceIntegrity?: boolean;
 }

packages/@angular/cli/models/webpack-config.ts

@@ -12,7 +12,6 @@ import {
   getAotConfig
 } from './webpack-configs';
 import * as path from 'path';
-import { AngularCompilerPlugin } from '@ngtools/webpack';
 
 export interface WebpackConfigOptions<T extends BuildOptions = BuildOptions> {
   projectRoot: string;
@@ -79,10 +78,6 @@ export class NgCliWebpackConfig<T extends BuildOptions = BuildOptions> {
       && !(buildOptions.aot || buildOptions.target === 'production')) {
       throw new Error('The `--build-optimizer` option cannot be used without `--aot`.');
     }
-
-    if (buildOptions.experimentalAngularCompiler && !AngularCompilerPlugin.isSupported()) {
-      throw new Error('You need Angular 5 and up to use --experimental-angular-compiler.');
-    }
   }
 
   // Fill in defaults for build targets

packages/@angular/cli/models/webpack-configs/typescript.ts

@@ -73,7 +73,7 @@ function _createAotPlugin(wco: WebpackConfigOptions, options: any) {
     };
   }
 
-if (wco.buildOptions.experimentalAngularCompiler) {
+  if (AngularCompilerPlugin.isSupported()) {
     const pluginOptions: AngularCompilerPluginOptions = Object.assign({}, {
       mainPath: path.join(projectRoot, appConfig.root, appConfig.main),
       i18nInFile: buildOptions.i18nFile,

packages/@angular/cli/models/webpack-xi18n-config.ts

@@ -14,7 +14,7 @@ export interface XI18WebpackOptions {
   verbose?: boolean;
   progress?: boolean;
   app?: string;
-  experimentalAngularCompiler?: boolean;
+  aot?: boolean;
 }
 export class XI18nWebpackConfig extends NgCliWebpackConfig {
 
@@ -26,18 +26,17 @@ export class XI18nWebpackConfig extends NgCliWebpackConfig {
       target: 'development',
       verbose: extractOptions.verbose,
       progress: extractOptions.progress,
-      experimentalAngularCompiler: extractOptions.experimentalAngularCompiler,
       locale: extractOptions.locale,
       i18nOutFormat: extractOptions.i18nFormat,
       i18nOutFile: extractOptions.outFile,
-      aot: extractOptions.experimentalAngularCompiler
+      aot: extractOptions.aot
     }, appConfig);
     super.buildConfig();
   }
 
   public buildConfig() {
     // The extra extraction config is only needed in Angular 2/4.
-    if (!this.extractOptions.experimentalAngularCompiler) {
+    if (!this.extractOptions.aot) {
       const configPath = CliConfig.configFilePath();
       const projectRoot = path.dirname(configPath);
 

packages/@angular/cli/tasks/extract-i18n.ts

@@ -11,11 +11,11 @@ const MemoryFS = require('memory-fs');
 export const Extracti18nTask = Task.extend({
   run: function (runTaskOptions: any) {
     const appConfig = getAppFromConfig(runTaskOptions.app);
-    const experimentalAngularCompiler = AngularCompilerPlugin.isSupported();
+    const useExperimentalAngularCompiler = AngularCompilerPlugin.isSupported();
 
     // We need to determine the outFile name so that AngularCompiler can retrieve it.
     let outFile = runTaskOptions.outFile || getI18nOutfile(runTaskOptions.i18nFormat);
-    if (experimentalAngularCompiler && runTaskOptions.outputPath) {
+    if (useExperimentalAngularCompiler && runTaskOptions.outputPath) {
       // AngularCompilerPlugin doesn't support genDir so we have to adjust outFile instead.
       outFile = join(runTaskOptions.outputPath, outFile);
     }
@@ -29,7 +29,7 @@ export const Extracti18nTask = Task.extend({
       verbose: runTaskOptions.verbose,
       progress: runTaskOptions.progress,
       app: runTaskOptions.app,
-      experimentalAngularCompiler,
+      aot: useExperimentalAngularCompiler,
     }, appConfig).buildConfig();
 
     const webpackCompiler = webpack(config);