fix(@angular/cli): favor non deprecated packages during update

Prior to this change during update deprecated packages that satisfied the version range constrain where being favored over the non-deprecated versions if the version of the deprecated version is greater. Ex: if `14.3.1` is deprecated and `14.3.0` is not the former was being installed.

With this change we now change the logic to favor non deprecated version of the package and only use the deprecated package when no satisfying version is found.

This fix is needed as in some cases a package which cannot be unpublished from NPM will gave to be to be deprecated, if the version is for a reason or another broken.

(cherry picked from commit 7e64b15)

Author: alan-agius4

packages/angular/cli/src/commands/update/schematic/index.ts

@@ -561,9 +561,26 @@ function _buildPackageInfo(
     const content = JSON.parse(packageContent.toString()) as JsonSchemaForNpmPackageJsonFiles;
     installedVersion = content.version;
   }
+
+  const packageVersionsNonDeprecated: string[] = [];
+  const packageVersionsDeprecated: string[] = [];
+
+  for (const [version, { deprecated }] of Object.entries(npmPackageJson.versions)) {
+    if (deprecated) {
+      packageVersionsDeprecated.push(version);
+    } else {
+      packageVersionsNonDeprecated.push(version);
+    }
+  }
+
+  const findSatisfyingVersion = (targetVersion: VersionRange): VersionRange | undefined =>
+    ((semver.maxSatisfying(packageVersionsNonDeprecated, targetVersion) ??
+      semver.maxSatisfying(packageVersionsDeprecated, targetVersion)) as VersionRange | null) ??
+    undefined;
+
   if (!installedVersion) {
     // Find the version from NPM that fits the range to max.
-    installedVersion = semver.maxSatisfying(Object.keys(npmPackageJson.versions), packageJsonRange);
+    installedVersion = findSatisfyingVersion(packageJsonRange);
   }
 
   if (!installedVersion) {
@@ -586,10 +603,7 @@ function _buildPackageInfo(
     } else if (targetVersion == 'next') {
       targetVersion = npmPackageJson['dist-tags']['latest'] as VersionRange;
     } else {
-      targetVersion = semver.maxSatisfying(
-        Object.keys(npmPackageJson.versions),
-        targetVersion,
-      ) as VersionRange;
+      targetVersion = findSatisfyingVersion(targetVersion);
     }
   }
 

packages/angular/cli/src/utilities/package-metadata.ts

@@ -47,7 +47,9 @@ export interface NgPackageManifestProperties {
   };
 }
 
-export interface PackageManifest extends Manifest, NgPackageManifestProperties {}
+export interface PackageManifest extends Manifest, NgPackageManifestProperties {
+  deprecated?: boolean;
+}
 
 interface PackageManagerOptions extends Record<string, unknown> {
   forceAuth?: Record<string, unknown>;