Skip to content

Commit 40fd214

Browse files
dgp1130clydin
dgp1130
authored and
clydin
committed
build: disable RBE
For security reasons, RBE was made more restrictive and broke the current v18 configuration.
1 parent cfb0a4f commit 40fd214

File tree

2 files changed

+33
-22
lines changed

2 files changed

+33
-22
lines changed

‎.github/workflows/ci.yml‎

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,9 @@ jobs:
4545
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
4646
- name: Setup Bazel
4747
uses: angular/dev-infra/github-actions/bazel/setup@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
48-
- name: Setup Bazel RBE
49-
uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
48+
# Disabled as RBE is broken by a recent update not ported to v18.
49+
# - name: Setup Bazel RBE
50+
# uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
5051
- name: Install node modules
5152
run: yarn install --immutable
5253
- name: Build release targets
@@ -59,8 +60,9 @@ jobs:
5960
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
6061
- name: Setup Bazel
6162
uses: angular/dev-infra/github-actions/bazel/setup@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
62-
- name: Setup Bazel RBE
63-
uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
63+
# Disabled as RBE is broken by a recent update not ported to v18.
64+
# - name: Setup Bazel RBE
65+
# uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
6466
- name: Install node modules
6567
run: yarn install --immutable
6668
- name: Run module and package tests
@@ -95,8 +97,9 @@ jobs:
9597
run: yarn install --immutable
9698
- name: Setup Bazel
9799
uses: angular/dev-infra/github-actions/bazel/setup@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
98-
- name: Setup Bazel RBE
99-
uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
100+
# Disabled as RBE is broken by a recent update not ported to v18.
101+
# - name: Setup Bazel RBE
102+
# uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
100103
- name: Run CLI E2E tests
101104
run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
102105

@@ -116,8 +119,9 @@ jobs:
116119
run: yarn install --immutable
117120
- name: Setup Bazel
118121
uses: angular/dev-infra/github-actions/bazel/setup@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
119-
- name: Setup Bazel RBE
120-
uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
122+
# Disabled as RBE is broken by a recent update not ported to v18.
123+
# - name: Setup Bazel RBE
124+
# uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
121125
- name: Run CLI E2E tests
122126
run: yarn bazel test --define=E2E_SHARD_TOTAL=3 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
123127

@@ -137,8 +141,9 @@ jobs:
137141
run: yarn install --immutable
138142
- name: Setup Bazel
139143
uses: angular/dev-infra/github-actions/bazel/setup@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
140-
- name: Setup Bazel RBE
141-
uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
144+
# Disabled as RBE is broken by a recent update not ported to v18.
145+
# - name: Setup Bazel RBE
146+
# uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
142147
- name: Run CLI E2E tests
143148
run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.snapshots.${{ matrix.subset }}_node${{ matrix.node }}
144149

@@ -154,8 +159,9 @@ jobs:
154159
run: yarn install --immutable
155160
- name: Setup Bazel
156161
uses: angular/dev-infra/github-actions/bazel/setup@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
157-
- name: Setup Bazel RBE
158-
uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
162+
# Disabled as RBE is broken by a recent update not ported to v18.
163+
# - name: Setup Bazel RBE
164+
# uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
159165
- name: Run E2E Browser tests
160166
env:
161167
SAUCE_USERNAME: ${{ vars.SAUCE_USERNAME }}

‎.github/workflows/pr.yml‎

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,9 @@ jobs:
7373
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
7474
- name: Setup Bazel
7575
uses: angular/dev-infra/github-actions/bazel/setup@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
76-
- name: Setup Bazel RBE
77-
uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
76+
# Disabled as RBE is broken by a recent update not ported to v18.
77+
# - name: Setup Bazel RBE
78+
# uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
7879
- name: Install node modules
7980
run: yarn install --immutable
8081
- name: Build release targets
@@ -93,8 +94,9 @@ jobs:
9394
uses: angular/dev-infra/github-actions/npm/checkout-and-setup-node@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
9495
- name: Setup Bazel
9596
uses: angular/dev-infra/github-actions/bazel/setup@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
96-
- name: Setup Bazel RBE
97-
uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
97+
# Disabled as RBE is broken by a recent update not ported to v18.
98+
# - name: Setup Bazel RBE
99+
# uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
98100
- name: Install node modules
99101
run: yarn install --immutable
100102
- name: Run module and package tests
@@ -116,8 +118,9 @@ jobs:
116118
run: yarn install --immutable
117119
- name: Setup Bazel
118120
uses: angular/dev-infra/github-actions/bazel/setup@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
119-
- name: Setup Bazel RBE
120-
uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
121+
# Disabled as RBE is broken by a recent update not ported to v18.
122+
# - name: Setup Bazel RBE
123+
# uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
121124
- name: Run CLI E2E tests
122125
run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
123126

@@ -137,8 +140,9 @@ jobs:
137140
run: yarn install --immutable
138141
- name: Setup Bazel
139142
uses: angular/dev-infra/github-actions/bazel/setup@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
140-
- name: Setup Bazel RBE
141-
uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
143+
# Disabled as RBE is broken by a recent update not ported to v18.
144+
# - name: Setup Bazel RBE
145+
# uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
142146
- name: Run CLI E2E tests
143147
run: yarn bazel test --define=E2E_SHARD_TOTAL=3 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.${{ matrix.subset }}_node${{ matrix.node }}
144148

@@ -160,7 +164,8 @@ jobs:
160164
run: yarn install --immutable
161165
- name: Setup Bazel
162166
uses: angular/dev-infra/github-actions/bazel/setup@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
163-
- name: Setup Bazel RBE
164-
uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
167+
# Disabled as RBE is broken by a recent update not ported to v18.
168+
# - name: Setup Bazel RBE
169+
# uses: angular/dev-infra/github-actions/bazel/configure-remote@b45dfa77df2021b23eeda5928ca6cd8bb89b21e7
165170
- name: Run CLI E2E tests
166171
run: yarn bazel test --define=E2E_SHARD_TOTAL=6 --define=E2E_SHARD_INDEX=${{ matrix.shard }} --config=e2e //tests/legacy-cli:e2e.snapshots.${{ matrix.subset }}_node${{ matrix.node }}

0 commit comments

Comments
 (0)