fix(@angular-devkit/build-angular): only show cannot restore inputs/options when old length is > 0

alan-agius4 · mgechev · commit 3c2da34972f5 · 2020-10-14T21:57:47.000+03:00
diff --git a/packages/angular_devkit/build_angular/src/webpack/plugins/hmr/hmr-accept.js b/packages/angular_devkit/build_angular/src/webpack/plugins/hmr/hmr-accept.js
@@ -193,7 +193,7 @@ export default function (mod) {
 
         dispatchEvents(newElement);
       }
-    } else {
+    } else if (oldInputs.length) {
       console.warn('[NG HMR] Cannot restore input/textarea values.');
     }
 
@@ -207,8 +207,8 @@ export default function (mod) {
 
         dispatchEvents(newElement);
       }
-    } else {
+    } else if (oldOptions.length) {
       console.warn('[NG HMR] Cannot restore selected options.');
     }
   }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ export default function (mod) {`
`193`	`193`
`194`	`194`	`dispatchEvents(newElement);`
`195`	`195`	`}`
`196`		`- } else {`
	`196`	`+ } else if (oldInputs.length) {`
`197`	`197`	`console.warn('[NG HMR] Cannot restore input/textarea values.');`
`198`	`198`	`}`
`199`	`199`
`@@ -207,8 +207,8 @@ export default function (mod) {`
`207`	`207`
`208`	`208`	`dispatchEvents(newElement);`
`209`	`209`	`}`
`210`		`- } else {`
	`210`	`+ } else if (oldOptions.length) {`
`211`	`211`	`console.warn('[NG HMR] Cannot restore selected options.');`
`212`	`212`	`}`
`213`	`213`	`}`
`214`		`-}`
	`214`	`+}`