fix(@angular/ssr): correct route extraction and error handling

This commit introduces the following changes:
- Disallows paths starting with a slash to match Angular router behavior.
- Errors are now stored and displayed at a later stage, improving UX by avoiding unnecessary stack traces that are not useful in this context.

Author: alan-agius4

packages/angular/build/src/utils/server-rendering/prerender.ts

@@ -15,8 +15,9 @@ import { BuildOutputAsset } from '../../tools/esbuild/bundler-execution-result';
 import { urlJoin } from '../url';
 import type { RenderWorkerData } from './render-worker';
 import type {
+  RoutersExtractorWorkerResult,
   RoutesExtractorWorkerData,
-  RoutersExtractorWorkerResult as SerializableRouteTreeNode,
+  SerializableRouteTreeNode,
 } from './routes-extractor-worker';
 
 interface PrerenderOptions {
@@ -298,14 +299,15 @@ async function getAllRoutes(
   });
 
   const errors: string[] = [];
-  const serializableRouteTreeNode: SerializableRouteTreeNode = await renderWorker
-    .run({})
-    .catch((err) => {
-      errors.push(`An error occurred while extracting routes.\n\n${err.stack}`);
-    })
-    .finally(() => {
-      void renderWorker.destroy();
-    });
+  const { serializedRouteTree: serializableRouteTreeNode }: RoutersExtractorWorkerResult =
+    await renderWorker
+      .run({})
+      .catch((err) => {
+        errors.push(`An error occurred while extracting routes.\n\n${err.stack}`);
+      })
+      .finally(() => {
+        void renderWorker.destroy();
+      });
 
   const skippedRedirects: string[] = [];
   const skippedOthers: string[] = [];

packages/angular/build/src/utils/server-rendering/routes-extractor-worker.ts

@@ -15,22 +15,30 @@ export interface RoutesExtractorWorkerData extends ESMInMemoryFileLoaderWorkerDa
   assetFiles: Record</** Destination */ string, /** Source */ string>;
 }
 
-export type RoutersExtractorWorkerResult = ReturnType<
-  Awaited<ReturnType<typeof ɵextractRoutesAndCreateRouteTree>>['toObject']
+export type SerializableRouteTreeNode = ReturnType<
+  Awaited<ReturnType<typeof ɵextractRoutesAndCreateRouteTree>>['routeTree']['toObject']
 >;
 
+export interface RoutersExtractorWorkerResult {
+  serializedRouteTree: SerializableRouteTreeNode;
+  errors: string[];
+}
+
 /** Renders an application based on a provided options. */
 async function extractRoutes(): Promise<RoutersExtractorWorkerResult> {
   const { ɵextractRoutesAndCreateRouteTree: extractRoutesAndCreateRouteTree } =
     await loadEsmModuleFromMemory('./main.server.mjs');
 
-  const routeTree = await extractRoutesAndCreateRouteTree(
+  const { routeTree, errors } = await extractRoutesAndCreateRouteTree(
     new URL('http://local-angular-prerender/'),
     /** manifest */ undefined,
     /** invokeGetPrerenderParams */ true,
   );
 
-  return routeTree.toObject();
+  return {
+    errors,
+    serializedRouteTree: routeTree.toObject(),
+  };
 }
 
 function initialize() {

packages/angular/ssr/node/src/app-engine.ts

@@ -59,7 +59,7 @@ export class AngularNodeAppEngine {
    *     const headers = angularAppEngine.getPrerenderHeaders(res.req);
    *
    *     // Apply the retrieved headers to the response
-   *     for (const { key, value } of headers) {
+   *     for (const [key, value] of headers) {
    *       res.setHeader(key, value);
    *     }
    *   }