ci: update CI to node 10

Author: filipesilva

.appveyor.yml

@@ -1,15 +1,14 @@
 environment:
-  # Note: if updating to Node 10, use at least 10.5.0 to include a fix for
-  # https://github.com/nodejs/node/issues/20297
-  nodejs_version: "8.9.2" # Same version as used in CircleCI.
+  nodejs_version: "10.9.0" # Same version as used in CircleCI.
 
 matrix:
   fast_finish: true
 
 install:
   - ps: Install-Product node $env:nodejs_version
-  - yarn install --frozen-lockfile
-  - npm run webdriver-update-appveyor
+  # --network-timeout is a workaround for https://github.com/yarnpkg/yarn/issues/6221
+  - yarn --frozen-lockfile --network-timeout=500000
+  - yarn webdriver-update-appveyor
 
 test_script:
   - node --version

.circleci/config.yml

@@ -12,8 +12,9 @@
 ## IMPORTANT
 # If you change the `docker_image` version, also change the `cache_key` suffix and the version of
 # `com_github_bazelbuild_buildtools` in the `/WORKSPACE` file.
-var_1: &docker_image angular/ngcontainer:0.3.3
-var_2: &cache_key angular_devkit-{{ checksum "yarn.lock" }}-0.3.3-2
+var_1: &docker_image angular/ngcontainer:0.5.0
+var_2: &cache_key angular_devkit-{{ checksum "yarn.lock" }}-0.5.0
+var_3: &node_8_docker_image angular/ngcontainer:0.3.3
 
 # Settings common to each job
 anchor_1: &defaults
@@ -84,8 +85,21 @@ jobs:
     parallelism: 4
     steps:
       - attach_workspace: *attach_options
-      - run: npm install --global npm@6
       - run: xvfb-run -a node ./tests/legacy-cli/run_e2e --nb-shards=${CIRCLE_NODE_TOTAL} --shard=${CIRCLE_NODE_INDEX}
+  
+  e2e-node-8:
+    <<: *defaults
+    # Overwrite docker image to node 8.
+    docker:
+      - image: *node_8_docker_image    
+    environment:
+      BASH_ENV: ~/.profile
+    resource_class: xlarge
+    parallelism: 4
+    steps:
+      - attach_workspace: *attach_options
+      - run: npm install --global npm@6
+      - run: xvfb-run -a node ./tests/legacy-cli/run_e2e --glob=tests/basic/*
 
   build:
     <<: *defaults
@@ -153,6 +167,9 @@ workflows:
       - e2e-cli:
           requires:
             - build
+      - e2e-node-8:
+          requires:
+            - build
       - snapshot_publish:
           requires:
             - test

WORKSPACE

@@ -29,9 +29,9 @@ go_register_toolchains()
 # We need a minimum of this version to include https://github.com/bazelbuild/rules_nodejs/pull/281.
 http_archive(
     name = "build_bazel_rules_nodejs",
-    url = "https://github.com/bazelbuild/rules_nodejs/archive/c75e3dd0571b0937e3ce0c4f0e6b6b50d90468f0.zip",
-    strip_prefix = "rules_nodejs-c75e3dd0571b0937e3ce0c4f0e6b6b50d90468f0",
-    sha256 = "b78506ddaed7c682027f873d2bd50086a28570b3187da9fa16fe1672eed3015e",
+    url = "https://github.com/bazelbuild/rules_nodejs/archive/0.12.4.zip",
+    strip_prefix = "rules_nodejs-0.12.4",
+    sha256 = "c482700e032b4df60425cb9a6f8f28152fb1c4c947a9d61e6132fc59ce332b16",
 )
 
 # Load the TypeScript rules, its dependencies, and setup the workspace.
@@ -58,6 +58,8 @@ check_bazel_version("0.15.0")
 node_repositories(
     package_json = ["//:package.json"], 
     preserve_symlinks = True,
+    node_version = "10.3.0",
+    yarn_version = "1.6.0",
 )
 
 local_repository(

package.json

@@ -35,15 +35,15 @@
     "validate-commits": "./bin/devkit-admin validate-commits",
     "prepush": "node ./bin/devkit-admin hooks/pre-push",
     "webdriver-update-appveyor": "webdriver-manager update --standalone false --gecko false --versions.chrome 2.37",
-    "webdriver-update-circleci": "webdriver-manager update --standalone false --gecko false --versions.chrome 2.33"
+    "webdriver-update-circleci": "webdriver-manager update --standalone false --gecko false --versions.chrome $CHROMEDRIVER_VERSION_ARG "
   },
   "repository": {
     "type": "git",
     "url": "https://github.com/angular/angular-cli.git"
   },
   "engines": {
-    "node": ">= 8.9.0",
-    "npm": ">= 5.5.1"
+    "node": ">=10.3.0 <11.0.0",
+    "yarn": ">=1.6.0 <2.0.0"
   },
   "author": "Angular Authors",
   "license": "MIT",