ci: exit with 0 error code when running templates (#12473)

alan-agius4 · Keen Yee Liau · commit 0b884c5d88f8 · 2018-10-04T13:35:14.000-07:00
* docs: fix url typo

* ci: exit with `0` error code when running templates
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -268,7 +268,7 @@ changes to be accepted, the CLA must be signed. It's a quick process, we promise
 [coc]: https://github.com/angular/code-of-conduct/blob/master/CODE_OF_CONDUCT.md
 [commit-message-format]: https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#
 [corporate-cla]: http://code.google.com/legal/corporate-cla-v1.0.html
-[dev-doc]: ttps://github.com/angular/angular-cli/blob/master/packages/angular/cli/README.md#development-hints-for-working-on-angular-cli
+[dev-doc]: https://github.com/angular/angular-cli/blob/master/packages/angular/cli/README.md#development-hints-for-working-on-angular-cli
 [GitHub]: https://github.com/angular/angular-cli
 [gitter]: https://gitter.im/angular/angular-cli
 [individual-cla]: http://code.google.com/legal/individual-cla-v1.0.html
diff --git a/scripts/templates.ts b/scripts/templates.ts
@@ -31,5 +31,5 @@ export default async function(_options: {}, logger: logging.Logger): Promise<num
   _runTemplate('./templates/readme', '../README.md', logger);
   _runTemplate('./templates/contributing', '../CONTRIBUTING.md', logger);
 
-  return 1;
+  return 0;
 }
diff --git a/scripts/templates/contributing.ejs b/scripts/templates/contributing.ejs
@@ -257,7 +257,7 @@ changes to be accepted, the CLA must be signed. It's a quick process, we promise
 [coc]: https://github.com/angular/code-of-conduct/blob/master/CODE_OF_CONDUCT.md
 [commit-message-format]: https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#
 [corporate-cla]: http://code.google.com/legal/corporate-cla-v1.0.html
-[dev-doc]: ttps://github.com/angular/angular-cli/blob/master/packages/angular/cli/README.md#development-hints-for-working-on-angular-cli
+[dev-doc]: https://github.com/angular/angular-cli/blob/master/packages/angular/cli/README.md#development-hints-for-working-on-angular-cli
 [GitHub]: https://github.com/angular/angular-cli
 [gitter]: https://gitter.im/angular/angular-cli
 [individual-cla]: http://code.google.com/legal/individual-cla-v1.0.html

Original file line number	Diff line number	Diff line change
`@@ -31,5 +31,5 @@ export default async function(_options: {}, logger: logging.Logger): Promise<num`
`31`	`31`	`_runTemplate('./templates/readme', '../README.md', logger);`
`32`	`32`	`_runTemplate('./templates/contributing', '../CONTRIBUTING.md', logger);`
`33`	`33`
`34`		`- return 1;`
	`34`	`+ return 0;`
`35`	`35`	`}`