Instead of new var used the open variable as it is set on activate.

Author: Jefiozie

src/uiSelectChoicesDirective.js

@@ -67,7 +67,7 @@ uis.directive('uiSelectChoices',
         scope.$watch('$select.search', function(newValue) {
           if(newValue && !$select.open && $select.multiple) $select.activate(false, true);
           $select.activeIndex = $select.tagging.isActivated ? -1 : 0;
-          if ((!attrs.minimumInputLength || $select.search.length >= attrs.minimumInputLength) && (!$select.refreshOnActive || ($select.refreshOnActive && $select.refreshIsActive))) {
+          if ((!attrs.minimumInputLength || $select.search.length >= attrs.minimumInputLength) && (!$select.refreshOnActive || ($select.refreshOnActive && $select.open))) {
             $select.refresh(attrs.refresh);
           } else {
             $select.items = [];
@@ -79,19 +79,14 @@ uis.directive('uiSelectChoices',
           var refreshDelay = scope.$eval(attrs.refreshDelay);
           $select.refreshDelay = refreshDelay !== undefined ? refreshDelay : uiSelectConfig.refreshDelay;
         });
-
-        if(!angular.isUndefined($select.refreshOnActive)){
-          //only add a watch when refreshonactive is set.
-          scope.$watch('$select.refreshIsActive', function(newValue, oldValue){
-            if(angular.isUndefined(oldValue) && newValue){
-              $select.refresh(attrs.refresh);
-            }
-          });
-        }
 
         scope.$watch('$select.open', function(open) {
           if (open) {
             tElement.attr('role', 'listbox');
+            if(!angular.isUndefined($select.refreshOnActive)){
+              //only add a watch when refreshonactive is set.
+              $select.refresh(attrs.refresh);
+            }
           } else {
             tElement.removeAttr('role');
           }

src/uiSelectController.js

@@ -19,8 +19,6 @@ uis.controller('uiSelectCtrl',
   ctrl.paste = uiSelectConfig.paste;
   ctrl.resetSearchInput = uiSelectConfig.resetSearchInput;
   ctrl.refreshing = false;
-  ctrl.refreshOnActive = undefined;
-  ctrl.refreshIsActive = undefined;
   ctrl.spinnerEnabled = uiSelectConfig.spinnerEnabled;
   ctrl.spinnerClass = uiSelectConfig.spinnerClass;
 
@@ -111,14 +109,6 @@ uis.controller('uiSelectCtrl',
       return result;
     }
 
-    function _setrefreshIsActive(){
-      //only set a value if the refreshOnActive attr is set.
-      if(!angular.isUndefined(ctrl.refreshOnActive))
-      {
-        ctrl.refreshIsActive =  true;
-      }
-    }
-
   // When the user clicks on ui-select, displays the dropdown list
   ctrl.activate = function(initSearchValue, avoidReset) {
     if (!ctrl.disabled  && !ctrl.open) {
@@ -129,8 +119,6 @@ uis.controller('uiSelectCtrl',
       ctrl.open = true;
 
       ctrl.activeIndex = ctrl.activeIndex >= ctrl.items.length ? 0 : ctrl.activeIndex;
-      
-      _setrefreshIsActive();
       // ensure that the index is set to zero for tagging variants
       // that where first option is auto-selected
       if ( ctrl.activeIndex === -1 && ctrl.taggingLabel !== false ) {