Select first option no mater if it creates new tag or offer existing one. Addresses issue #1911

Author: ilinsky

src/uiSelectController.js

@@ -569,11 +569,10 @@ uis.controller('uiSelectCtrl',
         }
         break;
       case KEY.UP:
-        var minActiveIndex = (ctrl.search.length === 0 && ctrl.tagging.isActivated) ? -1 : 0;
         if (!ctrl.open && ctrl.multiple) ctrl.activate(false, true); //In case its the search input in 'multiple' mode
-        else if (ctrl.activeIndex > minActiveIndex) {
+        else if (ctrl.activeIndex > 0) {
           var idxmin = --ctrl.activeIndex;
-          while(_isItemDisabled(ctrl.items[idxmin]) && idxmin > minActiveIndex) {
+          while(_isItemDisabled(ctrl.items[idxmin]) && idxmin > 0) {
             ctrl.activeIndex = --idxmin;
           }
         }

test/select.spec.js

@@ -2861,7 +2861,7 @@ describe('ui-select tests', function() {
         triggerKeydown(searchInput, Key.Down);
         expect(el.scope().$select.activeIndex).toBe(2);
         triggerKeydown(searchInput, Key.Up);
-        expect(el.scope().$select.activeIndex).toBe(-1);
+        expect(el.scope().$select.activeIndex).toBe(0);
       });
 
       it('should ignored disabled items going down', function() {
@@ -2882,7 +2882,7 @@ describe('ui-select tests', function() {
         triggerKeydown(searchInput, Key.Down);
         expect(el.scope().$select.activeIndex).toBe(2);
         triggerKeydown(searchInput, Key.Up);
-        expect(el.scope().$select.activeIndex).toBe(-1);
+        expect(el.scope().$select.activeIndex).toBe(0);
       });
 
       it('should ignore disabled items, going down with remove-selected on false', function() {
@@ -3231,12 +3231,12 @@ describe('ui-select tests', function() {
       expect(el.scope().$select.spinnerClass).toBe('randomclass');
     });
   });
-  
+
   describe('With refresh on active', function(){
     it('should refresh when is activated', function(){
        scope.fetchFromServer = function(){};
        var el = createUiSelect({refresh:"fetchFromServer($select.search)",refreshDelay:0});
-       spyOn(scope, 'fetchFromServer'); 
+       spyOn(scope, 'fetchFromServer');
        expect(el.scope().$select.open).toEqual(false);
        el.scope().$select.activate();
        $timeout.flush();
@@ -3248,7 +3248,7 @@ describe('ui-select tests', function() {
      it('should refresh when open is set to true', function(){
        scope.fetchFromServer = function(){};
        var el = createUiSelect({refresh:"fetchFromServer($select.search)",refreshDelay:0});
-       spyOn(scope, 'fetchFromServer'); 
+       spyOn(scope, 'fetchFromServer');
        expect(el.scope().$select.open).toEqual(false);
        openDropdown(el);
        $timeout.flush();
@@ -3286,7 +3286,7 @@ describe('ui-select tests', function() {
       triggerKeydown(searchInput, Key.Down);
       expect(el.scope().$select.activeIndex).toBe(2);
       triggerKeydown(searchInput, Key.Up);
-      expect(el.scope().$select.activeIndex).toBe(-1);
+      expect(el.scope().$select.activeIndex).toBe(0);
     });
 
     it('should ignored disabled items in the down direction with tagging on', function() {