call addCSSRules on the app start only

Author: dhilt

src/modules/elementRoutines.js

@@ -1,31 +1,29 @@
 const hideClassToken = 'ng-ui-scroll-hide';
 
-function addCSSRule(sheet, rules, _index) {
-  const selector = '.' + hideClassToken;
-  let index;
-  try {
-    index = sheet.cssRules.length;
-    index = _index < index && _index >= 0 ? _index : index;
-  } catch (err) {
-    index = 0;
-  }
-  if('insertRule' in sheet) {
-    sheet.insertRule(selector + '{' + rules + '}', index);
-  }
-  else if('addRule' in sheet) {
-    sheet.addRule(selector, rules, index);
-  }
-}
-
 export default class ElementRoutines {
 
-  constructor($injector, $q, uiScrollService) {
+  static addCSSRules() {
+    const selector = '.' + hideClassToken;
+    const rules = 'display: none';
+    const sheet = document.styleSheets[0];
+    let index;
+    try {
+      index = sheet.cssRules.length;
+    } catch (err) {
+      index = 0;
+    }
+    if('insertRule' in sheet) {
+      sheet.insertRule(selector + '{' + rules + '}', index);
+    }
+    else if('addRule' in sheet) {
+      sheet.addRule(selector, rules, index);
+    }
+  }
+
+  constructor($injector, $q) {
     this.$animate = ($injector.has && $injector.has('$animate')) ? $injector.get('$animate') : null;
     this.isAngularVersionLessThen1_3 = angular.version.major === 1 && angular.version.minor < 3;
     this.$q = $q;
-    if (uiScrollService.count() === 1) {
-      addCSSRule(document.styleSheets[0], 'display: none'); 
-    }
   }
 
   hideElement(wrapper) {

src/ui-scroll.js

@@ -6,15 +6,11 @@ import Adapter from './modules/adapter.js';
 
 angular.module('ui.scroll', [])
 
-  .service('uiScrollService', function () {
-    let instances = 0;
-    this.register = () => instances++;
-    this.count = () => instances;
-  })
   .constant('JQLiteExtras', JQLiteExtras)
-  .run(['JQLiteExtras', (JQLiteExtras) =>
-    !window.jQuery ? (new JQLiteExtras()).registerFor(angular.element) : null
-  ])
+  .run(['JQLiteExtras', (JQLiteExtras) => {
+    !window.jQuery ? (new JQLiteExtras()).registerFor(angular.element) : null;
+    ElementRoutines.addCSSRules();
+  }])
 
   .directive('uiScrollViewport', function () {
     return {
@@ -47,8 +43,7 @@ angular.module('ui.scroll', [])
     '$interval',
     '$q',
     '$parse',
-    'uiScrollService',
-    function (console, $injector, $rootScope, $timeout, $interval, $q, $parse, uiScrollService) {
+    function (console, $injector, $rootScope, $timeout, $interval, $q, $parse) {
 
       return {
         require: ['?^uiScrollViewport'],
@@ -65,8 +60,6 @@ angular.module('ui.scroll', [])
           throw new Error('Expected uiScroll in form of \'_item_ in _datasource_\' but got \'' + $attr.uiScroll + '\'');
         }
 
-        uiScrollService.register();
-
         function parseNumericAttr(value, defaultValue) {
           const result = $parse(value)($scope);
           return isNaN(result) ? defaultValue : result;
@@ -89,7 +82,7 @@ angular.module('ui.scroll', [])
         let ridActual = 0; // current data revision id
         let pending = [];
 
-        const elementRoutines = new ElementRoutines($injector, $q, uiScrollService);
+        const elementRoutines = new ElementRoutines($injector, $q);
         const buffer = new ScrollBuffer(elementRoutines, bufferSize, startIndex);
         const viewport = new Viewport(elementRoutines, buffer, element, viewportController, $rootScope, padding);
         const adapter = new Adapter($scope, $parse, $attr, viewport, buffer, doAdjust, reload);