only last user min/maxIndex set could be delayed

Author: dhilt

src/ui-scroll.js

@@ -103,7 +103,7 @@ angular.module('ui.scroll', [])
 
         let onRenderHandlers = [];
         function onRenderHandlersRunner() {
-          onRenderHandlers.forEach(handler => handler());
+          onRenderHandlers.forEach(handler => handler.run());
           onRenderHandlers = [];
         }
         function persistDatasourceIndex(datasource, propName) {
@@ -112,7 +112,11 @@ angular.module('ui.scroll', [])
           if(Number.isInteger(datasource[propName])) {
             getter = datasource[propName];
             if(Number.isInteger(getter)) {
-              onRenderHandlers.push(() => datasource[propName] = getter);
+              onRenderHandlers = onRenderHandlers.filter(handler => handler.id !== propName);
+              onRenderHandlers.push({
+                id: propName,
+                run: () => datasource[propName] = getter
+              });
             }
           }
         }

test/UserIndiciesSpec.js

@@ -85,7 +85,7 @@ describe('uiScroll user min/max indicies.', () => {
       );
     });
 
-    it('should work when the viewport is big enough to include more than 1 pack of item', () => {
+    it('should work when the viewport is big enough to include more than 1 pack of item (last)', () => {
       const viewportHeight = 450;
       const _topItemsCount = Math.round(viewportHeight * 0.5 / itemHeight);
       const _topPackCount = Math.ceil(_topItemsCount / bufferSize);
@@ -100,7 +100,7 @@ describe('uiScroll user min/max indicies.', () => {
       );
     });
 
-    it('should work when the viewport is big enough to include more than 1 pack of item', () => {
+    it('should work when the viewport is big enough to include more than 1 pack of item (first)', () => {
       const viewportHeight = 450;
       const _topItemsCount = Math.round(viewportHeight * 0.5 / itemHeight);
       const _topPackCount = Math.ceil(_topItemsCount / bufferSize);
@@ -122,6 +122,7 @@ describe('uiScroll user min/max indicies.', () => {
     beforeEach(() => {
       datasource.min = userMinIndex;
       datasource.max = userMaxIndex;
+      datasource.init();
     });
 
     it('should persist user maxIndex after reload', () => {

test/misc/datasources.js

@@ -188,14 +188,13 @@ angular.module('ui.scroll.test.datasources', [])
   ])
 
 
-  .factory('myResponsiveDatasource', [
-    '$log', '$timeout', '$rootScope',
-    function() {
+  .factory('myResponsiveDatasource', function() {
       var datasource = {
         data: [],
         min: 1,
         max: 30,
         init: function() {
+          this.data = [];
           for (var i = this.min; i <= this.max; i++) {
             this.data.push('item' + i);
           }
@@ -218,4 +217,4 @@ angular.module('ui.scroll.test.datasources', [])
       datasource.init();
       return datasource;
     }
-  ]);
+  );