chore(lint): Fix or ignore eslint recommended linter rules

Author: christopherthielen

src/directives/stateDirectives.ts

@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/no-empty-interface */
+/* eslint-disable prefer-const */
 /**
  * # Angular 1 Directives
  *
@@ -38,11 +40,10 @@ export interface ng1_directive {}
 
 /** @hidden */
 function parseStateRef(ref: string) {
-  let parsed;
   const paramsOnly = ref.match(/^\s*({[^}]*})\s*$/);
   if (paramsOnly) ref = '(' + paramsOnly[1] + ')';
 
-  parsed = ref.replace(/\n/g, ' ').match(/^\s*([^(]*?)\s*(\((.*)\))?\s*$/);
+  const parsed = ref.replace(/\n/g, ' ').match(/^\s*([^(]*?)\s*(\((.*)\))?\s*$/);
   if (!parsed || parsed.length !== 4) throw new Error("Invalid state ref '" + ref + "'");
   return { state: parsed[1] || null, paramExpr: parsed[3] || null };
 }
@@ -640,7 +641,7 @@ uiSrefActiveDirective = [
             setStatesFromDefinitionObject(uiSrefActive);
           }
 
-          function setStatesFromDefinitionObject(statesDefinition: object) {
+          function setStatesFromDefinitionObject(statesDefinition: Obj) {
             if (isObject(statesDefinition)) {
               states = [];
               forEach(statesDefinition, function (stateOrName: StateOrName | Array<StateOrName>, activeClass: string) {

src/directives/viewDirective.ts

@@ -24,7 +24,7 @@ import {
   unnestR,
   ViewService,
 } from '@uirouter/core';
-import { IAugmentedJQuery, IInterpolateService, IScope, ITimeoutService, ITranscludeFunction } from 'angular';
+import { IAugmentedJQuery, IInterpolateService, IScope, ITranscludeFunction } from 'angular';
 import { ng as angular } from '../angular';
 import { Ng1Controller, Ng1StateDeclaration } from '../interface';
 import { getLocals } from '../services';
@@ -170,6 +170,7 @@ export type UIViewAnimData = {
  * ```
  */
 export let uiView: ng1_directive;
+// eslint-disable-next-line prefer-const
 uiView = [
   '$view',
   '$animate',
@@ -183,7 +184,7 @@ uiView = [
     $interpolate: IInterpolateService,
     $q: $QLike
   ) {
-    function getRenderer(attrs: Obj, scope: IScope) {
+    function getRenderer() {
       return {
         enter: function (element: JQuery, target: any, cb: Function) {
           if (angular.version.minor > 2) {
@@ -221,15 +222,11 @@ uiView = [
         return function (scope: IScope, $element: IAugmentedJQuery, attrs: Obj) {
           const onloadExp = attrs['onload'] || '',
             autoScrollExp = attrs['autoscroll'],
-            renderer = getRenderer(attrs, scope),
+            renderer = getRenderer(),
             inherited = $element.inheritedData('$uiView') || rootData,
             name = $interpolate(attrs['uiView'] || attrs['name'] || '')(scope) || '$default';
 
-          let previousEl: JQuery,
-            currentEl: JQuery,
-            currentScope: IScope,
-            viewConfig: Ng1ViewConfig,
-            unregister: Function;
+          let previousEl: JQuery, currentEl: JQuery, currentScope: IScope, viewConfig: Ng1ViewConfig;
 
           const activeUIView: ActiveUIView = {
             $type: 'ng1',
@@ -263,7 +260,7 @@ uiView = [
 
           updateView();
 
-          unregister = $view.registerUIView(activeUIView);
+          const unregister = $view.registerUIView(activeUIView);
           scope.$on('$destroy', function () {
             trace.traceUIViewEvent('Destroying/Unregistering', activeUIView);
             unregister();
@@ -363,16 +360,15 @@ uiView = [
   },
 ];
 
-$ViewDirectiveFill.$inject = ['$compile', '$controller', '$transitions', '$view', '$q', '$timeout'];
+$ViewDirectiveFill.$inject = ['$compile', '$controller', '$transitions', '$view', '$q'];
 
 /** @hidden */
 function $ViewDirectiveFill(
   $compile: angular.ICompileService,
   $controller: angular.IControllerService,
   $transitions: TransitionService,
   $view: ViewService,
-  $q: angular.IQService,
-  $timeout: ITimeoutService
+  $q: angular.IQService
 ) {
   const getControllerAs = parse('viewDecl.controllerAs');
   const getResolveAs = parse('viewDecl.resolveAs');

src/legacy/stateEvents.ts

@@ -341,6 +341,7 @@ export let $stateNotFound: IAngularEvent;
     .provider('$stateEvents', ($StateEventsProvider as any) as IServiceProviderFactory)
     .run([
       '$stateEvents',
+      // eslint-disable-next-line @typescript-eslint/no-unused-vars
       function ($stateEvents: any) {
         /* Invokes $get() */
       },

src/locationServices.ts

@@ -49,6 +49,7 @@ export class Ng1LocationServices implements LocationConfig, LocationServices {
       x != null ? x.toString().replace(/(~~|~2F)/g, (m) => ({ '~~': '~', '~2F': '/' }[m])) : x;
   }
 
+  // eslint-disable-next-line @typescript-eslint/no-empty-function
   dispose() {}
 
   constructor($locationProvider: ILocationProvider) {

src/services.ts

@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/no-empty-function */
+/* eslint-disable @typescript-eslint/no-unused-vars */
 /**
  * # Angular 1 types
  *
@@ -119,7 +121,7 @@ function runBlock($injector: IInjectorService, $q: IQService, $uiRouter: UIRoute
   services.$q = <any>$q;
 
   // https://github.com/angular-ui/ui-router/issues/3678
-  if (!$injector.hasOwnProperty('strictDi')) {
+  if (!Object.prototype.hasOwnProperty.call($injector, 'strictDi')) {
     try {
       $injector.invoke(function (checkStrictDi) {});
     } catch (error) {

src/statebuilders/onEnterExitRetain.ts

@@ -7,7 +7,6 @@ import {
   services,
   ResolveContext,
   extend,
-  BuilderFunction,
 } from '@uirouter/core';
 import { getLocals } from '../services';
 import { Ng1StateDeclaration } from '../interface';
@@ -22,7 +21,7 @@ import { Ng1StateDeclaration } from '../interface';
  * @internalapi
  */
 export const getStateHookBuilder = (hookName: 'onEnter' | 'onExit' | 'onRetain') =>
-  function stateHookBuilder(stateObject: StateObject, parentFn: BuilderFunction): TransitionStateHookFn {
+  function stateHookBuilder(stateObject: StateObject): TransitionStateHookFn {
     const hook = stateObject[hookName];
     const pathname = hookName === 'onExit' ? 'from' : 'to';
 

src/statebuilders/views.ts

@@ -1,5 +1,4 @@
 /** @publicapi @module ng1 */ /** */
-import { ng as angular } from '../angular';
 import {
   StateObject,
   pick,
@@ -22,7 +21,6 @@ import {
 } from '@uirouter/core';
 import { Ng1ViewDeclaration } from '../interface';
 import { TemplateFactory } from '../templateFactory';
-import IInjectorService = angular.auto.IInjectorService;
 
 /** @internalapi */
 export function getNg1ViewConfigFactory(): ViewConfigFactory {