feat(server:user.model): require callback in makeSalt function

we never use the sync version

Author: Awk34

templates/app/server/api/user(auth)/user.model(mongooseModels).js

@@ -185,7 +185,7 @@ UserSchema.methods = {
   /**
    * Make salt
    *
-   * @param {Number} byteSize Optional salt byte size, default to 16
+   * @param {Number} [byteSize] - Optional salt byte size, default to 16
    * @param {Function} callback
    * @return {String}
    * @api public
@@ -198,16 +198,14 @@ UserSchema.methods = {
       byteSize = defaultByteSize;
     } else if (typeof arguments[1] === 'function') {
       callback = arguments[1];
+    } else {
+      throw new Error('Missing Callback');
     }
 
     if (!byteSize) {
       byteSize = defaultByteSize;
     }
 
-    if (!callback) {
-      return crypto.randomBytes(byteSize).toString('base64');
-    }
-
     return crypto.randomBytes(byteSize, (err, salt) => {
       if (err) {
         callback(err);

templates/app/server/api/user(auth)/user.model(sequelizeModels).js

@@ -130,7 +130,7 @@ module.exports = function(sequelize, DataTypes) {
       /**
        * Make salt
        *
-       * @param {Number} byteSize Optional salt byte size, default to 16
+       * @param {Number} [byteSize] - Optional salt byte size, default to 16
        * @param {Function} callback
        * @return {String}
        * @api public
@@ -144,16 +144,14 @@ module.exports = function(sequelize, DataTypes) {
         }
         else if (typeof arguments[1] === 'function') {
           callback = arguments[1];
+        } else {
+          throw new Error('Missing Callback');
         }
 
         if (!byteSize) {
           byteSize = defaultByteSize;
         }
 
-        if (!callback) {
-          return crypto.randomBytes(byteSize).toString('base64');
-        }
-
         return crypto.randomBytes(byteSize, function(err, salt) {
           if (err) {
             callback(err);