Merge pull request #1124 from dciccale/canary

app.coffee is missing preventDefault(); auth.service changePassword() chore

Author: kingcody

app/templates/client/app/app(coffee).coffee

@@ -36,5 +36,6 @@ angular.module '<%= scriptAppName %>', [<%= angularModules %>]
   # Redirect to login if route requires auth and you're not logged in
   $rootScope.$on <% if (filters.ngroute) { %>'$routeChangeStart'<% } %><% if (filters.uirouter) { %>'$stateChangeStart'<% } %>, (event, next) ->
     Auth.isLoggedIn (loggedIn) ->
+      event.preventDefault()
       <% if (filters.ngroute) { %>$location.path '/login'<% } %><% if (filters.uirouter) { %>$state.go 'login'<% } %> if next.authenticate and not loggedIn
 <% } %>

app/templates/client/components/auth(auth)/auth.service(coffee).coffee

@@ -76,8 +76,8 @@ angular.module '<%= scriptAppName %>'
       oldPassword: oldPassword
       newPassword: newPassword
 
-    , (user) ->
-      callback? null, user
+    , () ->
+      callback? null
 
     , (err) ->
       callback? err

app/templates/client/components/auth(auth)/auth.service(js).js

@@ -88,8 +88,8 @@ angular.module('<%= scriptAppName %>')
         return User.changePassword({ id: currentUser._id }, {
           oldPassword: oldPassword,
           newPassword: newPassword
-        }, function(user) {
-          return safeCb(callback)(null, user);
+        }, function() {
+          return safeCb(callback)(null);
         }, function(err) {
           return safeCb(callback)(err);
         }).$promise;

app/templates/server/api/user(auth)/user.controller.js

@@ -128,7 +128,7 @@ exports.changePassword = function(req, res, next) {
         <% if (filters.mongooseModels) { %>return user.saveAsync()<% }
            if (filters.sequelizeModels) { %>return user.save()<% } %>
           .then(function() {
-            res.status(200).end();
+            res.status(204).end();
           })
           .catch(validationError(res));
       } else {