Skip to content

Commit 93f534d

Browse files
committed
Merge pull request #1126 from kingcody/fix/client-auth-login
fix(app): auth.login waits for user resource to resolve
2 parents 8342a31 + e04185a commit 93f534d

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

app/templates/client/components/auth(auth)/auth.service(coffee).coffee

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ angular.module '<%= scriptAppName %>'
88
Authenticate user and save token
99
1010
@param {Object} user - login info
11-
@param {Function} callback - optional, function(error)
11+
@param {Function} callback - optional, function(error, user)
1212
@return {Promise}
1313
###
1414
login: (user, callback) ->
@@ -19,10 +19,13 @@ angular.module '<%= scriptAppName %>'
1919
.then (res) ->
2020
$cookies.put 'token', res.data.token
2121
currentUser = User.get()
22-
callback?()
23-
res.data
22+
currentUser.$promise
23+
24+
.then (user) ->
25+
callback? null, user
26+
user
2427

25-
, (err) =>
28+
.catch (err) =>
2629
@logout()
2730
callback? err.data
2831
$q.reject err.data

app/templates/client/components/auth(auth)/auth.service(js).js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ angular.module('<%= scriptAppName %>')
2424
* Authenticate user and save token
2525
*
2626
* @param {Object} user - login info
27-
* @param {Function} callback - optional, function(error)
27+
* @param {Function} callback - optional, function(error, user)
2828
* @return {Promise}
2929
*/
3030
login: function(user, callback) {
@@ -35,9 +35,13 @@ angular.module('<%= scriptAppName %>')
3535
.then(function(res) {
3636
$cookies.put('token', res.data.token);
3737
currentUser = User.get();
38-
safeCb(callback)();
39-
return res.data;
40-
}, function(err) {
38+
return currentUser.$promise;
39+
})
40+
.then(function(user) {
41+
safeCb(callback)(null, user);
42+
return user;
43+
})
44+
.catch(function(err) {
4145
this.logout();
4246
safeCb(callback)(err.data);
4347
return $q.reject(err.data);

0 commit comments

Comments
 (0)