Skip to content

Commit 49b2535

Browse files
committed
refactor(gen): switch fs-extra to node fs
1 parent 4376afe commit 49b2535

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

Gruntfile.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ var shell = require('shelljs');
66
var child_process = require('child_process');
77
var Q = require('q');
88
var helpers = require('yeoman-generator').test;
9-
var fs = require('fs-extra');
9+
var fs = require('fs');
1010
var path = require('path');
1111

1212
module.exports = function (grunt) {
@@ -218,7 +218,6 @@ module.exports = function (grunt) {
218218
});
219219

220220
grunt.registerTask('updateFixtures', 'updates package and bower fixtures', function() {
221-
var done = this.async();
222221
var packageJson = fs.readFileSync(path.resolve('app/templates/_package.json'), 'utf8');
223222
var bowerJson = fs.readFileSync(path.resolve('app/templates/_bower.json'), 'utf8');
224223

@@ -231,11 +230,8 @@ module.exports = function (grunt) {
231230
bowerJson = bowerJson.replace(/<%(.*)%>/g, '');
232231

233232
// save files
234-
fs.writeFile(path.resolve(__dirname + '/test/fixtures/package.json'), packageJson, function() {
235-
fs.writeFile(path.resolve(__dirname + '/test/fixtures/bower.json'), bowerJson, function() {
236-
done();
237-
});
238-
});
233+
fs.writeFileSync(path.resolve(__dirname + '/test/fixtures/package.json'), packageJson);
234+
fs.writeFileSync(path.resolve(__dirname + '/test/fixtures/bower.json'), bowerJson);
239235
});
240236

241237
grunt.registerTask('installFixtures', 'install package and bower fixtures', function() {

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
},
3333
"devDependencies": {
3434
"chai": "^1.9.1",
35-
"fs-extra": "^0.9.1",
3635
"grunt": "~0.4.1",
3736
"grunt-build-control": "DaftMonk/grunt-build-control",
3837
"grunt-contrib-clean": "^0.6.0",

test/test-file-creation.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/*global describe, beforeEach, it */
22
'use strict';
33
var path = require('path');
4-
var fs = require('fs-extra');
4+
var fs = require('fs');
55
var exec = require('child_process').exec;
66
var helpers = require('yeoman-generator').test;
77
var chai = require('chai');
@@ -25,6 +25,8 @@ describe('angular-fullstack generator', function () {
2525
socketio: true
2626
}, dependenciesInstalled = false;
2727

28+
function copySync(s, d) { fs.writeFileSync(d, fs.readFileSync(s)); }
29+
2830
function generatorTest(generatorType, name, mockPrompt, callback) {
2931
gen.run(function () {
3032
var afGenerator;
@@ -442,7 +444,7 @@ describe('angular-fullstack generator', function () {
442444

443445
it('should use existing config if available', function(done) {
444446
this.timeout(60000);
445-
fs.copySync(__dirname + '/fixtures/.yo-rc.json', __dirname + '/temp/.yo-rc.json');
447+
copySync(__dirname + '/fixtures/.yo-rc.json', __dirname + '/temp/.yo-rc.json');
446448
var gen = helpers.createGenerator('angular-fullstack:app', [
447449
'../../app',
448450
'../../endpoint',
@@ -467,7 +469,7 @@ describe('angular-fullstack generator', function () {
467469

468470
it('should add oauth option if existing config had oauth strategy selected', function(done) {
469471
this.timeout(60000);
470-
fs.copySync(__dirname + '/fixtures/.yo-rc.json', __dirname + '/temp/.yo-rc.json');
472+
copySync(__dirname + '/fixtures/.yo-rc.json', __dirname + '/temp/.yo-rc.json');
471473
var gen = helpers.createGenerator('angular-fullstack:app', [
472474
'../../app',
473475
'../../endpoint',

0 commit comments

Comments
 (0)