refactor(client): create constants module ourselves

remove gulp-ng-constant

Author: Awk34

templates/app/_package.json

@@ -97,7 +97,6 @@
     "gulp-clean-css": "^2.0.6",
     "gulp-mocha": "^2.1.3",
     "gulp-ng-annotate": "^2.0.0",
-    "gulp-ng-constant": "^1.1.0",
     "gulp-node-inspector": "^0.1.0",
     "gulp-plumber": "^1.0.1",
     "gulp-protractor": "^2.1.0",

templates/app/client/app/app.constants.js

@@ -0,0 +1,6 @@
+'use strict';
+import angular from 'angular';
+
+export default angular.module('<%= scriptAppName %>.constants', [])
+  .constant('appConfig', require('../../server/config/environment/shared'))
+  .name;

templates/app/client/app/app.js

@@ -26,7 +26,7 @@ import admin from './admin';<% } %>
 import navbar from '../components/navbar/navbar.component';
 import footer from '../components/footer/footer.component';
 import main from './main/main.component';
-import './app.constant';
+import constants from './app.constants';
 import util from '../components/util/util.module';
 <%_ if(filters.socketio) { _%>
 import socket from '../components/socket/socket.service';<% } %>
@@ -56,7 +56,7 @@ angular.module('<%= scriptAppName %>', [
   navbar,
   footer,
   main,
-  '<%= scriptAppName %>.constants',
+  constants,
   <%_ if(filters.socketio) { _%>
   socket,<% } %>
   util

templates/app/client/components/auth(auth)/auth.module.js

@@ -1,6 +1,6 @@
 'use strict';
 import angular from 'angular';
-// import constants from '../../app/app.constant';
+import constants from '../../app/app.constants';
 import util from '../util/util.module';
 import ngCookies from 'angular-cookies';
 import {authInterceptor} from './interceptor.service';
@@ -18,7 +18,7 @@ function addInterceptor($httpProvider) {
 }
 
 export default angular.module('<%= scriptAppName %>.auth', [
-  '<%= scriptAppName %>.constants',
+  constants,
   util,
   ngCookies<% if(filters.ngroute) { %>,
   ngRoute<% } if(filters.uirouter) { %>,

templates/app/gulpfile.babel.js

@@ -268,12 +268,7 @@ gulp.task('styles', () => {
     <%_ } _%>
         .pipe(styles())
         .pipe(gulp.dest('.tmp/app'));
-});<% if(filters.ts) { %>
-
-gulp.task('copy:constant', ['constant'], () => {
-    return gulp.src(`${clientPath}/app/app.constant.js`, { dot: true })
-        .pipe(gulp.dest('.tmp/app'));
-});<% } %>
+});
 
 gulp.task('transpile:server', () => {
     return gulp.src(_.union(paths.server.scripts, paths.server.json))
@@ -286,8 +281,7 @@ gulp.task('lint:scripts', cb => runSequence(['lint:scripts:client', 'lint:script
 gulp.task('lint:scripts:client', () => {
     return gulp.src(_.union(
         paths.client.scripts,
-        _.map(paths.client.test, blob => '!' + blob),
-        [`!${clientPath}/app/app.constant.<%= scriptExt %>`]
+        _.map(paths.client.test, blob => '!' + blob)
     ))
         .pipe(lintClientScripts());
 });
@@ -370,7 +364,6 @@ gulp.task('serve', cb => {
         [
             'clean:tmp',
             'lint:scripts',
-            'constant',
             'inject',
             'copy:fonts:dev',
             'env:all'<% if(filters.ts) { %>,
@@ -388,7 +381,6 @@ gulp.task('serve:debug', cb => {
         [
             'clean:tmp',
             'lint:scripts',
-            'constant',
             'inject',
             'copy:fonts:dev',
             'env:all'<% if(filters.ts) { %>,
@@ -471,7 +463,7 @@ gulp.task('coverage:integration', () => {
 // Downloads the selenium webdriver
 gulp.task('webdriver_update', webdriver_update);
 
-gulp.task('test:e2e', ['webpack:e2e', 'constant', 'env:all', 'env:test', 'start:server', 'webdriver_update'], cb => {
+gulp.task('test:e2e', ['webpack:e2e', 'env:all', 'env:test', 'start:server', 'webdriver_update'], cb => {
     gulp.src(paths.client.e2e)
         .pipe(protractor({
             configFile: 'protractor.conf.js',
@@ -480,7 +472,7 @@ gulp.task('test:e2e', ['webpack:e2e', 'constant', 'env:all', 'env:test', 'start:
         .on('end', () => { process.exit() });
 });
 
-gulp.task('test:client', ['constant'], done => {
+gulp.task('test:client', done => {
     new KarmaServer({
       configFile: `${__dirname}/${paths.karma}`,
       singleRun: true
@@ -519,21 +511,6 @@ gulp.task('build', cb => {
 
 gulp.task('clean:dist', () => del([`${paths.dist}/!(.git*|.openshift|Procfile)**`], {dot: true}));
 
-gulp.task('constant', function() {
-  let sharedConfig = require(`./${serverPath}/config/environment/shared`);
-  return plugins.ngConstant({
-    name: '<%= scriptAppName %>.constants',
-    deps: [],
-    wrap: true,
-    stream: true,
-    constants: { appConfig: sharedConfig }
-  })
-    .pipe(plugins.rename({
-      basename: 'app.constant'
-    }))
-    .pipe(gulp.dest(`${clientPath}/app/`))
-});
-
 gulp.task('build:images', () => {
     return gulp.src(paths.client.images)
         .pipe(plugins.imagemin({