Signal handling: Wait for all workers to terminate

The promise returned from `Promise.all()` immediately rejects if any
of the underlying promises reject, even if some of the other promises
have not yet settled. Catch each rejection to give the other promises
an opportunity to resolve.

`Promise.allSettled()` could be used instead, but that's a relatively
new function that was added in Node.js v12.9.0.

Author: rhansen

src/master/implementation.node.ts

@@ -35,10 +35,7 @@ const onSignal = (workers: Terminable[], signal: string) => {
   // worker.terminate() might return a Promise or might be synchronous. This async helper function
   // creates a consistent interface.
   const terminate = async (worker: Terminable) => worker.terminate()
-  Promise.all(workers.map(worker => terminate(worker))).then(
-    () => process.exit(1),
-    () => process.exit(1),
-  )
+  Promise.all(workers.map(worker => terminate(worker).catch(() => {}))).then(() => process.exit(1))
   workers.length = 0
 }
 

tslint.json

@@ -12,6 +12,7 @@
     ],
     "interface-over-type-literal": false,
     "member-ordering": false,
+    "no-empty": [true, "allow-empty-functions"],
     "no-implicit-dependencies": [
       true,
       ["tiny-worker", "worker_threads"]