Fix for non-json encoded payloads

This will make two attempts to decode the payload. If it cannot decode
the first time it will simply encode the payload then re-attempt to
decode.

While this feels like just additional overhead (why not just reply with
the original payload?) this will hopefully keep the API on the path of
using JSON responses an anticipation that the Chromium team fixes this
bug upstream. This way we don't have to introduce a bunch of forking
code to detect different payload types.

Author: bcardarella

lib/http.ex

@@ -28,7 +28,8 @@ defmodule ChromeRemoteInterface.HTTP do
   defp handle_response({:ok, status_code, _response_headers, client_ref}) do
     with true <- status_code >= 200 && status_code < 300,
       {:ok, body} <- :hackney.body(client_ref),
-      {:ok, json} <- format_body(body) |> Poison.decode() do
+      {:ok, formatted_body} <- format_body(body),
+      {:ok, json} <- decode(formatted_body) do
         {:ok, json}
     else
       error -> error
@@ -43,6 +44,13 @@ defmodule ChromeRemoteInterface.HTTP do
     {:error, reason}
   end
 
-  defp format_body(""), do: "{}"
-  defp format_body(body), do: body
+  defp format_body(""), do: format_body("{}")
+  defp format_body(body), do: {:ok, body}
+
+  defp decode(body) do
+    case Poison.decode(body) do
+      {:ok, json} -> {:ok, json}
+      {:error, _reason} -> {:ok, body}
+    end
+  end
 end