Fix botan3 not triggering handshake finish event (#292)

marty1885 · web-flow · commit 528406f0567e · 2023-08-30T17:54:57.000+08:00
diff --git a/trantor/net/inner/tlsprovider/BotanTLSProvider.cc b/trantor/net/inner/tlsprovider/BotanTLSProvider.cc
@@ -329,7 +329,8 @@ struct BotanTLSProvider : public TLSProvider,
         }
     }
 
-    bool tls_session_established(const Botan::TLS::Session &session)
+    void tls_session_established(
+        const Botan::TLS::Session_Summary &session) override
     {
         (void)session;
         LOG_TRACE << "tls_session_established";
@@ -339,8 +340,6 @@ struct BotanTLSProvider : public TLSProvider,
             if (handshakeCallback_)
                 handshakeCallback_(conn_);
         });
-        // Do we want to cache all sessions?
-        return true;
     }
 
     void tls_verify_cert_chain(

Original file line number	Diff line number	Diff line change
`@@ -329,7 +329,8 @@ struct BotanTLSProvider : public TLSProvider,`
`329`	`329`	`}`
`330`	`330`	`}`
`331`	`331`
`332`		`- bool tls_session_established(const Botan::TLS::Session &session)`
	`332`	`+ void tls_session_established(`
	`333`	`+ const Botan::TLS::Session_Summary &session) override`
`333`	`334`	`{`
`334`	`335`	`(void)session;`
`335`	`336`	`LOG_TRACE << "tls_session_established";`
`@@ -339,8 +340,6 @@ struct BotanTLSProvider : public TLSProvider,`
`339`	`340`	`if (handshakeCallback_)`
`340`	`341`	`handshakeCallback_(conn_);`
`341`	`342`	`});`
`342`		`- // Do we want to cache all sessions?`
`343`		`- return true;`
`344`	`343`	`}`
`345`	`344`
`346`	`345`	`void tls_verify_cert_chain(`