Skip to content

Commit dec9ba0

Browse files
committed
RFC #16: remove obsolete parameters in Builder.{Cluster,Index}.
1 parent dd44a7d commit dec9ba0

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

text/0016-soc-csr-regs.md

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -547,18 +547,13 @@ The `csr.reg.Builder` class can build a `MemoryMap` from a group of `csr.Registe
547547
* upon entry, creates a scope where registers added by `self.add()` are assigned to a cluster named `name`;
548548
* raises a `ValueError` if `self` is frozen;
549549
* raises a `TypeError` if `name` is not a non-empty string;
550-
* raises a `TypeError` if `size` is not a positive integer;
551-
* raises a `TypeError` if `offset` is neither a positive integer or 0;
552-
* raises a `ValueError` if `offset` is not word-aligned (i.e. a multiple of `self.data_width // self.granularity`);
550+
* raises a `ValueError` if `name` is already assigned to another register or `Cluster`;
553551

554552
- a `.Index(self, index)` context manager method, which:
555553
* upon entry, creates a scope where registers added by `self.add()` are assigned to an array index `index`;
556554
* raises a `ValueError` if `self` is frozen;
557555
* raises a `TypeError` if `index` is neither a positive integer or 0;
558556
* raises a `ValueError` if `index` is already assigned to another `Index`;
559-
* raises a `TypeError` if `size` is not a positive integer;
560-
* raises a `TypeError` if `offset` is neither a positive integer or 0;
561-
* raises a `ValueError` if `offset` is not word-aligned (i.e. a multiple of `self.data_width // self.granularity`);
562557

563558
- a `.as_memory_map(self)` method, that converts `self` into a `MemoryMap`. `self.freeze()` is implicitly called as a side-effect.
564559

0 commit comments

Comments
 (0)