fix(logging): remove redundant logging

Author: electron271

tux/cogs/services/starboard.py

@@ -9,6 +9,7 @@
 from tux.database.controllers import DatabaseController
 from tux.ui.embeds import EmbedCreator, EmbedType
 from tux.utils import checks
+from tux.utils.converters import get_channel_safe
 from tux.utils.functions import generate_usage
 
 
@@ -296,8 +297,8 @@ async def handle_starboard_reaction(self, payload: discord.RawReactionActionEven
         if not starboard or str(payload.emoji) != starboard.starboard_emoji:
             return
 
-        channel = self.bot.get_channel(payload.channel_id)
-        if not isinstance(channel, discord.TextChannel):
+        channel = await get_channel_safe(self.bot, payload.channel_id)
+        if channel is None:
             return
 
         try:

tux/cogs/utility/poll.py

@@ -1,5 +1,3 @@
-from typing import cast
-
 import discord
 from discord import app_commands
 from discord.ext import commands
@@ -9,6 +7,7 @@
 from tux.bot import Tux
 from tux.database.controllers import DatabaseController
 from tux.ui.embeds import EmbedCreator
+from tux.utils.converters import get_channel_safe
 
 # TODO: Create option inputs for the poll command instead of using a comma separated string
 
@@ -74,17 +73,9 @@ async def on_message(self, message: discord.Message) -> None:
     @commands.Cog.listener()
     async def on_raw_reaction_add(self, payload: discord.RawReactionActionEvent) -> None:
         # get reaction from payload.message_id, payload.channel_id, payload.guild_id, payload.emoji
-        channel = self.bot.get_channel(payload.channel_id)
+        channel = await get_channel_safe(self.bot, payload.channel_id)
         if channel is None:
-            try:
-                channel = await self.bot.fetch_channel(payload.channel_id)
-            except discord.NotFound:
-                logger.error(f"Channel not found for ID: {payload.channel_id}")
-                return
-            except (discord.Forbidden, discord.HTTPException) as fetch_error:
-                logger.error(f"Failed to fetch channel: {fetch_error}")
-                return
-        channel = cast(discord.TextChannel | discord.Thread, channel)
+            return
 
         message = await channel.fetch_message(payload.message_id)
         # Lookup the reaction object for this event

tux/utils/converters.py

@@ -1,9 +1,12 @@
 import re
-from typing import Any
+from typing import Any, cast
 
+import discord
 from discord.ext import commands
+from loguru import logger
 
 from prisma.enums import CaseType
+from tux.bot import Tux
 
 time_regex = re.compile(r"(\d{1,5}(?:[.,]?\d{1,5})?)([smhd])")
 time_dict = {"h": 3600, "s": 1, "m": 60, "d": 86400}
@@ -76,6 +79,21 @@ async def convert(self, ctx: commands.Context[Any], argument: str) -> CaseType:
             raise commands.BadArgument(msg) from e
 
 
+async def get_channel_safe(bot: Tux, channel_id: int) -> discord.TextChannel | discord.Thread | None:
+    """Get a channel by ID, returning None if not found."""
+    channel = bot.get_channel(channel_id)
+    if channel is None:
+        try:
+            channel = await bot.fetch_channel(channel_id)
+        except discord.NotFound:
+            logger.error(f"Channel not found for ID: {channel_id}")
+            return None
+        except (discord.Forbidden, discord.HTTPException) as fetch_error:
+            logger.error(f"Failed to fetch channel: {fetch_error}")
+            return None
+    return cast(discord.TextChannel | discord.Thread, channel)
+
+
 def convert_bool(x: str | None) -> bool | None:
     """Convert a string to a boolean value.