Skip to content

Commit 1680569

Browse files
authored
Windows build fix (learning-process#661)
1 parent 96c02e3 commit 1680569

File tree

4 files changed

+13
-12
lines changed

4 files changed

+13
-12
lines changed

cmake/gtest.cmake

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ ExternalProject_Add(
1919
$<$<BOOL:MSVC>:-Dgtest_force_shared_crt=ON>
2020
BUILD_COMMAND
2121
"${CMAKE_COMMAND}" --build
22-
"${CMAKE_CURRENT_BINARY_DIR}/ppc_googletest/build" --config
23-
${CMAKE_BUILD_TYPE} --parallel
22+
"${CMAKE_CURRENT_BINARY_DIR}/ppc_googletest/build" --config $<CONFIG>
23+
--parallel
2424
INSTALL_COMMAND
2525
"${CMAKE_COMMAND}" --install
26-
"${CMAKE_CURRENT_BINARY_DIR}/ppc_googletest/build" --prefix
27-
"${CMAKE_CURRENT_BINARY_DIR}/ppc_googletest/install")
26+
"${CMAKE_CURRENT_BINARY_DIR}/ppc_googletest/build" --config $<CONFIG>
27+
--prefix "${CMAKE_CURRENT_BINARY_DIR}/ppc_googletest/install")
2828

2929
function(ppc_link_gtest exec_func_lib)
3030
# Add external project include directories

cmake/json.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ ExternalProject_Add(
1616
-DJSON_BuildTests=OFF
1717
BUILD_COMMAND
1818
"${CMAKE_COMMAND}" --build "${CMAKE_CURRENT_BINARY_DIR}/ppc_json/build"
19-
--config ${CMAKE_BUILD_TYPE} --parallel
19+
--config $<CONFIG> --parallel
2020
INSTALL_COMMAND
2121
"${CMAKE_COMMAND}" --install "${CMAKE_CURRENT_BINARY_DIR}/ppc_json/build"
22-
--prefix "${CMAKE_CURRENT_BINARY_DIR}/ppc_json/install")
22+
--config $<CONFIG> --prefix "${CMAKE_CURRENT_BINARY_DIR}/ppc_json/install")
2323

2424
function(ppc_link_json exec_func_lib)
2525
# Add external project include directories

cmake/libenvpp.cmake

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ ExternalProject_Add(
1515
-DLIBENVPP_EXAMPLES=OFF
1616
BUILD_COMMAND
1717
"${CMAKE_COMMAND}" --build "${CMAKE_CURRENT_BINARY_DIR}/ppc_libenvpp/build"
18-
--config ${CMAKE_BUILD_TYPE} --parallel
18+
--config $<CONFIG> --parallel
1919
INSTALL_COMMAND
2020
"${CMAKE_COMMAND}" --install
21-
"${CMAKE_CURRENT_BINARY_DIR}/ppc_libenvpp/build" --prefix
22-
"${CMAKE_CURRENT_BINARY_DIR}/ppc_libenvpp/install")
21+
"${CMAKE_CURRENT_BINARY_DIR}/ppc_libenvpp/build" --config $<CONFIG>
22+
--prefix "${CMAKE_CURRENT_BINARY_DIR}/ppc_libenvpp/install")
2323

2424
string(TOLOWER "${CMAKE_BUILD_TYPE}" cmake_build_type_lower)
2525
if(cmake_build_type_lower STREQUAL "debug")
@@ -48,5 +48,6 @@ function(ppc_link_envpp exec_func_lib)
4848
target_link_directories(${exec_func_lib} PUBLIC
4949
"${CMAKE_BINARY_DIR}/ppc_libenvpp/build")
5050
target_link_libraries(${exec_func_lib} PUBLIC ${PPC_ENVPP_LIB_NAME})
51-
target_link_libraries(${exec_func_lib} PUBLIC ${PPC_FMT_LIB_NAME})
51+
target_link_libraries(${exec_func_lib} PUBLIC $<$<CONFIG:Debug>:fmtd>
52+
$<$<NOT:$<CONFIG:Debug>>:fmt>)
5253
endfunction()

cmake/onetbb.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@ if(NOT ENABLE_SYSTEM_TBB)
2929
-DTBB_TEST=OFF
3030
BUILD_COMMAND
3131
"${CMAKE_COMMAND}" --build "${CMAKE_CURRENT_BINARY_DIR}/ppc_onetbb/build"
32-
--config ${CMAKE_BUILD_TYPE} --parallel
32+
--config $<CONFIG> --parallel
3333
INSTALL_COMMAND
3434
"${CMAKE_COMMAND}" --install
35-
"${CMAKE_CURRENT_BINARY_DIR}/ppc_onetbb/build" --prefix
35+
"${CMAKE_CURRENT_BINARY_DIR}/ppc_onetbb/build" --config $<CONFIG> --prefix
3636
"${CMAKE_CURRENT_BINARY_DIR}/ppc_onetbb/install"
3737
TEST_COMMAND ${ppc_onetbb_TEST_COMMAND})
3838

0 commit comments

Comments
 (0)