From dfba747ce1aa67958f00ac1b1a736065be441c6e Mon Sep 17 00:00:00 2001 From: Gary Conroy Date: Thu, 6 Nov 2025 10:57:16 +0000 Subject: [PATCH 1/2] fix(specs): Add title values to key oneOfs --- specs/abtesting-v3/common/schemas/AddABTestsVariant.yml | 7 ++++--- specs/abtesting/common/schemas/AddABTestsVariant.yml | 6 ++++-- .../schemas/requestBodies/BatchCompositionAction.yml | 6 ++++-- .../schemas/requestBodies/RulesBatchCompositionAction.yml | 8 +++++--- specs/composition/paths/compositions/composition.yml | 4 ++-- specs/ingestion/common/schemas/task.yml | 3 +++ specs/ingestion/common/schemas/transformation.yml | 2 ++ .../recommend/common/schemas/RecommendationsResponse.yml | 1 + 8 files changed, 25 insertions(+), 12 deletions(-) diff --git a/specs/abtesting-v3/common/schemas/AddABTestsVariant.yml b/specs/abtesting-v3/common/schemas/AddABTestsVariant.yml index fc14f380240..af5db7e058c 100644 --- a/specs/abtesting-v3/common/schemas/AddABTestsVariant.yml +++ b/specs/abtesting-v3/common/schemas/AddABTestsVariant.yml @@ -1,8 +1,9 @@ AddABTestsVariant: oneOf: - - $ref: '#/abTestsVariant' - - $ref: '#/abTestsVariantSearchParams' - + - title: Variant + $ref: '#/abTestsVariant' + - title: Variant with search parameters + $ref: '#/abTestsVariantSearchParams' abTestsVariantSearchParams: allOf: - $ref: '#/abTestsVariant' diff --git a/specs/abtesting/common/schemas/AddABTestsVariant.yml b/specs/abtesting/common/schemas/AddABTestsVariant.yml index fc14f380240..3399ed9fc77 100644 --- a/specs/abtesting/common/schemas/AddABTestsVariant.yml +++ b/specs/abtesting/common/schemas/AddABTestsVariant.yml @@ -1,7 +1,9 @@ AddABTestsVariant: oneOf: - - $ref: '#/abTestsVariant' - - $ref: '#/abTestsVariantSearchParams' + - title: Variant + $ref: '#/abTestsVariant' + - title: Variant with search parameters + $ref: '#/abTestsVariantSearchParams' abTestsVariantSearchParams: allOf: diff --git a/specs/composition/common/schemas/requestBodies/BatchCompositionAction.yml b/specs/composition/common/schemas/requestBodies/BatchCompositionAction.yml index ae8062fb122..6d5cbf2a02f 100644 --- a/specs/composition/common/schemas/requestBodies/BatchCompositionAction.yml +++ b/specs/composition/common/schemas/requestBodies/BatchCompositionAction.yml @@ -10,5 +10,7 @@ deleteCompositionAction: batchCompositionAction: oneOf: - - $ref: '../components/Composition.yml#/composition' - - $ref: '#/deleteCompositionAction' + - title: Upsert (update and insert) + $ref: '../components/Composition.yml#/composition' + - title: Delete + $ref: '#/deleteCompositionAction' diff --git a/specs/composition/common/schemas/requestBodies/RulesBatchCompositionAction.yml b/specs/composition/common/schemas/requestBodies/RulesBatchCompositionAction.yml index 8f1537f6d32..778bda12f69 100644 --- a/specs/composition/common/schemas/requestBodies/RulesBatchCompositionAction.yml +++ b/specs/composition/common/schemas/requestBodies/RulesBatchCompositionAction.yml @@ -9,6 +9,8 @@ deleteCompositionRuleAction: - objectID rulesBatchCompositionAction: - oneOf: - - $ref: '../components/CompositionRule.yml#/compositionRule' - - $ref: '#/deleteCompositionRuleAction' +oneOf: + - title: Upsert (update and insert) + $ref: '../components/CompositionRule.yml#/compositionRule' + - title: Delete + $ref: '#/deleteCompositionRuleAction' diff --git a/specs/composition/paths/compositions/composition.yml b/specs/composition/paths/compositions/composition.yml index 5c8ab04edf1..9ff1cf263b8 100644 --- a/specs/composition/paths/compositions/composition.yml +++ b/specs/composition/paths/compositions/composition.yml @@ -32,9 +32,9 @@ put: operationId: putComposition x-acl: - editSettings - summary: Upsert a composition + summary: Update and insert (upsert) a composition description: | - Upsert a composition in the current Algolia application. + Update and insert a composition in the current Algolia application. parameters: - $ref: '../urlParams.yml#/compositionID' requestBody: diff --git a/specs/ingestion/common/schemas/task.yml b/specs/ingestion/common/schemas/task.yml index 5e6e80b6fb9..a64b7e0471b 100644 --- a/specs/ingestion/common/schemas/task.yml +++ b/specs/ingestion/common/schemas/task.yml @@ -509,6 +509,7 @@ MappingInput: - actions StreamingInput: + title: Streaming input type: object additionalProperties: false description: Input for a `streaming` task whose source is of type `ga4BigqueryExport` and for which extracted data is continuously streamed. @@ -521,6 +522,7 @@ StreamingInput: - mapping DockerStreamsInput: + title: Docker streams description: The selected streams of an airbyte connector. type: object properties: @@ -562,6 +564,7 @@ failureThreshold: description: Maximum accepted percentage of failures for a task run to finish successfully. ShopifyInput: + title: Shopify input type: object additionalProperties: false description: Represents the required elements of the task input when using a `shopify` source. diff --git a/specs/ingestion/common/schemas/transformation.yml b/specs/ingestion/common/schemas/transformation.yml index 211737b9552..5cd2d6f0cf7 100644 --- a/specs/ingestion/common/schemas/transformation.yml +++ b/specs/ingestion/common/schemas/transformation.yml @@ -43,6 +43,7 @@ TransformationInput: - $ref: '#/TransformationNoCode' TransformationCode: + title: Code type: object additionalProperties: false description: Input for a transformation that contains the source code of the transformation. @@ -54,6 +55,7 @@ TransformationCode: - code TransformationNoCode: + title: No-code type: object additionalProperties: false description: Input for a no-code transformation that contains a series of steps. diff --git a/specs/recommend/common/schemas/RecommendationsResponse.yml b/specs/recommend/common/schemas/RecommendationsResponse.yml index 64a0b106877..7df6c58bc87 100644 --- a/specs/recommend/common/schemas/RecommendationsResponse.yml +++ b/specs/recommend/common/schemas/RecommendationsResponse.yml @@ -45,6 +45,7 @@ recommendHit: trendingFacetHit: type: object + title: Trending facet hit description: Trending facet hit. required: - facetName From c0f14038d267d7e11731668dd4b7d5aa4e4ce906 Mon Sep 17 00:00:00 2001 From: Pierre Millot Date: Wed, 12 Nov 2025 10:59:54 +0100 Subject: [PATCH 2/2] fix indentation --- .../requestBodies/RulesBatchCompositionAction.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/specs/composition/common/schemas/requestBodies/RulesBatchCompositionAction.yml b/specs/composition/common/schemas/requestBodies/RulesBatchCompositionAction.yml index 778bda12f69..1ef2e2d6dd1 100644 --- a/specs/composition/common/schemas/requestBodies/RulesBatchCompositionAction.yml +++ b/specs/composition/common/schemas/requestBodies/RulesBatchCompositionAction.yml @@ -9,8 +9,8 @@ deleteCompositionRuleAction: - objectID rulesBatchCompositionAction: -oneOf: - - title: Upsert (update and insert) - $ref: '../components/CompositionRule.yml#/compositionRule' - - title: Delete - $ref: '#/deleteCompositionRuleAction' + oneOf: + - title: Upsert (update and insert) + $ref: '../components/CompositionRule.yml#/compositionRule' + - title: Delete + $ref: '#/deleteCompositionRuleAction'