Skip to content

Commit e232324

Browse files
authored
Fix incompatible method declaration (#59)
* fix incompatible method declaration * fix more incompatible method declarations
1 parent f2ccfc1 commit e232324

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/DependencyContainer.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ protected function getFieldLayout($field, $value = null)
178178
* @param mixed $resource
179179
* @param null $attribute
180180
*/
181-
public function resolveForDisplay($resource, $attribute = null)
181+
public function resolveForDisplay($resource, $attribute = null): void
182182
{
183183
foreach ($this->meta['fields'] as $field) {
184184
$field->resolveForDisplay($resource);
@@ -247,7 +247,7 @@ public function resolveForDisplay($resource, $attribute = null)
247247
* @param string $attribute
248248
* @return array|mixed
249249
*/
250-
public function resolve($resource, $attribute = null)
250+
public function resolve($resource, $attribute = null): void
251251
{
252252
foreach ($this->meta['fields'] as $field) {
253253
$field->resolve($resource, $attribute);
@@ -418,7 +418,7 @@ protected function array_simplify($array): array
418418
* @param NovaRequest $request
419419
* @return array
420420
*/
421-
public function getRules(NovaRequest $request)
421+
public function getRules(NovaRequest $request): array
422422
{
423423
return $this->getSituationalRulesSet($request);
424424
}
@@ -429,7 +429,7 @@ public function getRules(NovaRequest $request)
429429
* @param NovaRequest $request
430430
* @return array|string
431431
*/
432-
public function getCreationRules(NovaRequest $request)
432+
public function getCreationRules(NovaRequest $request): array
433433
{
434434
$fieldsRules = $this->getSituationalRulesSet($request, 'getCreationRules');
435435

@@ -445,7 +445,7 @@ public function getCreationRules(NovaRequest $request)
445445
* @param NovaRequest $request
446446
* @return array
447447
*/
448-
public function getUpdateRules(NovaRequest $request)
448+
public function getUpdateRules(NovaRequest $request): array
449449
{
450450
$fieldsRules = $this->getSituationalRulesSet($request, 'getUpdateRules');
451451

src/HasDependencies.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ trait HasDependencies
1515
* @param NovaRequest $request
1616
* @return FieldCollection
1717
*/
18-
public function availableFields(NovaRequest $request)
18+
public function availableFields(NovaRequest $request): FieldCollection
1919
{
2020
$method = $this->fieldsMethod($request);
2121

src/Http/Controllers/ActionController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class ActionController extends NovaActionController
1515
* @param \Laravel\Nova\Http\Requests\ActionRequest $request
1616
* @return \Illuminate\Http\Response
1717
*/
18-
public function store(NovaActionRequest $request)
18+
public function store(NovaActionRequest $request): mixed
1919
{
2020
$action = $request->action();
2121

0 commit comments

Comments
 (0)