Merge pull request #351 from martinjaimem/fix-parameters-change

Fix Maintain Unchanged Hash Parameter in Method json_post

Author: alexrudall

lib/openai/http.rb

@@ -10,15 +10,7 @@ def get(path:)
 
     def json_post(path:, parameters:)
       to_json(conn.post(uri(path: path)) do |req|
-        if parameters[:stream].respond_to?(:call)
-          req.options.on_data = to_json_stream(user_proc: parameters[:stream])
-          parameters[:stream] = true # Necessary to tell OpenAI to stream.
-        elsif parameters[:stream]
-          raise ArgumentError, "The stream parameter must be a Proc or have a #call method"
-        end
-
-        req.headers = headers
-        req.body = parameters.to_json
+        configure_json_post_request(req, parameters)
       end&.body)
     end
 
@@ -117,5 +109,19 @@ def multipart_parameters(parameters)
         Faraday::UploadIO.new(value, "", value.path)
       end
     end
+
+    def configure_json_post_request(req, parameters)
+      req_parameters = parameters.dup
+
+      if parameters[:stream].respond_to?(:call)
+        req.options.on_data = to_json_stream(user_proc: parameters[:stream])
+        req_parameters[:stream] = true # Necessary to tell OpenAI to stream.
+      elsif parameters[:stream]
+        raise ArgumentError, "The stream parameter must be a Proc or have a #call method"
+      end
+
+      req.headers = headers
+      req.body = req_parameters.to_json
+    end
   end
 end

spec/openai/client/http_spec.rb

@@ -31,13 +31,15 @@
 
     describe ".json_post" do
       let(:response) do
-        OpenAI::Client.new.chat(
-          parameters: {
-            model: "gpt-3.5-turbo",
-            messages: [{ role: "user", content: "Hello!" }],
-            stream: stream
-          }
-        )
+        OpenAI::Client.new.chat(parameters: parameters)
+      end
+
+      let(:parameters) do
+        {
+          model: "gpt-3.5-turbo",
+          messages: [{ role: "user", content: "Hello!" }],
+          stream: stream
+        }
       end
 
       context "not streaming" do
@@ -63,6 +65,12 @@
             expect(timeout_errors).to include(error.class)
           end
         end
+
+        it "doesn't change the parameters stream proc" do
+          expect { response }.to raise_error(Faraday::ConnectionFailed)
+
+          expect(parameters[:stream]).to eq(stream)
+        end
       end
     end