Use skip instead of finishing the specs with pending

Author: alexrudall

spec/fixtures/cassettes/groq_llama3-8b-8192_streamed_chat.yml

@@ -23,7 +23,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Sun, 28 Apr 2024 12:58:48 GMT
+      - Sun, 28 Apr 2024 13:05:41 GMT
       Content-Type:
       - text/event-stream
       Transfer-Encoding:
@@ -47,80 +47,80 @@ http_interactions:
       X-Ratelimit-Reset-Tokens:
       - 30ms
       X-Request-Id:
-      - req_01hwjcjqzaebarxz5f2vm7fz34
+      - req_01hwjczb7afhg9e7zqn0mnywg7
       Via:
       - 1.1 google
       Alt-Svc:
       - h3=":443"; ma=86400
       Cf-Cache-Status:
       - DYNAMIC
       Set-Cookie:
-      - __cf_bm=.ZNFRsf2P9DwyqjhO3cuf9Pu_3fVQzLXYXtUcJ_UMkI-1714309128-1.0.1.1-w6OhIRMxkM4Ouz9NIqUiuv8Kd1o9nuCib2x07qAHI12yNx193y6_5ol27ayr.mfxkd0ME.JLgC3W5DGsXoA3SA;
-        path=/; expires=Sun, 28-Apr-24 13:28:48 GMT; domain=.groq.com; HttpOnly; Secure;
+      - __cf_bm=xHuL5RFQoJ.mqMxavaro0kYIPV9NURWRXdlvUHwN6MM-1714309541-1.0.1.1-fFylSLXd3KLR4il9V_60KZ20_CLkP845Q.8l6dILyABTd_a3ZF21epbOHaONZJyvu9zMABl2NV88E6AOhGi3hA;
+        path=/; expires=Sun, 28-Apr-24 13:35:41 GMT; domain=.groq.com; HttpOnly; Secure;
         SameSite=None
       Server:
       - cloudflare
       Cf-Ray:
-      - 87b739d22ceb1c23-SOF
+      - 87b743e74c951c33-SOF
     body:
       encoding: UTF-8
       string: |+
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":null,"choices":[{"index":0,"delta":{"role":"assistant","content":""},"logprobs":null,"finish_reason":null}],"x_groq":{"id":"req_01hwjcjqzaebarxz5f2vm7fz34"}}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":null,"choices":[{"index":0,"delta":{"role":"assistant","content":""},"logprobs":null,"finish_reason":null}],"x_groq":{"id":"req_01hwjczb7afhg9e7zqn0mnywg7"}}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":"Hello"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":"Hello"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":"!"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":"!"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" It"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" It"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":"'s"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":"'s"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" nice"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" nice"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" to"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" to"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" meet"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" meet"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" you"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" you"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":"."},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":"."},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" Is"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" Is"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" there"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" there"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" something"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" something"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" I"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" I"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" can"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" can"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" help"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" help"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" you"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" you"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" with"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" with"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":","},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":","},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" or"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" or"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" would"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" would"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" you"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" you"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" like"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" like"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" to"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" to"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":" chat"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":" chat"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{"content":"?"},"logprobs":null,"finish_reason":null}]}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{"content":"?"},"logprobs":null,"finish_reason":null}]}
 
-        data: {"id":"chatcmpl-020c62b8-ef08-4c4f-8d11-5fe27c0ad788","object":"chat.completion.chunk","created":1714309128,"model":"llama3-8b-8192","system_fingerprint":"fp_dadc9d6142","choices":[{"index":0,"delta":{},"logprobs":null,"finish_reason":"stop"}],"x_groq":{"id":"req_01hwjcjqzaebarxz5f2vm7fz34","usage":{"queue_time":0.085418399,"prompt_tokens":12,"prompt_time":0.005,"completion_tokens":25,"completion_time":0.029,"total_tokens":37,"total_time":0.034}}}
+        data: {"id":"chatcmpl-e2ff9cf2-3dde-4dab-b7fd-c197131a47e0","object":"chat.completion.chunk","created":1714309541,"model":"llama3-8b-8192","system_fingerprint":"fp_6a6771ae9c","choices":[{"index":0,"delta":{},"logprobs":null,"finish_reason":"stop"}],"x_groq":{"id":"req_01hwjczb7afhg9e7zqn0mnywg7","usage":{"queue_time":0.085075623,"prompt_tokens":12,"prompt_time":0.006,"completion_tokens":25,"completion_time":0.027,"total_tokens":37,"total_time":0.033}}}
 
         data: [DONE]
 
-  recorded_at: Sun, 28 Apr 2024 12:58:48 GMT
+  recorded_at: Sun, 28 Apr 2024 13:05:41 GMT
 recorded_with: VCR 6.1.0
 ...

spec/openai/client/chat_spec.rb

@@ -185,7 +185,7 @@ def call(chunk)
             vcr_skip do
               Faraday.new(url: uri_base).get
             rescue Faraday::ConnectionFailed
-              pending "This test needs `ollama serve` running locally with #{model} installed"
+              skip "This test needs `ollama serve` running locally with #{model} installed"
             end
 
             expect(content.split.empty?).to eq(false)
@@ -206,15 +206,14 @@ def call(chunk)
         let(:chunks) { [] }
         let(:stream) do
           proc do |chunk, _bytesize|
-            print chunk["choices"][0]["delta"]["content"]
             chunks << chunk
           end
         end
 
         it "succeeds" do
           VCR.use_cassette(cassette) do
             unless access_token
-              pending "This test needs a `GROQ_ACCESS_TOKEN` environment variable to run"
+              skip "This test needs a `GROQ_ACCESS_TOKEN` environment variable to run"
             end
 
             response