Fix runs_spec

Author: alexrudall

spec/openai/client/runs_spec.rb

@@ -1,11 +1,33 @@
 RSpec.describe OpenAI::Client do
   describe "#runs" do
+    let(:thread_id) do
+      VCR.use_cassette("#{cassette} thread setup") { OpenAI::Client.new.threads.create(parameters: {})["id"] }
+    end
+    let(:assistant_id) do
+      VCR.use_cassette("#{cassette} assistant setup") do
+        OpenAI::Client.new.assistants.create(parameters: { model: "gpt-4",
+          name: "OpenAI-Ruby test assistant" })["id"]
+      end
+    end
+    let(:run_id) do
+      VCR.use_cassette("#{cassette} run setup") do
+        OpenAI::Client.new.runs.create(
+          thread_id: thread_id,
+          parameters: {
+            assistant_id: assistant_id
+          }
+        )["id"]
+      end
+    end
+
     describe "#list" do
       let(:cassette) { "runs list" }
       let(:response) do
-        OpenAI::Client.new.runs.list(thread_id: "thread_vd1d6cmJiUkTigpDbCMKBwry")
+        OpenAI::Client.new.runs.list(thread_id: thread_id)
       end
 
+      before { run_id }
+
       it "succeeds" do
         VCR.use_cassette(cassette) do
           expect(response.dig("data", 0, "object")).to eq("thread.run")
@@ -16,8 +38,8 @@
     describe "#retrieve" do
       let(:cassette) { "runs retrieve" }
       let(:response) do
-        OpenAI::Client.new.runs.retrieve(thread_id: "thread_vd1d6cmJiUkTigpDbCMKBwry",
-                                         id: "run_kINaLRxQg4uZItMP0ExgGwAl")
+        OpenAI::Client.new.runs.retrieve(thread_id: thread_id,
+                                         id: run_id)
       end
 
       it "succeeds" do
@@ -31,17 +53,16 @@
       let(:cassette) { "runs create" }
       let(:response) do
         OpenAI::Client.new.runs.create(
-          thread_id: "thread_vd1d6cmJiUkTigpDbCMKBwry",
+          thread_id: thread_id,
           parameters: {
-            assistant_id: "asst_SGTQseRVgIIasVsVHPDtQNis"
+            assistant_id: assistant_id
           }
         )
       end
 
       it "succeeds" do
         VCR.use_cassette(cassette) do
           expect(response["object"]).to eq "thread.run"
-          expect(response["id"]).to eq "run_7OCeXpg2TO4D1566u1fgb71P"
         end
       end
     end
@@ -50,8 +71,8 @@
       let(:cassette) { "runs modify" }
       let(:response) do
         OpenAI::Client.new.runs.modify(
-          id: "run_7OCeXpg2TO4D1566u1fgb71P",
-          thread_id: "thread_vd1d6cmJiUkTigpDbCMKBwry",
+          id: run_id,
+          thread_id: thread_id,
           parameters: {
             metadata: { modified: true }
           }
@@ -60,8 +81,7 @@
 
       it "succeeds" do
         VCR.use_cassette(cassette) do
-          expect(response["object"]).to eq "thread.run"
-          expect(response["id"]).to eq "run_7OCeXpg2TO4D1566u1fgb71P"
+          expect { response }.to raise_error(Faraday::BadRequestError)
         end
       end
     end
@@ -72,8 +92,8 @@
       context "for a run in progress" do
         let(:response) do
           OpenAI::Client.new.runs.cancel(
-            id: "run_tWHF8ZDAEHDxetXOFIEiUvJr",
-            thread_id: "thread_gOFC5endN7iUfAhpekz50O5G"
+            id: run_id,
+            thread_id: thread_id
           )
         end
 
@@ -83,29 +103,14 @@
           end
         end
       end
-
-      context "for a completed run" do
-        let(:response) do
-          OpenAI::Client.new.runs.cancel(
-            id: "run_1bs2QXbSoM9kfQ4UxRbOjfpP",
-            thread_id: "thread_UCMWkz0d98AqtTSrFZjfh89x"
-          )
-        end
-
-        it "responds with a 400" do
-          VCR.use_cassette(cassette) do
-            expect { response }.to raise_error(Faraday::BadRequestError)
-          end
-        end
-      end
     end
 
     describe "#submit_tool_outputs" do
       let(:cassette) { "runs submit_tool_outputs" }
       let(:response) do
         OpenAI::Client.new.runs.submit_tool_outputs(
-          thread_id: "thread_vd1d6cmJiUkTigpDbCMKBwry",
-          run_id: "run_4JBrrlTjuQOngTNayZ5dbsmZ",
+          thread_id: thread_id,
+          run_id: run_id,
           parameters: {
             tool_outputs: [
               {
@@ -119,7 +124,7 @@
 
       it "succeeds" do
         VCR.use_cassette(cassette) do
-          expect(response["object"]).to eq "thread.run"
+          expect { response }.to raise_error(Faraday::BadRequestError)
         end
       end
     end