Add back JSONL parsing

Author: alexrudall

lib/openai/http.rb

@@ -3,9 +3,9 @@
 module OpenAI
   module HTTP
     def get(path:)
-      conn.get(uri(path: path)) do |req|
+      parse_jsonl(conn.get(uri(path: path)) do |req|
         req.headers = headers
-      end&.body
+      end&.body)
     end
 
     def json_post(path:, parameters:)
@@ -29,6 +29,16 @@ def delete(path:)
 
     private
 
+    def parse_jsonl(response)
+      return unless response
+      return response unless response.is_a?(String)
+
+      # Convert a multiline string of JSON objects to a JSON array.
+      response = response.gsub("}\n{", "},{").prepend("[").concat("]")
+
+      JSON.parse(response)
+    end
+
     # Given a proc, returns an outer proc that can be used to iterate over a JSON stream of chunks.
     # For each chunk, the inner user_proc is called giving it the JSON object. The JSON object could
     # be a data object or an error object as described in the OpenAI API documentation.

spec/openai/client/chat_spec.rb

@@ -77,7 +77,7 @@ def call(chunk)
             let(:cassette) { "#{model} streamed chat with error response".downcase }
 
             it "raises an HTTP error" do
-              VCR.use_cassette(cassette) do
+              VCR.use_cassette(cassette, record: :none) do
                 response
               rescue Faraday::BadRequestError => e
                 expect(e.response).to include(status: 400)

spec/openai/client/http_spec.rb

@@ -109,7 +109,7 @@
       let(:cassette) { "http get with error response".downcase }
 
       it "raises an HTTP error" do
-        VCR.use_cassette(cassette) do
+        VCR.use_cassette(cassette, record: :none) do
           OpenAI::Client.new.models.retrieve(id: "text-ada-001")
         rescue Faraday::Error => e
           expect(e.response).to include(status: 400)
@@ -189,6 +189,15 @@
     end
   end
 
+  describe ".parse_jsonl" do
+    context "with a jsonl string" do
+      let(:body) { "{\"prompt\":\":)\"}\n{\"prompt\":\":(\"}\n" }
+      let(:parsed) { OpenAI::Client.new.send(:parse_jsonl, body) }
+
+      it { expect(parsed).to eq([{ "prompt" => ":)" }, { "prompt" => ":(" }]) }
+    end
+  end
+
   describe ".uri" do
     let(:path) { "/chat" }
     let(:uri) { OpenAI::Client.new.send(:uri, path: path) }