Skip to content

Commit d7e4beb

Browse files
authored
Upgraded pub packages for Flutter v3.13.6 (#256)
* upgraded for flutter v3.13.6 * Update dart.yaml: updated flutter_version from 3.10.2 to 3.13.6 * Update dart.yaml: added flutter clean * Update dart.yaml * downgraded meta back to v1.9.1 because of ci workflow * collection: ^1.17.2 * cleared dart analyze --fatal-infos and checked flutter test * using replacedText instead of self-assignment
1 parent 149888a commit d7e4beb

File tree

8 files changed

+25
-17
lines changed

8 files changed

+25
-17
lines changed

.github/workflows/dart.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
branches: [ '**' ]
88

99
env:
10-
flutter_version: 3.10.2
10+
flutter_version: 3.13.6
1111

1212
jobs:
1313
build:
@@ -29,9 +29,13 @@ jobs:
2929

3030
- run: flutter --version
3131

32+
- run: flutter clean
33+
3234
- name: Install Dependencies
3335
run: flutter pub get
3436

37+
- run: flutter pub outdated
38+
3539
- name: Analyze
3640
run: dart analyze --fatal-infos
3741

example/pubspec.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,18 @@ version: 1.0.0+1
55

66
environment:
77
sdk: '>=2.17.0 <3.0.0'
8-
flutter: '>=3.0.0'
8+
flutter: ">=3.13.6"
99

1010
dependencies:
1111
flutter: { sdk: flutter }
1212
flutter_code_editor: { path: ../ }
1313
flutter_highlight: ^0.7.0
1414
highlight: ^0.7.0
15-
http: ^0.13.5
15+
http: ^1.1.0
1616

1717
dev_dependencies:
1818
flutter_test: { sdk: flutter }
19-
total_lints: ^2.17.4
19+
total_lints: ^3.1.1
2020

2121
flutter:
2222
uses-material-design: true

lib/src/search/controller.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ class CodeSearchController extends ChangeNotifier {
7373
patternFocusNode.unfocus();
7474
_hidingTimer?.cancel();
7575

76-
if (returnFocusToCodeField == true) {
76+
if (returnFocusToCodeField) {
7777
_codeFieldFocusNode?.requestFocus();
7878
}
7979

@@ -160,8 +160,8 @@ class CodeSearchController extends ChangeNotifier {
160160
return;
161161
}
162162

163-
final shouldDismiss = patternFocusNode.hasFocus == false &&
164-
_codeFieldFocusNode?.hasFocus == false;
163+
final shouldDismiss =
164+
!patternFocusNode.hasFocus && _codeFieldFocusNode?.hasFocus == false;
165165

166166
if (shouldDismiss) {
167167
hideSearch(returnFocusToCodeField: false);

pubspec.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,23 +11,23 @@ dependencies:
1111
autotrie: ^2.0.0
1212
characters: ^1.2.1
1313
charcode: ^1.3.1
14-
collection: ^1.16.0
14+
collection: ^1.17.2
1515
equatable: ^2.0.5
1616
flutter: { sdk: flutter }
1717
flutter_highlight: ^0.7.0
1818
highlight: ^0.7.0
19-
http: ^0.13.5
19+
http: ^1.1.0
2020
linked_scroll_controller: ^0.2.0
21-
meta: ^1.7.0
22-
mocktail: ^0.3.0
21+
meta: ^1.9.1
22+
mocktail: ^1.0.1
2323
scrollable_positioned_list: ^0.3.5
2424
tuple: ^2.0.1
2525
url_launcher: ^6.1.8
2626

2727
dev_dependencies:
2828
fake_async: ^1.3.1
2929
flutter_test: { sdk: flutter }
30-
total_lints: ^2.18.0
30+
total_lints: ^3.1.1
3131

3232
flutter:
3333
uses-material-design: true

test/src/code/string_get_changed_range_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ void main() {
8282
str1: 'abccde',
8383
str2: 'abcde',
8484
expected: [TextRange(start: 2, end: 2), TextRange(start: 3, end: 3)],
85-
)
85+
),
8686
];
8787
const affinities = [TextAffinity.upstream, TextAffinity.downstream];
8888

test/src/folding/parsers/highlight_parser_go_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ func (
5858
InvalidFoldableBlock(endLine: 6, type: FBT.braces),
5959
InvalidFoldableBlock(endLine: 6, type: FBT.braces),
6060
InvalidFoldableBlock(startLine: 6, type: FBT.parentheses),
61-
InvalidFoldableBlock(endLine: 8, type: FBT.braces)
61+
InvalidFoldableBlock(endLine: 8, type: FBT.braces),
6262
];
6363
_Tester.parseAndCheck(
6464
mode: go,

test/src/folding/parsers/indent_parser_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ numbers = [1,
169169
5
170170
]''',
171171
expected: [_FB(firstLine: 0, lastLine: 4, type: _T.indent)],
172-
)
172+
),
173173
];
174174

175175
for (final example in examples) {

test/src/history/code_history_controller_test.dart

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,14 @@ void main() {
7676
final controller = await pumpController(wt, MethodSnippet.full);
7777
await wt.cursorEnd();
7878

79-
controller.value = controller.value;
79+
controller.value = controller.value.replacedText(
80+
controller.value.text,
81+
);
8082
controller.value = controller.value.typed('a');
8183
controller.value = controller.value.typed('b');
82-
controller.value = controller.value;
84+
controller.value = controller.value.replacedText(
85+
controller.value.text,
86+
);
8387
controller.foldAt(0);
8488
controller.unfoldAt(0);
8589

0 commit comments

Comments
 (0)