Issue 241: Dispose suggestions popup (#244)

* _suggestionsCloseNotifier

* removed public notifier

* Auto-format, update Flutter version in CI (#241)

* Fix analyzer issues (#241)

* Fix tests (#241)

---------

Co-authored-by: Alexey Inkin <leha@inkin.ru>

Author: nausharipov

.github/workflows/dart.yaml

@@ -7,7 +7,7 @@ on:
     branches: [ '**' ]
 
 env:
-  flutter_version: 3.7.1
+  flutter_version: 3.10.2
 
 jobs:
   build:

lib/src/code_field/code_controller.dart

@@ -144,7 +144,7 @@ class CodeController extends TextEditingController {
     Set<String> readOnlySectionNames = const {},
     Set<String> visibleSectionNames = const {},
     @Deprecated('Use CodeTheme widget to provide theme to CodeField.')
-        Map<String, TextStyle>? theme,
+    Map<String, TextStyle>? theme,
     this.analysisResult = const AnalysisResult(issues: []),
     this.patternMap,
     this.readOnly = false,

lib/src/code_field/code_field.dart

@@ -186,7 +186,7 @@ class CodeField extends StatefulWidget {
     this.onChanged,
     @Deprecated('Use gutterStyle instead') this.lineNumbers,
     @Deprecated('Use gutterStyle instead')
-        this.lineNumberStyle = const GutterStyle(),
+    this.lineNumberStyle = const GutterStyle(),
   })  : assert(
             gutterStyle == null || lineNumbers == null,
             'Can not provide gutterStyle and lineNumbers at the same time. '
@@ -264,6 +264,7 @@ class _CodeFieldState extends State<CodeField> {
     widget.controller.removeListener(_onTextChanged);
     widget.controller.removeListener(_updatePopupOffset);
     widget.controller.popupController.removeListener(_onPopupStateChanged);
+    _suggestionsPopup?.remove();
     widget.controller.searchController.removeListener(
       _onSearchControllerChange,
     );

lib/src/gutter/gutter.dart

@@ -1,3 +1,6 @@
+// TODO(alexeyinkin): Remove when dropping support for Flutter < 3.10, https://github.com/akvelon/flutter-code-editor/issues/245
+// ignore_for_file: unnecessary_non_null_assertion
+
 import 'package:flutter/material.dart';
 
 import '../code_field/code_controller.dart';

test/src/code_field/code_controller_readonly_test.dart

@@ -121,7 +121,6 @@ void main() {
             //               cursor /
             selection: TextSelection.collapsed(
               offset: 14,
-              affinity: TextAffinity.upstream,
             ),
           ),
           reason: 'Delete - no effect',
@@ -460,7 +459,6 @@ void main() {
             //          cursor /
             selection: TextSelection.collapsed(
               offset: 10,
-              affinity: TextAffinity.upstream,
             ),
           ),
           reason: 'Backspace Delete Type at last empty line - No effect',

test/src/code_field/code_controller_shortcut_test.dart

@@ -18,12 +18,16 @@ class MyClass {
 void main() {
   final calls = <MethodCall>[];
 
-  void mockClipboardHandler() {
+  void mockClipboardHandler(WidgetTester wt) {
     calls.clear();
 
-    SystemChannels.platform.setMockMethodCallHandler((MethodCall call) async {
-      calls.add(call);
-    });
+    wt.binding.defaultBinaryMessenger.setMockMethodCallHandler(
+      SystemChannels.platform,
+      (MethodCall call) async {
+        calls.add(call);
+        return null;
+      },
+    );
   }
 
   group('CodeController. Shortcuts.', () {
@@ -97,7 +101,7 @@ void main() {
         controller.value = const TextEditingValue(text: MethodSnippet.full);
         controller.foldAt(1);
         await wt.selectFromHome(18, offset: 16);
-        mockClipboardHandler();
+        mockClipboardHandler(wt);
 
         await example.act();
 

test/src/history/code_history_controller_test.dart

@@ -258,7 +258,6 @@ void main() {
           controller.selection,
           const TextSelection.collapsed(
             offset: MethodSnippet.visible.length,
-            affinity: TextAffinity.upstream,
           ),
         );
 
@@ -269,7 +268,6 @@ void main() {
           controller.selection,
           const TextSelection.collapsed(
             offset: MethodSnippet.visible.length,
-            affinity: TextAffinity.upstream,
           ),
         );
       });