Skip to content

Check current viewport against responsive settings on initial load (fixes #2439) #2440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check current viewport against responsive settings on initial load (fixes #2439) #2440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions playwright-tests/features/responsive/responsive.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { test, expect } from "@playwright/experimental-ct-react";
import Responsive from "./responsive.story";

test.use({ viewport: { width: 1200, height: 500 } });
test.use({ viewport: { width: 1000, height: 500 } });

async function activeSlidesCount(component) {
return await component.locator(".slick-slide.slick-active").count();
Expand All @@ -10,11 +10,11 @@ async function activeSlidesCount(component) {
test("Responsive settings", async ({ mount, page }) => {
const component = await mount(<Responsive />);

await expect(await activeSlidesCount(component)).toEqual(4);
await expect(await activeSlidesCount(component)).toEqual(3);

await page.setViewportSize({ width: 1000, height: 500 });
await page.setViewportSize({ width: 1200, height: 500 });
await page.waitForTimeout(100);
await expect(await activeSlidesCount(component)).toEqual(3);
await expect(await activeSlidesCount(component)).toEqual(4);

await page.setViewportSize({ width: 600, height: 500 });
await page.waitForTimeout(100);
Expand All @@ -35,4 +35,4 @@ test("Responsive settings", async ({ mount, page }) => {
await page.setViewportSize({ width: 1500, height: 500 });
await page.waitForTimeout(100);
await expect(await activeSlidesCount(component)).toEqual(4);
});
});
6 changes: 6 additions & 0 deletions src/slider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ export default class Slider extends React.Component {
}
};
mql.addListener(listener);

// Manually check if the query currently matches on initial load
if (mql.matches) {
handler();
}

this._responsiveMediaHandlers.push({ mql, query, listener });
}

Expand Down