Merge pull request #249 from akeneo/api-test-clean-up

LevFlavien · web-flow · commit d651cc695656 · 2022-10-31T15:24:10.000+01:00
fix(): clean api unit tests
diff --git a/composer.json b/composer.json
@@ -32,7 +32,7 @@
   },
   "require-dev": {
     "friendsofphp/php-cs-fixer": "^3.5",
-    "phpunit/phpunit": "^7.0",
+    "phpunit/phpunit": "^8.0",
     "phpspec/phpspec": "^7.1",
     "symfony/yaml": "^4.2",
     "donatj/mock-webserver": "^2.0",
diff --git a/composer.lock b/composer.lock
diff --git a/tests/Api/ApiTestCase.php b/tests/Api/ApiTestCase.php
@@ -17,8 +17,7 @@
  */
 abstract class ApiTestCase extends TestCase
 {
-    /** @var MockWebServer */
-    protected $server;
+    protected MockWebServer $server;
 
     /**
      * {@inheritdoc}
@@ -44,10 +43,7 @@ protected function tearDown(): void
         $this->server->stop();
     }
 
-    /**
-     * @return AkeneoPimClientInterface
-     */
-    protected function createClientByPassword()
+    protected function createClientByPassword(): AkeneoPimClientInterface
     {
         $clientBuilder = new AkeneoPimClientBuilder($this->server->getServerRoot());
 
@@ -59,7 +55,7 @@ protected function createClientByPassword()
         );
     }
 
-    protected function createClientByToken()
+    protected function createClientByToken(): AkeneoPimClientInterface
     {
         $clientBuilder = new AkeneoPimClientBuilder($this->server->getServerRoot());
 
@@ -71,14 +67,14 @@ protected function createClientByToken()
         );
     }
 
-    protected function createClientByAppToken()
+    protected function createClientByAppToken(): AkeneoPimClientInterface
     {
         $clientBuilder = new AkeneoPimClientBuilder($this->server->getServerRoot());
 
         return $clientBuilder->buildAuthenticatedByAppToken('a_token');
     }
 
-    private function getAuthenticatedJson()
+    private function getAuthenticatedJson(): string
     {
         return <<<JSON
             {
diff --git a/tests/Api/AssetAttributeOption/UpsertAssetFamilyAttributeOptionIntegration.php b/tests/Api/AssetAttributeOption/UpsertAssetFamilyAttributeOptionIntegration.php
diff --git a/tests/Api/CreateProductMediaFileTest.php b/tests/Api/CreateProductMediaFileTest.php
@@ -35,9 +35,9 @@ public function test_create_media_file()
         $lastRequest = $this->server->getLastRequest()->jsonSerialize();
         Assert::assertSame($lastRequest[RequestInfo::JSON_KEY_POST]['product'], json_encode($productInfos));
         Assert::assertNotEmpty($lastRequest[RequestInfo::JSON_KEY_FILES]['file']);
-        Assert::assertSame($lastRequest[RequestInfo::JSON_KEY_FILES]['file']['name'], 'akeneo.png');
-        Assert::assertSame($lastRequest[RequestInfo::JSON_KEY_FILES]['file']['type'], 'image/png');
-        Assert::assertSame($lastRequest[RequestInfo::JSON_KEY_FILES]['file']['size'], 8073);
+        Assert::assertSame('akeneo.png', $lastRequest[RequestInfo::JSON_KEY_FILES]['file']['name']);
+        Assert::assertSame('image/png', $lastRequest[RequestInfo::JSON_KEY_FILES]['file']['type']);
+        Assert::assertSame(8073, $lastRequest[RequestInfo::JSON_KEY_FILES]['file']['size']);
 
         Assert::assertSame('f/b/0/6/fb068ccc9e3c5609d73c28d852812ba5faeeab28_akeneo.png', $response);
     }
diff --git a/tests/Api/CreateProductTest.php b/tests/Api/CreateProductTest.php
@@ -43,7 +43,7 @@ public function test_create_invalid_product()
         $api->create('black_sneakers', $this->newProduct());
     }
 
-    private function newProduct()
+    private function newProduct(): array
     {
         return [
             'enabled'    => false,
@@ -66,7 +66,7 @@ private function newProduct()
         ];
     }
 
-    private function expectedProduct()
+    private function expectedProduct(): array
     {
         return [
             'enabled'    => false,
diff --git a/tests/Api/DeleteProductModelTest.php b/tests/Api/DeleteProductModelTest.php
@@ -23,7 +23,7 @@ public function test_delete_product_model()
 
         $response = $api->delete('docks_white');
 
-        Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD], 'DELETE');
+        Assert::assertSame('DELETE', $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD]);
         Assert::assertSame(204, $response);
     }
 }
diff --git a/tests/Api/DeleteProductTest.php b/tests/Api/DeleteProductTest.php
@@ -23,7 +23,7 @@ public function test_create_product()
 
         $response = $api->delete('docks_white');
 
-        Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD], 'DELETE');
+        Assert::assertSame('DELETE', $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD]);
         Assert::assertSame(204, $response);
     }
 }
diff --git a/tests/Api/DownloadProductMediaFileTest.php b/tests/Api/DownloadProductMediaFileTest.php
@@ -25,7 +25,7 @@ public function test_download_media_file()
         $api = $this->createClientByPassword()->getProductMediaFileApi();
         $mediaFile = $api->download('/f/b/0/6/fb068ccc9e3c5609d73c28d852812ba5faeeab28_akeneo.png');
 
-        Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD], 'GET');
+        Assert::assertSame('GET', $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD]);
         Assert::assertInstanceOf(ResponseInterface::class, $mediaFile);
         Assert::assertSame(file_get_contents($expectedMediaFilePath), $mediaFile->getBody()->getContents());
     }
diff --git a/tests/Api/GetProductTest.php b/tests/Api/GetProductTest.php
@@ -23,7 +23,7 @@ public function test_get_product()
 
         $product = $api->get('black_sneakers');
 
-        Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD], 'GET');
+        Assert::assertSame('GET', $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD]);
         Assert::assertEquals($product, json_decode($this->getProduct(), true));
     }
 
@@ -43,7 +43,7 @@ public function test_get_unknow_product()
         $api->get('black_sneakers');
     }
 
-    private function getProduct()
+    private function getProduct(): string
     {
         return <<<JSON
             [
diff --git a/tests/Api/ListPerPageProductTest.php b/tests/Api/ListPerPageProductTest.php
@@ -24,37 +24,37 @@ public function test_list_per_page()
         $api = $this->createClientByPassword()->getProductApi();
         $firstPage = $api->listPerPage(10, true, []);
 
-        Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_GET], ['limit' => '10', 'with_count' => 'true']);
+        Assert::assertSame(['limit' => '10', 'with_count' => 'true'], $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_GET]);
 
         Assert::assertInstanceOf(PageInterface::class, $firstPage);
-        Assert::assertEquals($firstPage->getCount(), 11);
+        Assert::assertEquals(11, $firstPage->getCount());
         Assert::assertNull($firstPage->getPreviousLink());
         Assert::assertNull($firstPage->getPreviousPage());
         Assert::assertFalse($firstPage->hasPreviousPage());
         Assert::assertTrue($firstPage->hasNextPage());
         Assert::assertSame($this->server->getServerRoot() . '/api/rest/v1/products?page=2&with_count=true&pagination_type=page&limit=10', $firstPage->getNextLink());
-        Assert::assertEquals(count($firstPage->getItems()), 10);
+        Assert::assertEquals(10, count($firstPage->getItems()));
 
         $secondPage = $firstPage->getNextPage();
 
-        Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_GET], [
+        Assert::assertSame([
             'page' => '2',
             'with_count' => 'true',
             'pagination_type' => 'page',
             'limit' => '10'
-        ]);
+        ], $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_GET]);
 
         Assert::assertInstanceOf(PageInterface::class, $secondPage);
-        Assert::assertEquals($secondPage->getCount(), 11);
+        Assert::assertEquals(11, $secondPage->getCount());
         Assert::assertNull($secondPage->getNextLink());
         Assert::assertNull($secondPage->getNextPage());
         Assert::assertFalse($secondPage->hasNextPage());
         Assert::assertTrue($secondPage->hasPreviousPage());
         Assert::assertSame($this->server->getServerRoot() . '/api/rest/v1/products?page=1&with_count=true&pagination_type=page&limit=10', $secondPage->getPreviousLink());
-        Assert::assertEquals(count($secondPage->getItems()), 1);
+        Assert::assertEquals(1, count($secondPage->getItems()));
     }
 
-    private function getFirstPage()
+    private function getFirstPage(): string
     {
         $baseUri = $this->server->getServerRoot();
 
@@ -338,7 +338,7 @@ private function getFirstPage()
 JSON;
     }
 
-    private function getSecondPage()
+    private function getSecondPage(): string
     {
         $baseUri = $this->server->getServerRoot();
 
diff --git a/tests/Api/ProductDraftUuid/GetProductDraftUuidIntegration.php b/tests/Api/ProductDraftUuid/GetProductDraftUuidIntegration.php
@@ -1,9 +1,10 @@
 <?php
 
-namespace Akeneo\Pim\ApiClient\tests\Api;
+namespace Akeneo\Pim\ApiClient\tests\Api\ProductDraftUuid;
 
 use Akeneo\Pim\ApiClient\Api\ProductDraftUuidApi;
 use Akeneo\Pim\ApiClient\Client\HttpClient;
+use Akeneo\Pim\ApiClient\tests\Api\ApiTestCase;
 use donatj\MockWebServer\RequestInfo;
 use donatj\MockWebServer\Response;
 use donatj\MockWebServer\ResponseStack;
diff --git a/tests/Api/ProductUuid/CreateProductUuidIntegration.php b/tests/Api/ProductUuid/CreateProductUuidIntegration.php
@@ -1,10 +1,11 @@
 <?php
 
-namespace Akeneo\Pim\ApiClient\tests\Api;
+namespace Akeneo\Pim\ApiClient\tests\Api\ProductUuid;
 
 use Akeneo\Pim\ApiClient\Api\ProductUuidApi;
 use Akeneo\Pim\ApiClient\Client\HttpClient;
 use Akeneo\Pim\ApiClient\Exception\UnprocessableEntityHttpException;
+use Akeneo\Pim\ApiClient\tests\Api\ApiTestCase;
 use donatj\MockWebServer\RequestInfo;
 use donatj\MockWebServer\Response;
 use donatj\MockWebServer\ResponseStack;
diff --git a/tests/Api/ProductUuid/DeleteProductUuidIntegration.php b/tests/Api/ProductUuid/DeleteProductUuidIntegration.php
@@ -1,9 +1,10 @@
 <?php
 
-namespace Akeneo\Pim\ApiClient\tests\Api;
+namespace Akeneo\Pim\ApiClient\tests\Api\ProductUuid;
 
 use Akeneo\Pim\ApiClient\Api\ProductUuidApi;
 use Akeneo\Pim\ApiClient\Client\HttpClient;
+use Akeneo\Pim\ApiClient\tests\Api\ApiTestCase;
 use donatj\MockWebServer\RequestInfo;
 use donatj\MockWebServer\Response;
 use donatj\MockWebServer\ResponseStack;
diff --git a/tests/Api/ProductUuid/GetProductUuidIntegration.php b/tests/Api/ProductUuid/GetProductUuidIntegration.php
@@ -1,9 +1,10 @@
 <?php
 
-namespace Akeneo\Pim\ApiClient\tests\Api;
+namespace Akeneo\Pim\ApiClient\tests\Api\ProductUuid;
 
 use Akeneo\Pim\ApiClient\Api\ProductUuidApi;
 use Akeneo\Pim\ApiClient\Client\HttpClient;
+use Akeneo\Pim\ApiClient\tests\Api\ApiTestCase;
 use donatj\MockWebServer\RequestInfo;
 use donatj\MockWebServer\Response;
 use donatj\MockWebServer\ResponseStack;
diff --git a/tests/Api/ProductUuid/ListPerPageProductUuidIntegration.php b/tests/Api/ProductUuid/ListPerPageProductUuidIntegration.php
@@ -1,10 +1,12 @@
 <?php
 
-namespace Akeneo\Pim\ApiClient\tests\Api;
+namespace Akeneo\Pim\ApiClient\tests\Api\ProductUuid;
+
 
 use Akeneo\Pim\ApiClient\Api\ProductUuidApi;
 use Akeneo\Pim\ApiClient\Client\HttpClient;
 use Akeneo\Pim\ApiClient\Pagination\PageInterface;
+use Akeneo\Pim\ApiClient\tests\Api\ApiTestCase;
 use donatj\MockWebServer\RequestInfo;
 use donatj\MockWebServer\Response;
 use donatj\MockWebServer\ResponseStack;
diff --git a/tests/Api/ProductUuid/UpsertListProductUuidIntegration.php b/tests/Api/ProductUuid/UpsertListProductUuidIntegration.php
@@ -1,9 +1,10 @@
 <?php
 
-namespace Akeneo\Pim\ApiClient\tests\Api;
+namespace Akeneo\Pim\ApiClient\tests\Api\ProductUuid;
 
 use Akeneo\Pim\ApiClient\Api\ProductUuidApi;
 use Akeneo\Pim\ApiClient\Client\HttpClient;
+use Akeneo\Pim\ApiClient\tests\Api\ApiTestCase;
 use donatj\MockWebServer\RequestInfo;
 use donatj\MockWebServer\Response;
 use donatj\MockWebServer\ResponseStack;
diff --git a/tests/Api/ProductUuid/UpsertProductUuidIntegration.php b/tests/Api/ProductUuid/UpsertProductUuidIntegration.php
@@ -1,9 +1,10 @@
 <?php
 
-namespace Akeneo\Pim\ApiClient\tests\Api;
+namespace Akeneo\Pim\ApiClient\tests\Api\ProductUuid;
 
 use Akeneo\Pim\ApiClient\Api\ProductUuidApi;
 use Akeneo\Pim\ApiClient\Client\HttpClient;
+use Akeneo\Pim\ApiClient\tests\Api\ApiTestCase;
 use donatj\MockWebServer\RequestInfo;
 use donatj\MockWebServer\Response;
 use donatj\MockWebServer\ResponseStack;
diff --git a/tests/Api/ReferenceEntity/GetReferenceEntityIntegration.php b/tests/Api/ReferenceEntity/GetReferenceEntityIntegration.php
@@ -25,7 +25,7 @@ public function test_get_reference_entity()
         $api = $this->createClientByPassword()->getReferenceEntityApi();
         $product = $api->get('brand');
 
-        Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD], 'GET');
+        Assert::assertSame('GET', $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD]);
         Assert::assertEquals($product, json_decode($this->getBrand(), true));
     }
 
diff --git a/tests/Api/ReferenceEntity/ListAllReferenceEntitiesIntegration.php b/tests/Api/ReferenceEntity/ListAllReferenceEntitiesIntegration.php
@@ -15,7 +15,7 @@ class ListAllReferenceEntitiesIntegration extends ApiTestCase
     public function test_list_per_page()
     {
         $this->server->setResponseOfPath(
-            '/'. sprintf(ReferenceEntityApi::REFERENCE_ENTITIES_URI),
+            '/'. ReferenceEntityApi::REFERENCE_ENTITIES_URI,
             new ResponseStack(
                 new Response($this->getFirstPage(), [], 200),
                 new Response($this->getSecondPage(), [], 200)
diff --git a/tests/Api/ReferenceEntityMediaFile/CreateReferenceEntityMediaFileIntegration.php b/tests/Api/ReferenceEntityMediaFile/CreateReferenceEntityMediaFileIntegration.php
@@ -30,16 +30,16 @@ public function test_create_media_file()
 
         Assert::assertNotEmpty($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_FILES]['file']);
         Assert::assertSame(
-            $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_FILES]['file']['name'],
-            'unicorn.png'
+            'unicorn.png',
+            $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_FILES]['file']['name']
         );
         Assert::assertSame(
-            $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_FILES]['file']['type'],
-            'image/png'
+            'image/png',
+            $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_FILES]['file']['type']
         );
         Assert::assertSame(
-            $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_FILES]['file']['size'],
-            11255
+            11255,
+            $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_FILES]['file']['size']
         );
         Assert::assertSame('my-media-code', $response);
     }
diff --git a/tests/Api/ReferenceEntityRecord/GetReferenceEntityRecordIntegration.php b/tests/Api/ReferenceEntityRecord/GetReferenceEntityRecordIntegration.php
@@ -25,16 +25,14 @@ public function test_get_reference_entity_record()
         $api = $this->createClientByPassword()->getReferenceEntityRecordApi();
         $product = $api->get('designer', 'starck');
 
-        Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD], 'GET');
+        Assert::assertSame('GET', $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD]);
         Assert::assertEquals($product, json_decode($this->getStarckRecord(), true));
     }
 
-    /**
-     * @expectedException \Akeneo\Pim\ApiClient\Exception\NotFoundHttpException
-     * @expectedExceptionMessage Record "foo" does not exist for the reference entity "designer".
-     */
     public function test_get_unknow_product()
     {
+        $this->expectExceptionMessage("Record \"foo\" does not exist for the reference entity \"designer\".");
+        $this->expectException(\Akeneo\Pim\ApiClient\Exception\NotFoundHttpException::class);
         $this->server->setResponseOfPath(
             '/'. sprintf(ReferenceEntityRecordApi::REFERENCE_ENTITY_RECORD_URI, 'designer', 'foo'),
             new ResponseStack(
diff --git a/tests/Api/UpsertListProductTest.php b/tests/Api/UpsertListProductTest.php
@@ -77,14 +77,16 @@ public function test_upsert_list_from_stream()
         ], $responseLines[2]);
     }
 
-    private function getProductToUpsertJson(){
+    private function getProductToUpsertJson(): string
+    {
         return <<<JSON
 {"identifier":"docks_black","enabled":false,"values":{"name":[{"locale":"en_US","scope":null,"data":"Black Docks"}]}}
 {"identifier":"pumps","enabled":false,"family":"sandals","categories":["summer_collection"],"values":{"name":[{"data":"The pumps","locale":"en_US","scope":null},{"data":"Les pumps","locale":"fr_FR","scope":null}]}}
 JSON;
     }
 
-    private function getProductToUpsert(){
+    private function getProductToUpsert(): array
+    {
         return [
             [
                 'identifier' => 'docks_black',
@@ -122,7 +124,7 @@ private function getProductToUpsert(){
         ];
     }
 
-    private function getResults()
+    private function getResults(): string
     {
         return <<<JSON
         {"line": 1,"identifier": "docks_black","status_code": 204}
diff --git a/tests/Cache/AkeneoPimClientBuilderTest.php b/tests/Cache/AkeneoPimClientBuilderTest.php
@@ -19,7 +19,7 @@ public function test_get_product_with_create_client_by_password()
 
         $product = $api->get('black_sneakers');
 
-        Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD], 'GET');
+        Assert::assertSame('GET', $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD]);
         Assert::assertEquals($product, json_decode($this->getProduct(), true));
     }
 
@@ -30,7 +30,7 @@ public function test_get_product_with_create_client_by_token()
 
         $product = $api->get('black_sneakers');
 
-        Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD], 'GET');
+        Assert::assertSame('GET', $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD]);
         Assert::assertEquals($product, json_decode($this->getProduct(), true));
     }
 
@@ -41,7 +41,7 @@ public function test_get_product_with_create_client_by_app_token()
 
         $product = $api->get('black_sneakers');
 
-        Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD], 'GET');
+        Assert::assertSame('GET', $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD]);
         Assert::assertEquals($product, json_decode($this->getProduct(), true));
     }
 
@@ -55,7 +55,7 @@ private function setGetProductResponse(): void
         );
     }
 
-    private function getProduct()
+    private function getProduct(): string
     {
         return <<<JSON
             [

Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,7 @@`
`17`	`17`	`*/`
`18`	`18`	`abstract class ApiTestCase extends TestCase`
`19`	`19`	`{`
`20`		`- /** @var MockWebServer */`
`21`		`- protected $server;`
	`20`	`+ protected MockWebServer $server;`
`22`	`21`
`23`	`22`	`/**`
`24`	`23`	`* {@inheritdoc}`
`@@ -44,10 +43,7 @@ protected function tearDown(): void`
`44`	`43`	`$this->server->stop();`
`45`	`44`	`}`
`46`	`45`
`47`		`- /**`
`48`		`- * @return AkeneoPimClientInterface`
`49`		`- */`
`50`		`- protected function createClientByPassword()`
	`46`	`+ protected function createClientByPassword(): AkeneoPimClientInterface`
`51`	`47`	`{`
`52`	`48`	`$clientBuilder = new AkeneoPimClientBuilder($this->server->getServerRoot());`
`53`	`49`
`@@ -59,7 +55,7 @@ protected function createClientByPassword()`
`59`	`55`	`);`
`60`	`56`	`}`
`61`	`57`
`62`		`- protected function createClientByToken()`
	`58`	`+ protected function createClientByToken(): AkeneoPimClientInterface`
`63`	`59`	`{`
`64`	`60`	`$clientBuilder = new AkeneoPimClientBuilder($this->server->getServerRoot());`
`65`	`61`
`@@ -71,14 +67,14 @@ protected function createClientByToken()`
`71`	`67`	`);`
`72`	`68`	`}`
`73`	`69`
`74`		`- protected function createClientByAppToken()`
	`70`	`+ protected function createClientByAppToken(): AkeneoPimClientInterface`
`75`	`71`	`{`
`76`	`72`	`$clientBuilder = new AkeneoPimClientBuilder($this->server->getServerRoot());`
`77`	`73`
`78`	`74`	`return $clientBuilder->buildAuthenticatedByAppToken('a_token');`
`79`	`75`	`}`
`80`	`76`
`81`		`- private function getAuthenticatedJson()`
	`77`	`+ private function getAuthenticatedJson(): string`
`82`	`78`	`{`
`83`	`79`	`return <<<JSON`
`84`	`80`	`{`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public function test_create_invalid_product()`
`43`	`43`	`$api->create('black_sneakers', $this->newProduct());`
`44`	`44`	`}`
`45`	`45`
`46`		`- private function newProduct()`
	`46`	`+ private function newProduct(): array`
`47`	`47`	`{`
`48`	`48`	`return [`
`49`	`49`	`'enabled' => false,`
`@@ -66,7 +66,7 @@ private function newProduct()`
`66`	`66`	`];`
`67`	`67`	`}`
`68`	`68`
`69`		`- private function expectedProduct()`
	`69`	`+ private function expectedProduct(): array`
`70`	`70`	`{`
`71`	`71`	`return [`
`72`	`72`	`'enabled' => false,`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ public function test_delete_product_model()`
`23`	`23`
`24`	`24`	`$response = $api->delete('docks_white');`
`25`	`25`
`26`		`- Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD], 'DELETE');`
	`26`	`+ Assert::assertSame('DELETE', $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD]);`
`27`	`27`	`Assert::assertSame(204, $response);`
`28`	`28`	`}`
`29`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ public function test_download_media_file()`
`25`	`25`	`$api = $this->createClientByPassword()->getProductMediaFileApi();`
`26`	`26`	`$mediaFile = $api->download('/f/b/0/6/fb068ccc9e3c5609d73c28d852812ba5faeeab28_akeneo.png');`
`27`	`27`
`28`		`- Assert::assertSame($this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD], 'GET');`
	`28`	`+ Assert::assertSame('GET', $this->server->getLastRequest()->jsonSerialize()[RequestInfo::JSON_KEY_METHOD]);`
`29`	`29`	`Assert::assertInstanceOf(ResponseInterface::class, $mediaFile);`
`30`	`30`	`Assert::assertSame(file_get_contents($expectedMediaFilePath), $mediaFile->getBody()->getContents());`
`31`	`31`	`}`