DX-104 : Remainder of last rollback

Author: gwendalaubert

src/Api/AssetManager/AssetAttributeOptionApi.php

@@ -51,7 +51,7 @@ public function upsert(string $assetFamilyCode, string $attributeCode, string $a
         );
     }
 
-    public function upsertAsync(string $assetFamilyCode, string $attributeCode, string $attributeOptionCode, array $data = [], ?callable $onSuccess = null, ?callable $onFail = null): PromiseInterface
+    public function upsertAsync(string $assetFamilyCode, string $attributeCode, string $attributeOptionCode, array $data = []): PromiseInterface
     {
         return $this->resourceClient->upsertAsyncResource(
             static::ASSET_ATTRIBUTE_OPTION_URI,

src/Api/FamilyVariantApi.php

@@ -106,7 +106,7 @@ public function upsertList($familyCode, $familyVariants): \Traversable
     /**
      * {@inheritdoc}
      */
-    public function upsertAsync($familyCode, $familyVariantCode, array $data = [], ?callable $onSuccess = null, ?callable $onFail = null): PromiseInterface
+    public function upsertAsync($familyCode, $familyVariantCode, array $data = []): PromiseInterface
     {
         if (array_key_exists('family', $data)) {
             throw new InvalidArgumentException('The parameter "family" must not be defined in the data parameter');

src/Api/ProductModelApi.php

@@ -116,7 +116,7 @@ public function delete(string $code): int
         return $this->resourceClient->deleteResource(static::PRODUCT_MODEL_URI, [$code]);
     }
 
-    public function upsertAsync(string $code, array $data = [], ?callable $onSuccess = null, ?callable $onFail = null): PromiseInterface
+    public function upsertAsync(string $code, array $data = []): PromiseInterface
     {
         if (array_key_exists('code', $data)) {
             throw new InvalidArgumentException('The parameter "code" must not be defined in the data parameter');

src/Api/ReferenceEntityAttributeOptionApi.php

@@ -59,7 +59,7 @@ public function upsert(string $referenceEntityCode, string $attributeCode, strin
     /**
      * {@inheritdoc}
      */
-    public function upsertAsync(string $referenceEntityCode, string $attributeCode, string $attributeOptionCode, array $data = [], ?callable $onSuccess = null, ?callable $onFail = null): PromiseInterface
+    public function upsertAsync(string $referenceEntityCode, string $attributeCode, string $attributeOptionCode, array $data = []): PromiseInterface
     {
         return $this->resourceClient->upsertAsyncResource(
             static::REFERENCE_ENTITY_ATTRIBUTE_OPTION_URI,

src/Client/HttpClient.php

@@ -85,6 +85,6 @@ public function sendAsync(
     {
         $request = $this->prepareRequest($httpMethod, $uri, $headers, $body);
 
-        return $this->httpClient->sendAsyncRequest($request)->then($onSuccess, $onFail);
+        return $this->httpClient->sendAsyncRequest($request);
     }
 }

src/Client/HttpClientInterface.php

@@ -38,8 +38,6 @@ public function sendRequest(string $httpMethod, $uri, array $headers = [], $body
      * @param string|UriInterface         $uri        URI of the request
      * @param array                       $headers    headers of the request
      * @param string|StreamInterface|null $body       body of the request
-     * @param ?callable                   $onSuccess  Callback in case of success
-     * @param ?callable                   $onFail     Callback in case of fail
      *
      * @throws HttpException If the request failed.
      *

src/Client/ResourceClientInterface.php

@@ -116,12 +116,10 @@ public function upsertResource(string $uri, array $uriParameters = [], array $bo
      * @param string $uri           URI of the resource
      * @param array  $uriParameters URI parameters of the resource
      * @param array  $body          Body of the request
-     * @param ?callable $onSuccess   Callback in case of success
-     * @param ?callable $onFail      Callback in case of fail
      *
      * @throws HttpException If the request failed.
      *
-     * @return Promise
+     * @return PromiseInterface
      */
     public function upsertAsyncResource(
         string $uri,
@@ -146,8 +144,6 @@ public function upsertAndReturnResource(string $uri, array $uriParameters = [],
      * @param string $uri           URI of the resource
      * @param array  $uriParameters URI parameters of the resource
      * @param array  $body          Body of the request
-     * @param ?callable $onSuccess   Callback in case of success
-     * @param ?callable $onFail      Callback in case of fail
      *
      * @throws HttpException If the request failed.
      *
@@ -179,13 +175,11 @@ public function upsertStreamResourceList(string $uri, array $uriParameters = [],
      * @param array                 $uriParameters URI parameters of the resource
      * @param array|StreamInterface $resources     array of resources to create or update.
      *                                             You can pass your own StreamInterface implementation as well.
-     * @param ?callable $onSuccess   Callback in case of success
-     * @param ?callable $onFail      Callback in case of fail
      *
      * @throws HttpException            If the request failed.
      * @throws InvalidArgumentException If the resources or any part thereof are invalid.
      *
-     * @return Promise returns a Promise
+     * @return PromiseInterface returns a Promise
      */
     public function upsertAsyncStreamResourceList(
         string $uri,
@@ -212,13 +206,11 @@ public function upsertJsonResourceList(string $uri, array $uriParameters = [], a
      * @param string $uri           URI of the resource
      * @param array  $uriParameters URI parameters of the resource
      * @param array  $resources     array of resources to create or update.
-     * @param ?callable $onSuccess   Callback in case of success
-     * @param ?callable $onFail      Callback in case of fail
      *
      * @throws HttpException            If the request failed.
      * @throws InvalidArgumentException If the resources or any part thereof are invalid.
      *
-     * @return Promise
+     * @return PromiseInterface
      */
     public function upsertAsyncJsonResourceList(
         string $uri,