Skip to content

Commit 93049d5

Browse files
LeoltronLeoltron
authored
Use "async Task" instead of "async void" (#38)
1 parent 7b484f6 commit 93049d5

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

76 files changed

+482
-434
lines changed

‎async-enumerable-dotnet-test/AllTest.cs‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,47 +12,47 @@ namespace async_enumerable_dotnet_test
1212
public class AllTest
1313
{
1414
[Fact]
15-
public async void Sync_None()
15+
public async Task Sync_None()
1616
{
1717
await AsyncEnumerable.Range(1, 5)
1818
.All(v => v > 6)
1919
.AssertResult(false);
2020
}
2121

2222
[Fact]
23-
public async void Sync_Empty()
23+
public async Task Sync_Empty()
2424
{
2525
await AsyncEnumerable.Empty<int>()
2626
.All(v => v > 6)
2727
.AssertResult(true);
2828
}
2929

3030
[Fact]
31-
public async void Sync_Match()
31+
public async Task Sync_Match()
3232
{
3333
await AsyncEnumerable.Range(1, 5)
3434
.All(v => v > 0)
3535
.AssertResult(true);
3636
}
3737

3838
[Fact]
39-
public async void Sync_Error()
39+
public async Task Sync_Error()
4040
{
4141
await AsyncEnumerable.Error<int>(new InvalidOperationException())
4242
.All(v => v > 6)
4343
.AssertFailure(typeof(InvalidOperationException));
4444
}
4545

4646
[Fact]
47-
public async void Sync_Crash()
47+
public async Task Sync_Crash()
4848
{
4949
await AsyncEnumerable.Range(1, 5)
5050
.All((Func<int, bool>)(v => throw new InvalidOperationException()))
5151
.AssertFailure(typeof(InvalidOperationException));
5252
}
5353

5454
[Fact]
55-
public async void Async_None()
55+
public async Task Async_None()
5656
{
5757
await AsyncEnumerable.Range(1, 5)
5858
.All(async v =>
@@ -64,7 +64,7 @@ await AsyncEnumerable.Range(1, 5)
6464
}
6565

6666
[Fact]
67-
public async void Async_Empty()
67+
public async Task Async_Empty()
6868
{
6969
await AsyncEnumerable.Empty<int>()
7070
.All(async v =>
@@ -76,7 +76,7 @@ await AsyncEnumerable.Empty<int>()
7676
}
7777

7878
[Fact]
79-
public async void Async_Match()
79+
public async Task Async_Match()
8080
{
8181
await AsyncEnumerable.Range(1, 5)
8282
.All(async v =>
@@ -88,7 +88,7 @@ await AsyncEnumerable.Range(1, 5)
8888
}
8989

9090
[Fact]
91-
public async void Async_Error()
91+
public async Task Async_Error()
9292
{
9393
await AsyncEnumerable.Error<int>(new InvalidOperationException())
9494
.All(async v =>
@@ -100,7 +100,7 @@ await AsyncEnumerable.Error<int>(new InvalidOperationException())
100100
}
101101

102102
[Fact]
103-
public async void Async_Crash()
103+
public async Task Async_Crash()
104104
{
105105
await AsyncEnumerable.Range(1, 5)
106106
.All(async v =>

‎async-enumerable-dotnet-test/AmbTest.cs‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,17 @@
33
// See LICENSE file in the project root for full license information.
44

55
using System;
6-
using System.Runtime.CompilerServices;
76
using Xunit;
87
using async_enumerable_dotnet;
98
using System.Threading;
9+
using System.Threading.Tasks;
1010

1111
namespace async_enumerable_dotnet_test
1212
{
1313
public class AmbTest
1414
{
1515
[Fact]
16-
public async void First_Win()
16+
public async Task First_Win()
1717
{
1818
await AsyncEnumerable.Amb(
1919
AsyncEnumerable.Interval(1, 5, TimeSpan.FromMilliseconds(100)),
@@ -23,7 +23,7 @@ await AsyncEnumerable.Amb(
2323
}
2424

2525
[Fact]
26-
public async void First_Win_Error()
26+
public async Task First_Win_Error()
2727
{
2828
await AsyncEnumerable.Amb(
2929
AsyncEnumerable.Error<long>(new InvalidOperationException()),
@@ -33,7 +33,7 @@ await AsyncEnumerable.Amb(
3333
}
3434

3535
[Fact]
36-
public async void First_Win_Empty()
36+
public async Task First_Win_Empty()
3737
{
3838
await AsyncEnumerable.Amb(
3939
AsyncEnumerable.Empty<long>(),
@@ -43,7 +43,7 @@ await AsyncEnumerable.Amb(
4343
}
4444

4545
[Fact]
46-
public async void Second_Win()
46+
public async Task Second_Win()
4747
{
4848
await AsyncEnumerable.Amb(
4949
AsyncEnumerable.Interval(1, 5, TimeSpan.FromMilliseconds(200)),
@@ -53,7 +53,7 @@ await AsyncEnumerable.Amb(
5353
}
5454

5555
[Fact]
56-
public async void Second_Win_Error()
56+
public async Task Second_Win_Error()
5757
{
5858
await AsyncEnumerable.Amb(
5959
AsyncEnumerable.Interval(1, 5, TimeSpan.FromMilliseconds(200)),
@@ -63,7 +63,7 @@ await AsyncEnumerable.Amb(
6363
}
6464

6565
[Fact]
66-
public async void Second_Win_Empty()
66+
public async Task Second_Win_Empty()
6767
{
6868
await AsyncEnumerable.Amb(
6969
AsyncEnumerable.Interval(11, 5, TimeSpan.FromMilliseconds(100)),
@@ -73,7 +73,7 @@ await AsyncEnumerable.Amb(
7373
}
7474

7575
[Fact]
76-
public async void Any_Win()
76+
public async Task Any_Win()
7777
{
7878
var disposed = 0;
7979
await AsyncEnumerable.Amb(
@@ -86,7 +86,7 @@ await AsyncEnumerable.Amb(
8686
}
8787

8888
[Fact]
89-
public async void First_Win_Sync()
89+
public async Task First_Win_Sync()
9090
{
9191
var ttr = new TestTaskRunner();
9292

@@ -124,7 +124,7 @@ public async void First_Win_Sync()
124124
}
125125

126126
[Fact]
127-
public async void Second_Win_Sync()
127+
public async Task Second_Win_Sync()
128128
{
129129
var ttr = new TestTaskRunner();
130130

‎async-enumerable-dotnet-test/AnyTest.cs‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,47 +12,47 @@ namespace async_enumerable_dotnet_test
1212
public class AnyTest
1313
{
1414
[Fact]
15-
public async void Sync_None()
15+
public async Task Sync_None()
1616
{
1717
await AsyncEnumerable.Range(1, 5)
1818
.Any(v => v > 6)
1919
.AssertResult(false);
2020
}
2121

2222
[Fact]
23-
public async void Sync_Empty()
23+
public async Task Sync_Empty()
2424
{
2525
await AsyncEnumerable.Empty<int>()
2626
.Any(v => v > 6)
2727
.AssertResult(false);
2828
}
2929

3030
[Fact]
31-
public async void Sync_Match()
31+
public async Task Sync_Match()
3232
{
3333
await AsyncEnumerable.Range(1, 5)
3434
.Any(v => v > 4)
3535
.AssertResult(true);
3636
}
3737

3838
[Fact]
39-
public async void Sync_Error()
39+
public async Task Sync_Error()
4040
{
4141
await AsyncEnumerable.Error<int>(new InvalidOperationException())
4242
.Any(v => v > 6)
4343
.AssertFailure(typeof(InvalidOperationException));
4444
}
4545

4646
[Fact]
47-
public async void Sync_Crash()
47+
public async Task Sync_Crash()
4848
{
4949
await AsyncEnumerable.Range(1, 5)
5050
.Any((Func<int, bool>)(v => throw new InvalidOperationException()))
5151
.AssertFailure(typeof(InvalidOperationException));
5252
}
5353

5454
[Fact]
55-
public async void Async_None()
55+
public async Task Async_None()
5656
{
5757
await AsyncEnumerable.Range(1, 5)
5858
.Any(async v =>
@@ -64,7 +64,7 @@ await AsyncEnumerable.Range(1, 5)
6464
}
6565

6666
[Fact]
67-
public async void Async_Empty()
67+
public async Task Async_Empty()
6868
{
6969
await AsyncEnumerable.Empty<int>()
7070
.Any(async v =>
@@ -76,7 +76,7 @@ await AsyncEnumerable.Empty<int>()
7676
}
7777

7878
[Fact]
79-
public async void Async_Match()
79+
public async Task Async_Match()
8080
{
8181
await AsyncEnumerable.Range(1, 5)
8282
.Any(async v =>
@@ -88,7 +88,7 @@ await AsyncEnumerable.Range(1, 5)
8888
}
8989

9090
[Fact]
91-
public async void Async_Error()
91+
public async Task Async_Error()
9292
{
9393
await AsyncEnumerable.Error<int>(new InvalidOperationException())
9494
.Any(async v =>
@@ -100,7 +100,7 @@ await AsyncEnumerable.Error<int>(new InvalidOperationException())
100100
}
101101

102102
[Fact]
103-
public async void Async_Crash()
103+
public async Task Async_Crash()
104104
{
105105
await AsyncEnumerable.Range(1, 5)
106106
.Any(async v =>

‎async-enumerable-dotnet-test/BufferBoundaryTest.cs‎

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,14 @@
66
using async_enumerable_dotnet;
77
using System;
88
using System.Collections.Generic;
9+
using System.Threading.Tasks;
910

1011
namespace async_enumerable_dotnet_test
1112
{
1213
public class BufferBoundaryTest
1314
{
1415
[Fact]
15-
public async void Size()
16+
public async Task Size()
1617
{
1718
await AsyncEnumerable.Range(1, 5)
1819
.Buffer(AsyncEnumerable.Timer(TimeSpan.FromMilliseconds(200)), 2)
@@ -24,7 +25,7 @@ await AsyncEnumerable.Range(1, 5)
2425
}
2526

2627
[Fact]
27-
public async void Size_Collection()
28+
public async Task Size_Collection()
2829
{
2930
await AsyncEnumerable.Range(1, 5)
3031
.Buffer(AsyncEnumerable.Timer(TimeSpan.FromMilliseconds(200)), () => new HashSet<int>(), 2)
@@ -36,7 +37,7 @@ await AsyncEnumerable.Range(1, 5)
3637
}
3738

3839
[Fact]
39-
public async void Time()
40+
public async Task Time()
4041
{
4142
var t = 100L;
4243
if (Environment.GetEnvironmentVariable("CI") != null)
@@ -61,39 +62,39 @@ public async void Time()
6162
}
6263

6364
[Fact]
64-
public async void Error_Main()
65+
public async Task Error_Main()
6566
{
6667
await AsyncEnumerable.Error<int>(new InvalidOperationException())
6768
.Buffer(AsyncEnumerable.Timer(TimeSpan.FromMilliseconds(200)), 2)
6869
.AssertFailure(typeof(InvalidOperationException));
6970
}
7071

7172
[Fact]
72-
public async void Error_Other()
73+
public async Task Error_Other()
7374
{
7475
await AsyncEnumerable.Timer(TimeSpan.FromMilliseconds(200))
7576
.Buffer(AsyncEnumerable.Error<int>(new InvalidOperationException()), 2)
7677
.AssertFailure(typeof(InvalidOperationException));
7778
}
7879

7980
[Fact]
80-
public async void Empty_Main()
81+
public async Task Empty_Main()
8182
{
8283
await AsyncEnumerable.Empty<int>()
8384
.Buffer(AsyncEnumerable.Timer(TimeSpan.FromMilliseconds(200)), 2)
8485
.AssertResult();
8586
}
8687

8788
[Fact]
88-
public async void Empty_Other()
89+
public async Task Empty_Other()
8990
{
9091
await AsyncEnumerable.Timer(TimeSpan.FromMilliseconds(200))
9192
.Buffer(AsyncEnumerable.Empty<int>(), 2)
9293
.AssertResult();
9394
}
9495

9596
[Fact]
96-
public async void Time_And_Size()
97+
public async Task Time_And_Size()
9798
{
9899
var t = 100L;
99100
if (Environment.GetEnvironmentVariable("CI") != null)

0 commit comments

Comments
 (0)