OCaml 5.2.0 and newer support, including OCaml 5.3.0

[zhelih]

Hi,

This Pull Request provides changes required to use this project with OCaml 5.2.0 and newer up to OCaml 5.3.0.

It includes ideas and changes from other PRs: #199 #207 and addresses issue #202

The reason why versions before 5.2.0 not support is due to changes in AST and function handling.
Please review and let me know if there are any questions or comments.

Thanks!

[ygrek]

ftr integration tests are known to fail, to be fixed, but the kernel actually works, including new OCaml 5 features (effects, domains)

[zhelih]

ftr integration tests are known to fail, to be fixed, but the kernel actually works, including new OCaml 5 features (effects, domains)

From my side, integration test notebooks work correctly when running from the Jupyter Lab (web). I do not have the proper command line setup (yet) to finish that testing. However, for the Web users there should be no problem (including ppx).

I will report when I have more on this.

[akabe]

@zhelih
Very sorry for late.

Could you restrict ocaml-versions in ci.yaml and other yaml files to 5.2.0 only?
https://github.com/akabe/ocaml-jupyter/blob/master/.github/workflows/ci.yaml#L17-L22
https://github.com/akabe/ocaml-jupyter/blob/master/.github/workflows/gh-pages.yaml#L20
https://github.com/akabe/ocaml-jupyter/blob/master/.github/workflows/release.yaml#L13

It seems your patch includes code supporting v4.x.x. I think they can be removed.

@ygrek Thank you for reply!

[zhelih]

There is a plan to remove obsolete code in a separate PR, unless you would recommend otherwise.

[akabe]

@zhelih

Thank you for the restriction of ocaml versions.

The CI is failing due to Python 2 installation, but I don’t think we need to support it. It would be helpful if you could remove the following entry. Sorry again for the trouble.

• ocaml-jupyter/.github/workflows/ci.yaml

  Line 38 in ed45f5f

  sudo apt-get install -y bash zsh python2 python3 ruby

• ocaml-jupyter/tests/notebook/test_process.ml

  Lines 90 to 94 in ed45f5f

  	let test__python2 ctxt =
  	let res = python2 ~capture_stdout:true "print 'ok'" in
  	assert_equal ~ctxt ~printer:[%show: process_status] (Unix.WEXITED 0) res.exit_status ;
  	assert_equal ~ctxt ~printer:[%show: string option] (Some "ok\n") res.stdout ;
  	assert_equal ~ctxt ~printer:[%show: string option] None res.stderr

• ocaml-jupyter/tests/notebook/test_process.ml

  Line 180 in ed45f5f

  "python2" >:: test__python2;

• ocaml-jupyter/tests/integration/jupyter-notebook.ipynb

  Lines 41 to 49 in ed45f5f

  	{
  	"cell_type": "code",
  	"execution_count": null,
  	"metadata": {},
  	"outputs": [],
  	"source": [
  	"Jupyter_notebook.Process.python2 {|print \"ok\"|}"
  	]
  	},

There is a plan to remove obsolete code in a separate PR, unless you would recommend otherwise.

Sounds good to me. I will release a new version of ocaml-jupyter after the separate PR.

[zhelih]

I see format fails, correcting.

[zhelih]

Enhanced ppx test (and all of them) to be stable.

[zhelih]

All tests pass now.

[akabe]

Hi @zhelih,

Thank you so much for completing this incredibly challenging upgrade — I really appreciate your dedication and the high quality of your work.
All the tests are passing perfectly, which is truly impressive. Excellent job! 🎉

When you have time, could you please also update the OCaml version in the following workflow files?

• https://github.com/akabe/ocaml-jupyter/blob/master/.github/workflows/gh-pages.yaml#L20
• https://github.com/akabe/ocaml-jupyter/blob/master/.github/workflows/release.yaml#L13

The gh-pages.yaml workflow automatically builds and updates the API documentation at
https://akabe.github.io/ocaml-jupyter/ .

The release.yaml workflow creates a tarball for OPAM release and generates a draft GitHub release when a new tag is pushed.

Thanks again for your great work and for keeping the project in such good shape!