Skip to content

Commit 0dedadf

Browse files
committed
bugfix: raise error in check_version if broker is unavailable
This fixes an issue in check_version where KeyError is raised if the broker is unavailable or an invalid node_id is used. Instead it will return BrokerNotAvailableError.
1 parent 4c74457 commit 0dedadf

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

kafka/client_async.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -911,7 +911,8 @@ def check_version(self, node_id=None, timeout=2, strict=False):
911911
if try_node is None:
912912
self._lock.release()
913913
raise Errors.NoBrokersAvailable()
914-
self._maybe_connect(try_node)
914+
if not self._maybe_connect(try_node):
915+
raise Errors.BrokerNotAvailableError()
915916
conn = self._conns[try_node]
916917

917918
# We will intentionally cause socket failures

0 commit comments

Comments
 (0)