Fix macOS menu bar not working when starting application in background

Author: airsquared

src/main/java/com/airsquared/blobsaver/Background.java

@@ -79,7 +79,9 @@ static void startBackground(boolean runOnlyOnce) {
             return;
         }
         if (!runOnlyOnce && Platform.isFxApplicationThread()) {
-            Main.hideStage();
+            if (Main.primaryStage.isShowing()) {
+                Main.hideStage();
+            }
             Notification.Notifier.INSTANCE.setPopupLifetime(Duration.seconds(30));
             Notification.Notifier.INSTANCE.notifyInfo("Background process has started", "Check your system tray/status bar for\nthe icon."
                     + presetsToSaveNames.toString().substring(1, presetsToSaveNames.toString().length() - 1));

src/main/java/com/airsquared/blobsaver/Controller.java

@@ -464,7 +464,9 @@ public void savePresetHandler() {
     public void checkBlobs() { openURL("https://tsssaver.1conan.com/check.php"); }
 
     public void helpLabelHandler(MouseEvent evt) {
-        if (Main.SHOW_BREAKPOINT) return; // remember to put a breakpoint here
+        if (Main.SHOW_BREAKPOINT) {
+            return; // remember to put a breakpoint here
+        }
 
         String labelID;
         // if user clicks on question mark instead of padding, evt.getTarget() returns LabeledText instead of Label

src/main/java/com/airsquared/blobsaver/Main.java

@@ -112,10 +112,16 @@ public void start(Stage primaryStage) throws IOException {
             primaryStage.setResizable(false);
             Controller.afterStageShowing();
             Platform.setImplicitExit(false);
+            showStage();
             if (appPrefs.getBoolean("Start background immediately", false)) {
-                Background.startBackground(false);
-            } else {
-                showStage();
+                /* I have to show the stage then hide it again in Platform.runLater() otherwise
+                 * the needed initialization code won't run at the right time when starting the background
+                 * (for example, the macOS menu bar won't work properly if I don't do this)
+                 */
+                Platform.runLater(() -> {
+                    hideStage();
+                    Background.startBackground(false);
+                });
             }
 
             //if in background, hide; else quit