Skip to content

Commit 28d1aba

Browse files
committed
fix: add fixes
1 parent b0e6c26 commit 28d1aba

File tree

7 files changed

+129
-56
lines changed

7 files changed

+129
-56
lines changed

example/package.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,16 @@
2121
"@types/react-dom": "17.0.11",
2222
"@types/react-router": "5.1.18",
2323
"@types/react-router-dom": "5.3.3",
24+
"@typescript-eslint/parser": "^5.10.2",
2425
"babel-jest": "^27.4.6",
2526
"ionic-react-header-parallax": "https://github.com/ahmnouira/ionic-react-header-parallax",
2627
"ionicons": "6.0.1",
2728
"react": "17.0.2",
2829
"react-dom": "17.0.2",
29-
"react-router": "^6.2.1",
30-
"react-router-dom": "6.2.1",
30+
"react-router": "^5",
31+
"react-router-dom": "^5",
3132
"react-scripts": "5.0.0",
32-
"typescript": "4.5.5",
33+
"typescript": "^4.3.5",
3334
"web-vitals": "2.1.4",
3435
"workbox-background-sync": "6.4.2",
3536
"workbox-broadcast-update": "6.4.2",
@@ -52,7 +53,7 @@
5253
"update": "ionic cap copy && ionic cap sync",
5354
"start": "react-scripts start",
5455
"build": "react-scripts build",
55-
"test": "react-scripts test",
56+
"test": "react-scripts test --transformIgnorePatterns 'node_modules/(?!(@ionic/react|@ionic/react-router|@ionic/core|@stencil/core|ionicons)/)'",
5657
"eject": "react-scripts eject"
5758
},
5859
"eslintConfig": {

example/src/components/Lorem.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
.lorem {
22
font-size: 16px;
33
line-height: 22px;
4-
color: #8c8c8c;
4+
color: #212121;
5+
font-family: Arial, Helvetica, sans-serif;
56
}

example/src/pages/Home.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
ion-buttons {
2+
position: absolute;
3+
top: 25px;
4+
left: 18px;
5+
}

example/src/pages/Home.tsx

Lines changed: 15 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,31 @@
11
import * as React from 'react'
2-
import {
3-
IonBackButton,
4-
IonButton,
5-
IonButtons,
6-
IonContent,
7-
IonHeader,
8-
IonPage,
9-
IonTitle,
10-
IonToolbar,
11-
} from '@ionic/react'
2+
import { IonButton, IonButtons, IonContent, IonHeader, IonIcon, IonPage, IonTitle, IonToolbar } from '@ionic/react'
3+
4+
import { arrowBack as arrowBack } from 'ionicons/icons'
5+
126
import { Lorem } from '../components/Lorem'
137
import './Home.css'
148
import { useIonHeaderParallax } from 'ionic-react-header-parallax'
159

1610
const Home: React.FC = () => {
17-
const { ref } = useIonHeaderParallax({ image: 'https://picsum.photos/1080' })
11+
const { ref, loading } = useIonHeaderParallax({ image: 'https://picsum.photos/1080', titleColor: 'black' })
1812

1913
return (
2014
<IonPage>
2115
<IonHeader translucent ref={ref}>
22-
<IonToolbar mode="ios">
23-
<IonButtons slot="start">
24-
<IonBackButton defaultHref="/" />
25-
</IonButtons>
26-
<IonTitle>Post Details</IonTitle>
27-
<IonButtons slot="end">
28-
<IonButton>Button</IonButton>
29-
</IonButtons>
16+
<IonToolbar>
17+
<IonToolbar>
18+
<IonButtons slot="start">
19+
<IonButton className="custom-back" color="dark">
20+
<IonIcon icon={arrowBack} />
21+
</IonButton>
22+
</IonButtons>
23+
<IonTitle>Post Details</IonTitle>
24+
</IonToolbar>
3025
</IonToolbar>
3126
</IonHeader>
3227

33-
<IonContent className="ion-padding">
28+
<IonContent>
3429
{Array(20)
3530
.fill(1)
3631
.map((el, index) => (

example/yarn.lock

Lines changed: 100 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1015,7 +1015,14 @@
10151015
core-js-pure "^3.20.2"
10161016
regenerator-runtime "^0.13.4"
10171017

1018-
"@babel/runtime@^7.10.2", "@babel/runtime@^7.11.2", "@babel/runtime@^7.12.5", "@babel/runtime@^7.16.3", "@babel/runtime@^7.7.6", "@babel/runtime@^7.8.4", "@babel/runtime@^7.9.2":
1018+
"@babel/runtime@^7.1.2", "@babel/runtime@^7.12.1", "@babel/runtime@^7.12.13":
1019+
version "7.17.0"
1020+
resolved "https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.17.0.tgz#b8d142fc0f7664fb3d9b5833fd40dcbab89276c0"
1021+
integrity sha512-etcO/ohMNaNA2UBdaXBBSX/3aEzFMRrVfaPv8Ptc0k+cWpWW0QFiGZ2XnVqQZI1Cf734LbPGmqBKWESfW4x/dQ==
1022+
dependencies:
1023+
regenerator-runtime "^0.13.4"
1024+
1025+
"@babel/runtime@^7.10.2", "@babel/runtime@^7.11.2", "@babel/runtime@^7.12.5", "@babel/runtime@^7.16.3", "@babel/runtime@^7.8.4", "@babel/runtime@^7.9.2":
10191026
version "7.16.7"
10201027
resolved "https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.16.7.tgz#03ff99f64106588c9c403c6ecb8c3bafbbdff1fa"
10211028
integrity sha512-9E9FJowqAsytyOY6LG+1KuueckRL+aQW+mKvXRXnuFGyRAyepJPmEo9vgMfXUA6O9u3IeEdv9MAkppFcaQwogQ==
@@ -2090,7 +2097,7 @@
20902097
dependencies:
20912098
"@typescript-eslint/utils" "5.10.2"
20922099

2093-
"@typescript-eslint/parser@^5.5.0":
2100+
"@typescript-eslint/parser@^5.10.2", "@typescript-eslint/parser@^5.5.0":
20942101
version "5.10.2"
20952102
resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-5.10.2.tgz#b6076d27cc5499ce3f2c625f5ccde946ecb7db9a"
20962103
integrity sha512-JaNYGkaQVhP6HNF+lkdOr2cAs2wdSZBoalE22uYWq8IEv/OVH0RksSGydk+sW8cLoSeYmC+OHvRyv2i4AQ7Czg==
@@ -4686,12 +4693,24 @@ he@^1.2.0:
46864693
resolved "https://registry.yarnpkg.com/he/-/he-1.2.0.tgz#84ae65fa7eafb165fddb61566ae14baf05664f0f"
46874694
integrity sha512-F/1DnUGPopORZi0ni+CvrCgHQ5FyEAHRLSApuYWMmrbSwoN2Mn/7k+Gl38gJnR7yyDZk6WLXwiGod1JOWNDKGw==
46884695

4689-
history@^5.2.0:
4690-
version "5.2.0"
4691-
resolved "https://registry.yarnpkg.com/history/-/history-5.2.0.tgz#7cdd31cf9bac3c5d31f09c231c9928fad0007b7c"
4692-
integrity sha512-uPSF6lAJb3nSePJ43hN3eKj1dTWpN9gMod0ZssbFTIsen+WehTmEadgL+kg78xLJFdRfrrC//SavDzmRVdE+Ig==
4696+
history@^4.9.0:
4697+
version "4.10.1"
4698+
resolved "https://registry.yarnpkg.com/history/-/history-4.10.1.tgz#33371a65e3a83b267434e2b3f3b1b4c58aad4cf3"
4699+
integrity sha512-36nwAD620w12kuzPAsyINPWJqlNbij+hpK1k9XRloDtym8mxzGYl2c17LnV6IAGB2Dmg4tEa7G7DlawS0+qjew==
46934700
dependencies:
4694-
"@babel/runtime" "^7.7.6"
4701+
"@babel/runtime" "^7.1.2"
4702+
loose-envify "^1.2.0"
4703+
resolve-pathname "^3.0.0"
4704+
tiny-invariant "^1.0.2"
4705+
tiny-warning "^1.0.0"
4706+
value-equal "^1.0.1"
4707+
4708+
hoist-non-react-statics@^3.1.0:
4709+
version "3.3.2"
4710+
resolved "https://registry.yarnpkg.com/hoist-non-react-statics/-/hoist-non-react-statics-3.3.2.tgz#ece0acaf71d62c2969c2ec59feff42a4b1a85b45"
4711+
integrity sha512-/gGivxi8JPKWNm/W0jSmzcMPpfpPLc3dY/6GxhX2hQ9iGj3aDfklV4ET7NjKpSinLpJ5vafa9iiGIEZg10SfBw==
4712+
dependencies:
4713+
react-is "^16.7.0"
46954714

46964715
hoopy@^0.1.4:
46974716
version "0.1.4"
@@ -4936,10 +4955,9 @@ internal-slot@^1.0.3:
49364955
has "^1.0.3"
49374956
side-channel "^1.0.4"
49384957

4939-
ionic-react-header-parallax@^0.1.8:
4958+
"ionic-react-header-parallax@https://github.com/ahmnouira/ionic-react-header-parallax":
49404959
version "0.1.8"
4941-
resolved "https://registry.yarnpkg.com/ionic-react-header-parallax/-/ionic-react-header-parallax-0.1.8.tgz#de2153ed6ae6a3e3d67a60e76f0a6dd4216a470d"
4942-
integrity sha512-r1zquUMt1krbA/bkJDUC85NR/F9xu+HYT6iT0zpC2jFcFO/gZtcsxqGiGvhi55dOY+LmQQpHkCISU5a+xj0n5A==
4960+
resolved "https://github.com/ahmnouira/ionic-react-header-parallax#d324525c6dbf4b9dbc367813300b7686d44646c1"
49434961

49444962
ionicons@6.0.1, ionicons@^6.0.0:
49454963
version "6.0.1"
@@ -5152,6 +5170,11 @@ is-wsl@^2.1.1, is-wsl@^2.2.0:
51525170
dependencies:
51535171
is-docker "^2.0.0"
51545172

5173+
isarray@0.0.1:
5174+
version "0.0.1"
5175+
resolved "https://registry.yarnpkg.com/isarray/-/isarray-0.0.1.tgz#8a18acfca9a8f4177e09abfc6038939b05d1eedf"
5176+
integrity sha1-ihis/Kmo9Bd+Cav8YDiTmwXR7t8=
5177+
51555178
isarray@~1.0.0:
51565179
version "1.0.0"
51575180
resolved "https://registry.yarnpkg.com/isarray/-/isarray-1.0.0.tgz#bb935d48582cba168c06834957a54a3e07124f11"
@@ -5920,7 +5943,7 @@ lodash@^4.17.14, lodash@^4.17.15, lodash@^4.17.20, lodash@^4.17.21, lodash@^4.7.
59205943
resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.21.tgz#679591c564c3bffaae8454cf0b3df370c3d6911c"
59215944
integrity sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==
59225945

5923-
loose-envify@^1.1.0, loose-envify@^1.4.0:
5946+
loose-envify@^1.1.0, loose-envify@^1.2.0, loose-envify@^1.3.1, loose-envify@^1.4.0:
59245947
version "1.4.0"
59255948
resolved "https://registry.yarnpkg.com/loose-envify/-/loose-envify-1.4.0.tgz#71ee51fa7be4caec1a63839f7e682d8132d30caf"
59265949
integrity sha512-lyuxPGr/Wfhrlem2CL/UcnUc1zcqKAImBDzukY7Y5F/yQiNdko6+fRLevlw1HgMySw7f611UIY408EtxRSoK3Q==
@@ -6044,6 +6067,14 @@ min-indent@^1.0.0:
60446067
resolved "https://registry.yarnpkg.com/min-indent/-/min-indent-1.0.1.tgz#a63f681673b30571fbe8bc25686ae746eefa9869"
60456068
integrity sha512-I9jwMn07Sy/IwOj3zVkVik2JTvgpaykDZEigL6Rx6N9LbMywwUSMtxET+7lVoDLLd3O3IXwJwvuuns8UB/HeAg==
60466069

6070+
mini-create-react-context@^0.4.0:
6071+
version "0.4.1"
6072+
resolved "https://registry.yarnpkg.com/mini-create-react-context/-/mini-create-react-context-0.4.1.tgz#072171561bfdc922da08a60c2197a497cc2d1d5e"
6073+
integrity sha512-YWCYEmd5CQeHGSAKrYvXgmzzkrvssZcuuQDDeqkT+PziKGMgE+0MCCtcKbROzocGBG1meBLl2FotlRwf4gAzbQ==
6074+
dependencies:
6075+
"@babel/runtime" "^7.12.1"
6076+
tiny-warning "^1.0.3"
6077+
60476078
mini-css-extract-plugin@^2.4.5:
60486079
version "2.5.3"
60496080
resolved "https://registry.yarnpkg.com/mini-css-extract-plugin/-/mini-css-extract-plugin-2.5.3.tgz#c5c79f9b22ce9b4f164e9492267358dbe35376d9"
@@ -6525,6 +6556,13 @@ path-to-regexp@0.1.7:
65256556
resolved "https://registry.yarnpkg.com/path-to-regexp/-/path-to-regexp-0.1.7.tgz#df604178005f522f15eb4490e7247a1bfaa67f8c"
65266557
integrity sha1-32BBeABfUi8V60SQ5yR6G/qmf4w=
65276558

6559+
path-to-regexp@^1.7.0:
6560+
version "1.8.0"
6561+
resolved "https://registry.yarnpkg.com/path-to-regexp/-/path-to-regexp-1.8.0.tgz#887b3ba9d84393e87a0a0b9f4cb756198b53548a"
6562+
integrity sha512-n43JRhlUKUAlibEJhPeir1ncUID16QnEjNpwzNdO3Lm4ywrBpBZ5oLD0I6br9evr1Y9JTqwRtAh7JLoOzAQdVA==
6563+
dependencies:
6564+
isarray "0.0.1"
6565+
65286566
path-type@^4.0.0:
65296567
version "4.0.0"
65306568
resolved "https://registry.yarnpkg.com/path-type/-/path-type-4.0.0.tgz#84ed01c0a7ba380afe09d90a8c180dcd9d03043b"
@@ -7167,7 +7205,7 @@ prompts@^2.0.1, prompts@^2.3.2, prompts@^2.4.2:
71677205
kleur "^3.0.3"
71687206
sisteransi "^1.0.5"
71697207

7170-
prop-types@^15.7.2:
7208+
prop-types@^15.6.2, prop-types@^15.7.2:
71717209
version "15.8.1"
71727210
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.8.1.tgz#67d87bf1a694f48435cf332c24af10214a3140b5"
71737211
integrity sha512-oj87CgZICdulUohogVAR7AjlC0327U4el4L6eAvOqCeudMDVU0NThNaV+b9Df4dXgSP1gXMTnPdhfe/2qDH5cg==
@@ -7299,7 +7337,7 @@ react-error-overlay@^6.0.10:
72997337
resolved "https://registry.yarnpkg.com/react-error-overlay/-/react-error-overlay-6.0.10.tgz#0fe26db4fa85d9dbb8624729580e90e7159a59a6"
73007338
integrity sha512-mKR90fX7Pm5seCOfz8q9F+66VCc1PGsWSBxKbITjfKVQHMNF2zudxHnMdJiB1fRCb+XsbQV9sO9DCkgsMQgBIA==
73017339

7302-
react-is@^16.13.1:
7340+
react-is@^16.13.1, react-is@^16.6.0, react-is@^16.7.0:
73037341
version "16.13.1"
73047342
resolved "https://registry.yarnpkg.com/react-is/-/react-is-16.13.1.tgz#789729a4dc36de2999dc156dd6c1d9c18cea56a4"
73057343
integrity sha512-24e6ynE2H+OKt4kqsOvNd8kBpV65zoxbA4BVsEOB3ARVWQki/DHzaUoC5KuON/BiccDaCCTZBuOcfZs70kR8bQ==
@@ -7314,20 +7352,34 @@ react-refresh@^0.11.0:
73147352
resolved "https://registry.yarnpkg.com/react-refresh/-/react-refresh-0.11.0.tgz#77198b944733f0f1f1a90e791de4541f9f074046"
73157353
integrity sha512-F27qZr8uUqwhWZboondsPx8tnC3Ct3SxZA3V5WyEvujRyyNv0VYPhoBg1gZ8/MV5tubQp76Trw8lTv9hzRBa+A==
73167354

7317-
react-router-dom@6.2.1:
7318-
version "6.2.1"
7319-
resolved "https://registry.yarnpkg.com/react-router-dom/-/react-router-dom-6.2.1.tgz#32ec81829152fbb8a7b045bf593a22eadf019bec"
7320-
integrity sha512-I6Zax+/TH/cZMDpj3/4Fl2eaNdcvoxxHoH1tYOREsQ22OKDYofGebrNm6CTPUcvLvZm63NL/vzCYdjf9CUhqmA==
7321-
dependencies:
7322-
history "^5.2.0"
7323-
react-router "6.2.1"
7324-
7325-
react-router@6.2.1, react-router@^6.2.1:
7326-
version "6.2.1"
7327-
resolved "https://registry.yarnpkg.com/react-router/-/react-router-6.2.1.tgz#be2a97a6006ce1d9123c28934e604faef51448a3"
7328-
integrity sha512-2fG0udBtxou9lXtK97eJeET2ki5//UWfQSl1rlJ7quwe6jrktK9FCCc8dQb5QY6jAv3jua8bBQRhhDOM/kVRsg==
7329-
dependencies:
7330-
history "^5.2.0"
7355+
react-router-dom@^5:
7356+
version "5.3.0"
7357+
resolved "https://registry.yarnpkg.com/react-router-dom/-/react-router-dom-5.3.0.tgz#da1bfb535a0e89a712a93b97dd76f47ad1f32363"
7358+
integrity sha512-ObVBLjUZsphUUMVycibxgMdh5jJ1e3o+KpAZBVeHcNQZ4W+uUGGWsokurzlF4YOldQYRQL4y6yFRWM4m3svmuQ==
7359+
dependencies:
7360+
"@babel/runtime" "^7.12.13"
7361+
history "^4.9.0"
7362+
loose-envify "^1.3.1"
7363+
prop-types "^15.6.2"
7364+
react-router "5.2.1"
7365+
tiny-invariant "^1.0.2"
7366+
tiny-warning "^1.0.0"
7367+
7368+
react-router@5.2.1, react-router@^5:
7369+
version "5.2.1"
7370+
resolved "https://registry.yarnpkg.com/react-router/-/react-router-5.2.1.tgz#4d2e4e9d5ae9425091845b8dbc6d9d276239774d"
7371+
integrity sha512-lIboRiOtDLFdg1VTemMwud9vRVuOCZmUIT/7lUoZiSpPODiiH1UQlfXy+vPLC/7IWdFYnhRwAyNqA/+I7wnvKQ==
7372+
dependencies:
7373+
"@babel/runtime" "^7.12.13"
7374+
history "^4.9.0"
7375+
hoist-non-react-statics "^3.1.0"
7376+
loose-envify "^1.3.1"
7377+
mini-create-react-context "^0.4.0"
7378+
path-to-regexp "^1.7.0"
7379+
prop-types "^15.6.2"
7380+
react-is "^16.6.0"
7381+
tiny-invariant "^1.0.2"
7382+
tiny-warning "^1.0.0"
73317383

73327384
react-scripts@5.0.0:
73337385
version "5.0.0"
@@ -7550,6 +7602,11 @@ resolve-from@^5.0.0:
75507602
resolved "https://registry.yarnpkg.com/resolve-from/-/resolve-from-5.0.0.tgz#c35225843df8f776df21c57557bc087e9dfdfc69"
75517603
integrity sha512-qYg9KP24dD5qka9J47d0aVky0N+b4fTU89LN9iDnjB5waksiC49rvMB0PrUJQGoTmH50XPiqOvAjDfaijGxYZw==
75527604

7605+
resolve-pathname@^3.0.0:
7606+
version "3.0.0"
7607+
resolved "https://registry.yarnpkg.com/resolve-pathname/-/resolve-pathname-3.0.0.tgz#99d02224d3cf263689becbb393bc560313025dcd"
7608+
integrity sha512-C7rARubxI8bXFNB/hqcp/4iUeIXJhJZvFPFPiSPRnhU5UPxzMFIl+2E6yY6c4k9giDJAhtV+enfA+G89N6Csng==
7609+
75537610
resolve-url-loader@^4.0.0:
75547611
version "4.0.0"
75557612
resolved "https://registry.yarnpkg.com/resolve-url-loader/-/resolve-url-loader-4.0.0.tgz#d50d4ddc746bb10468443167acf800dcd6c3ad57"
@@ -8342,6 +8399,16 @@ timsort@^0.3.0:
83428399
resolved "https://registry.yarnpkg.com/timsort/-/timsort-0.3.0.tgz#405411a8e7e6339fe64db9a234de11dc31e02bd4"
83438400
integrity sha1-QFQRqOfmM5/mTbmiNN4R3DHgK9Q=
83448401

8402+
tiny-invariant@^1.0.2:
8403+
version "1.2.0"
8404+
resolved "https://registry.yarnpkg.com/tiny-invariant/-/tiny-invariant-1.2.0.tgz#a1141f86b672a9148c72e978a19a73b9b94a15a9"
8405+
integrity sha512-1Uhn/aqw5C6RI4KejVeTg6mIS7IqxnLJ8Mv2tV5rTc0qWobay7pDUz6Wi392Cnc8ak1H0F2cjoRzb2/AW4+Fvg==
8406+
8407+
tiny-warning@^1.0.0, tiny-warning@^1.0.3:
8408+
version "1.0.3"
8409+
resolved "https://registry.yarnpkg.com/tiny-warning/-/tiny-warning-1.0.3.tgz#94a30db453df4c643d0fd566060d60a875d84754"
8410+
integrity sha512-lBN9zLN/oAf68o3zNXYrdCt1kP8WsiGW8Oo2ka41b2IM5JL/S1CTyX1rW0mb/zSuJun0ZUrDxx4sqvYS2FWzPA==
8411+
83458412
tmpl@1.0.5:
83468413
version "1.0.5"
83478414
resolved "https://registry.yarnpkg.com/tmpl/-/tmpl-1.0.5.tgz#8683e0b902bb9c20c4f726e3c0b69f36518c07cc"
@@ -8473,7 +8540,7 @@ typedarray-to-buffer@^3.1.5:
84738540
dependencies:
84748541
is-typedarray "^1.0.0"
84758542

8476-
typescript@4.5.5:
8543+
typescript@^4.3.5:
84778544
version "4.5.5"
84788545
resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.5.5.tgz#d8c953832d28924a9e3d37c73d729c846c5896f3"
84798546
integrity sha512-TCTIul70LyWe6IJWT8QSYeA54WQe8EjQFU4wY52Fasj5UKx88LNYKCgBEHcOMOrFF1rKGbD8v/xcNWVUq9SymA==
@@ -8599,6 +8666,11 @@ v8-to-istanbul@^8.1.0:
85998666
convert-source-map "^1.6.0"
86008667
source-map "^0.7.3"
86018668

8669+
value-equal@^1.0.1:
8670+
version "1.0.1"
8671+
resolved "https://registry.yarnpkg.com/value-equal/-/value-equal-1.0.1.tgz#1e0b794c734c5c0cade179c437d356d931a34d6c"
8672+
integrity sha512-NOJ6JZCAWr0zlxZt+xqCHNTEKOsrks2HQd4MqhP1qy4z1SkbEP467eNx6TgDKXMvUOb+OENfJCZwM+16n7fRfw==
8673+
86028674
vary@~1.1.2:
86038675
version "1.1.2"
86048676
resolved "https://registry.yarnpkg.com/vary/-/vary-1.1.2.tgz#2299f02c6ded30d4a5961b0b9f74524a18f634fc"

src/useIonicHeaderParallax.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ export type UseIonHeaderParallaxInput = {
55
expandedColor?: string
66
titleColor?: string
77
maximumHeight?: number
8-
defaultImage: string
8+
defaultImage?: string
99
showBarButtons?: boolean
1010
}
1111

@@ -140,7 +140,6 @@ export function useIonHeaderParallax({
140140
if (barButtons) {
141141
barButtons.style.pointerEvents = 'all'
142142
Array.from(barButtons.children).forEach((btn) => {
143-
// console.log(btn, btn as HTMLElement)
144143
const htmlBtn = btn as HTMLElement
145144
htmlBtn.style.color = titleColor
146145
})

types/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ export type UseIonHeaderParallaxInput = {
55
expandedColor?: string
66
titleColor?: string
77
maximumHeight?: number
8-
defaultImage: string
8+
defaultImage?: string
99
showBarButtons?: boolean
1010
}
1111

0 commit comments

Comments
 (0)