chore: remove signup button front-end post call

Author: rsbowers

src/app/code/community/Zendesk/Zendesk/Block/Adminhtml/Config/Buttons/Signup.php

@@ -37,48 +37,11 @@ protected function _getElementHtml(Varien_Data_Form_Element_Abstract $element)
         $originalData = $element->getOriginalData();
         $this->addData(array(
             'button_label' => Mage::helper('zendesk')->__($originalData['button_label']),
+            'button_url' => Mage::helper('zendesk')->__($originalData['button_url']),
             'html_id' => $element->getHtmlId(),
             'url' => Mage::getSingleton('adminhtml/url')->getUrl('*/setup/start')
         ));
 
         return $this->_toHtml();
     }
-
-    public function getPostUrl()
-    {
-        return Mage::helper('zendesk')->getProvisionUrl();
-    }
-
-    public function getPostInfo()
-    {
-        $websiteCode = Mage::app()->getRequest()->getParam('website');
-        if ($websiteCode) {
-            $website = Mage::getModel('core/website')->load($websiteCode);
-        } else {
-            $website = Mage::getModel('core/website')->getCollection()
-                     ->addFieldToFilter('is_default', 1)
-                     ->getFirstItem();
-        }
-
-        $storeCode = Mage::app()->getRequest()->getParam('store');
-        if ($storeCode) {
-            $store = Mage::getModel('core/store')->load($storeCode);
-        } else {
-            $store = $website->getDefaultStore();
-        }
-
-        $info = array(
-            'magento_domain' => Mage::getBaseUrl(Mage_Core_Model_Store::URL_TYPE_WEB),
-            'magento_current_user_id' => Mage::getSingleton('admin/session')->getUser()->getUserId(),
-            'magento_user_count' => Mage::getModel('admin/user')->getCollection()->getSize(),
-            'magento_auth_token' => Mage::helper('zendesk')->getProvisionToken(true),
-            'magento_callback' => Mage::helper('adminhtml')->getUrl('adminhtml/zendesk/redirect', array('type' => 'settings', 'id' => 'zendesk')),
-            'magento_locale' => Mage::getStoreConfig('general/locale/code'),
-            'magento_timezone' => Mage::getStoreConfig('general/locale/timezone'),
-            'magento_api_url' => Mage::getUrl('zendesk/api', array('_store' => $store->getCode())),
-            'magento_store_name' => $website->getName(),
-        );
-
-        return $info;
-    }
 }

src/app/code/community/Zendesk/Zendesk/Helper/Data.php

@@ -154,23 +154,6 @@ public function setApiToken($token = null)
         return $token;
     }
 
-    /**
-     * Returns the provisioning endpoint for new setups.
-     *
-     * This uses the config/zendesk/provision_url XML path to retrieve the setting, with a default value set in
-     * the extension config.xml file. This can be overridden in your website's local.xml file.
-     * @return null|string URL or null on failure
-     */
-    public function getProvisionUrl()
-    {
-        $config = Mage::getConfig();
-        $data = $config->getNode('zendesk/provision_url');
-        if(!$data) {
-            return null;
-        }
-        return (string)$data;
-    }
-
     public function getProvisionToken($generate = false)
     {
         $token = Mage::getStoreConfig('zendesk/hidden/provision_token', 0);

src/app/code/community/Zendesk/Zendesk/etc/config.xml

@@ -22,9 +22,6 @@
             <version>3.0.1</version>
         </Zendesk_Zendesk>
     </modules>
-    <zendesk>
-        <provision_url>https://signup.zendesk.com/provisioning/magento/welcome</provision_url>
-    </zendesk>
     <global>
         <models>
             <zendesk>

src/app/code/community/Zendesk/Zendesk/etc/system.xml

@@ -471,11 +471,12 @@
                     <show_in_default>1</show_in_default>
                     <show_in_website>1</show_in_website>
                     <show_in_store>1</show_in_store>
-                    <comment><![CDATA[Haven't set up Zendesk Support yet? Follow our easy setup guide to get started.]]></comment>
+                    <comment><![CDATA[<p>Need to set up the agnoStack Zendesk plugin?<br/>Learn More at <a href="https://agnostack.com/faqs/setup-onboarding/configure-manage-your-account" target="_blank">https://agnostack.com/faqs/setup-onboarding/configure-manage-your-account</a>.</p><p>Haven't set up Zendesk Support yet? Click below to get started.</p>]]></comment>
                     <fields>
                         <sign_up translate="button_label">
                             <label></label>
-                            <button_label>Setup Guide</button_label>
+                            <button_label>Get Started</button_label>
+                            <button_url>https://agnostack.com/book-a-meeting</button_url>
                             <frontend_model>zendesk/adminhtml_config_buttons_signup</frontend_model>
                             <sort_order>1</sort_order>
                             <show_in_default>1</show_in_default>

src/app/design/adminhtml/default/default/template/zendesk/config/button-signup.phtml

@@ -15,16 +15,6 @@
  * limitations under the License.
  */
 ?>
-<script type="text/javascript">
-    function postToZendesk() {
-        var form = new Element('form', {method: 'post', action: '<?php echo $this->getPostUrl(); ?>'});
-        <?php foreach($this->getPostInfo() as $name => $value): ?>
-            form.insert(new Element('input', {type: 'hidden', name: '<?php echo $name; ?>', value: '<?php echo $value; ?>'}));
-        <?php endforeach; ?>
-        $(document.body).insert(form);
-        form.submit();
-    }
-</script>
-<button style="" onclick="javascript:postToZendesk(); return false;" class="scalable" type="button" id="<?php echo $this->getHtmlId() ?>">
+<button style="" onclick="window.location.href='<?php echo $this->escapeHtml($this->getButtonUrl()); ?>'" class="scalable" type="button" id="<?php echo $this->getHtmlId() ?>">
     <span><?php echo $this->escapeHtml($this->getButtonLabel()) ?></span>
 </button>