Skip to content

Commit c38e17c

Browse files
Oscar-WagentoOscar-Wagento
committed
Removing code commented, blocks commented, camelCode to some variables
1 parent 72c3b08 commit c38e17c

File tree

3 files changed

+83
-44
lines changed

3 files changed

+83
-44
lines changed

‎src/app/code/community/Zendesk/Zendesk/Helper/Sync.php‎

Lines changed: 27 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,48 @@
11
<?php
2-
/**
3-
* Created by PhpStorm.
4-
* User: o5k4r1n
5-
* Date: 29-05-18
6-
* Time: 10:44 AM
7-
*/
2+
83
class Zendesk_Zendesk_Helper_Sync extends Mage_Core_Helper_Abstract {
94

105
public function getCustomerData($customer){
116
if(!Mage::getStoreConfig('zendesk/general/customer_sync'))
127
return;
138

149
$user = null;
15-
//$customer = $event->getCustomer();
1610
$email = $customer->getEmail();
17-
$orig_email = $customer->getOrigData();
18-
$orig_email = $orig_email['email'];
19-
echo "correo: ".$email;
11+
$origEmail = $customer->getOrigData();
12+
$origEmail = $origEmail['email'];
2013
//Get Customer Group
21-
$group_id = $customer->getGroupId();
22-
$group = Mage::getModel('customer/group')->load($group_id);
14+
$groupId = $customer->getGroupId();
15+
$group = Mage::getModel('customer/group')->load($groupId);
2316

2417
//Get Customer Last Login Date
25-
$log_customer = Mage::getModel('log/customer')->loadByCustomer($customer);
26-
if ($log_customer->getLoginAt())
27-
$logged_in = date("Y-m-d\TH:i:s\Z",strtotime($log_customer->getLoginAt()));
18+
$logCustomer = Mage::getModel('log/customer')->loadByCustomer($customer);
19+
if ($logCustomer->getLoginAt())
20+
$loggedIn = date("Y-m-d\TH:i:s\Z",strtotime($logCustomer->getLoginAt()));
2821
else
29-
$logged_in = "";
22+
$loggedIn = "";
3023

3124
//Get Customer Sales Statistics
32-
$order_totals = Mage::getResourceModel('sales/order_collection');
33-
$lifetime_sale = 0;
34-
$average_sale = 0;
25+
$orderTotals = Mage::getResourceModel('sales/order_collection');
26+
$lifetimeSale = 0;
27+
$averageSale = 0;
3528

36-
if (is_object($order_totals)) {
37-
$order_totals
29+
if (is_object($orderTotals)) {
30+
$orderTotals
3831
->addFieldToFilter('customer_id', $customer->getId())
3932
->addFieldToFilter('status', Mage_Sales_Model_Order::STATE_COMPLETE);
4033

41-
$order_totals->getSelect()
34+
$orderTotals->getSelect()
4235
->reset(Zend_Db_Select::COLUMNS)
4336
->columns(new Zend_Db_Expr("SUM(grand_total) as total"))
4437
->columns(new Zend_Db_Expr("AVG(grand_total) as avg_total"))
4538
->group('customer_id');
4639

47-
if (count($order_totals) > 0) {
48-
$sum = (float) $order_totals->getFirstItem()->getTotal();
49-
$avg = (float) $order_totals->getFirstItem()->getAvgTotal();
40+
if (count($orderTotals) > 0) {
41+
$sum = (float) $orderTotals->getFirstItem()->getTotal();
42+
$avg = (float) $orderTotals->getFirstItem()->getAvgTotal();
5043

51-
$lifetime_sale = Mage::helper('core')->currency($sum, true, false);
52-
$average_sale = Mage::helper('core')->currency($avg, true, false);
44+
$lifetimeSale = Mage::helper('core')->currency($sum, true, false);
45+
$averageSale = Mage::helper('core')->currency($avg, true, false);
5346
}
5447
}
5548

@@ -60,14 +53,14 @@ public function getCustomerData($customer){
6053
"group" => $group->getCode(),
6154
"name" => $customer->getFirstname() . " " . $customer->getLastname(),
6255
"id" => $customer->getId(),
63-
"logged_in" => $logged_in,
64-
"average_sale" => $average_sale,
65-
"lifetime_sale" => $lifetime_sale
56+
"logged_in" => $loggedIn,
57+
"average_sale" => $averageSale,
58+
"lifetime_sale" => $lifetimeSale
6659
)
6760
);
6861

69-
if($orig_email && $orig_email !== $email) {
70-
$user = Mage::getModel('zendesk/api_users')->find($orig_email);
62+
if($origEmail && $origEmail !== $email) {
63+
$user = Mage::getModel('zendesk/api_users')->find($origEmail);
7164

7265
if(isset($user['id'])) {
7366
$data['identity'] = array(
@@ -93,8 +86,8 @@ public function getCustomerData($customer){
9386
}
9487
return $user;
9588
}
96-
public function syncData($info)
89+
private function syncData($info)
9790
{
9891
Mage::getModel('zendesk/api_users')->create($info);
9992
}
100-
}
93+
}

‎src/app/code/community/Zendesk/Zendesk/Model/Customer.php‎

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,4 @@
11
<?php
2-
/**
3-
* Created by PhpStorm.
4-
* User: o5k4r1n
5-
* Date: 25-05-18
6-
* Time: 05:10 PM
7-
*/
82

93
class Zendesk_Zendesk_Model_Customer extends Mage_Core_Model_Abstract{
104

@@ -20,11 +14,10 @@ public function syncronize(){
2014
Mage::log('Synchronization started', null, 'zendesk.log');
2115
try {
2216
Mage::log('Synchronizing customer with id '.$customer->getId(), null, 'zendesk.log');
23-
$customer_data = Mage::helper('zendesk/sync')->getCustomerData($customer);
24-
$zendesk_id = $customer_data['id'];
25-
$customer->setZendeskId($zendesk_id);
17+
$customerData = Mage::helper('zendesk/sync')->getCustomerData($customer);
18+
$zendeskId = $customerData['id'];
19+
$customer->setZendeskId($zendeskId);
2620
$customer->save();
27-
//Zend_Debug::dump($customer_data);
2821
}
2922
catch (Exception $ex) {
3023
Mage::log('Synchronization failed: '.$ex->getMessage(), null, 'zendesk.log');

‎src/app/code/community/Zendesk/Zendesk/data/zendesk_setup/data-upgrade-2.0.6-2.1.13.php‎

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
<?php
2+
/*$installer = new Mage_Eav_Model_Entity_Setup('core_setup');
3+
$installer->startSetup();
4+
$installer->addAttribute('customer', 'zendesk_id', array(
5+
'group' => 'General',
6+
'label' => 'Zendesk Id',
7+
'input' => 'text',
8+
'type' => 'text',
9+
'required' => 0,
10+
'visible_on_front'=> 1,
11+
'filterable' => 0,
12+
'searchable' => 0,
13+
'comparable' => 0,
14+
'user_defined' => 1,
15+
'is_configurable' => 0,
16+
'global' => Mage_Catalog_Model_Resource_Eav_Attribute::SCOPE_GLOBAL,
17+
'note' => '',
18+
));
19+
$installer->endSetup();*/
20+
21+
$installer = new Mage_Eav_Model_Entity_Setup('core_setup');
22+
$installer->startSetup();
23+
$installer->addAttribute("customer", "zendesk_id", array(
24+
"type" => "varchar",
25+
"backend" => "",
26+
"label" => "zendesk_id",
27+
"input" => "text",
28+
"source" => "",
29+
"visible" => true,
30+
"required" => false,
31+
"default" => "",
32+
"frontend" => "",
33+
"unique" => false,
34+
"note" => ""
35+
36+
));
37+
38+
$attribute = Mage::getSingleton("eav/config")->getAttribute("customer", "zendesk_id");
39+
$used_in_forms=array();
40+
41+
$used_in_forms[]="adminhtml_customer";
42+
$used_in_forms[]="checkout_register";
43+
$used_in_forms[]="customer_account_create";
44+
$used_in_forms[]="customer_account_edit";
45+
$used_in_forms[]="adminhtml_checkout";
46+
$attribute->setData("used_in_forms", $used_in_forms)
47+
->setData("is_used_for_customer_segment", true)
48+
->setData("is_system", 0)
49+
->setData("is_user_defined", 1)
50+
->setData("is_visible", 1)
51+
->setData("sort_order", 100);
52+
$attribute->save();
53+
$installer->endSetup();

0 commit comments

Comments
 (0)