Merge pull request #222 from agile-ts/feature/compute-in-sync

Feature/compute in sync

Author: bennobuilder

.circleci/config.yml

@@ -1,19 +1,15 @@
 # Following this caching concept https://circleci.com/docs/2.0/persist-data/
+# https://circleci.com/docs/language-javascript
 
 version: 2.1
 
 orbs:
-  node: circleci/node@4.1.0
-
-executors:
-  node-executor:
-    docker:
-      - image: circleci/node:14
+  node: circleci/node@5.0.2
 
 jobs:
 
   build:
-    executor: node-executor
+    executor: node/default # Docker environment in what to execute the steps
     steps:
       # Checkout Project from Github
       - checkout
@@ -31,9 +27,9 @@ jobs:
      #       # fallback to using the latest cache if no exact match is found
      #       - v1-dependencies-
 
-      - run:
-         name: ⏳ Install
-         command: yarn install
+#      - run:
+#         name: ⏳ Install
+#         command: yarn install
 
      # Not necessary because of auto caching of circleci/node@4.1.0
      # - save_cache:
@@ -55,7 +51,7 @@ jobs:
           paths: [ ./* ]
 
   test:
-    executor: node-executor
+    executor: node/default
     steps:
       # https://circleci.com/docs/2.0/configuration-reference/#attach_workspace
       - attach_workspace:
@@ -70,7 +66,7 @@ jobs:
           command: yarn run test --runInBand # Tests somehow only get executed with the '--runInBand' Flag
 
   test-coverage:
-    executor: node-executor
+    executor: node/default
     steps:
       # https://circleci.com/docs/2.0/configuration-reference/#attach_workspace
       - attach_workspace:

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,6 +1,6 @@
 ---
 name: 🐛 Bug report
-about: Create a report to help us improve AgileTs
+about: Create a bug report to help us improve AgileTs
 title: ''
 labels: 'Type: Bug'
 assignees: ''
@@ -11,35 +11,36 @@ assignees: ''
 
 ### 🤖 Current Behavior
 
-<!-- Explain your problem (with screenshots, videos, text) in detail -->
+<!-- Explain your problem (e.g. with screenshots, text, code snippets) in detail -->
 
 ### 🎯 Expected behavior
 
 <!-- A clear and concise description of what you expected to happen. -->
 
 ### 📄 Reproducible example
 
-<!-- Create a simple example in Codebox -->
+<!-- Create a simple example that reproduces your problem in a code sandbox 
+     (like this one: https://codesandbox.io/s/issue-219-ufcck?file=/src/main.js) -->
 
 ### 💡 Suggested solution(s)
 
-<!-- How could we solve this bug? What changes would need to made to AgileTs? -->
+<!-- How could we solve this bug? What changes would need to made to AgileTs? Any idea? -->
 
 ### ➕ Additional notes
 
-<!-- Add any other context about the problem here.  -->
+<!-- Add additional context about the problem here. (optional) -->
 
 ### 💻 Your environment
 
-<!-- PLEASE FILL THIS OUT -->
+<!-- What version/s of AgileTs are you using? -->
 
 | Software              | Version(s) |
 | ----------------------| ---------- |
-| TypeScript            |
-| npm/Yarn              |
-| NodeJs                |
-| @agile-ts/core        |
-| @agile-ts/react       |
-| @agile-ts/api         |
-| @agile-ts/multieditor |
-<!-- Any additional important Version Notes? -->
+| @agile-ts/core        | N/A
+| @agile-ts/react       | N/A
+| @agile-ts/api         | N/A
+| @agile-ts/multieditor | N/A
+| TypeScript            | N/A
+| npm/Yarn              | N/A
+| NodeJs                | N/A
+<!-- Any additional important version notes? -->

.gitignore

@@ -13,7 +13,6 @@ yarn-debug.log*
 yarn-error.log*
 .eslintcache
 package-lock.json
-yarn.lock
 
 # Editor directories and files
 .idea

README.md

@@ -1,4 +1,12 @@
- <img src="https://raw.githubusercontent.com/agile-ts/agile/master/static/header_background.png" alt="AgileTs">
+> ⚠️ **No longer actively maintained**. 
+> In case there will be a higher demand and more known bugs in the future, 
+> I will be happy to continue improving this project. 
+> But as for now its stable and can be used in any sort of project.
+> In case you face any problem feel free open an [issue](https://github.com/agile-ts/agile/issues).
+>
+> ❓ If you've any questions feel free to start a [discussions](https://github.com/agile-ts/agile/discussions). 
+
+<img src="https://raw.githubusercontent.com/agile-ts/agile/master/static/header_background.png" alt="AgileTs">
 
 > Global State and Logic Library
 

examples/react/develop/fields/src/App.js

@@ -52,7 +52,8 @@ export default function App() {
             id: FIELDS.size,
             name: `Field #${FIELDS.size + 1}`,
           });
-        }}>
+        }}
+      >
         Add Field
       </button>
     </div>

examples/react/develop/simple-todo-list/src/App.js

@@ -30,7 +30,8 @@ const App = () => {
             method: 'unshift', // to add todo at the beginning of the Collection
           });
           setCurrentInput('');
-        }}>
+        }}
+      >
         Add
       </button>
       {todos.map((value) => (
@@ -41,7 +42,8 @@ const App = () => {
             onClick={() => {
               // Remove Todo at specific primary Key
               TODOS.remove(value.id).everywhere();
-            }}>
+            }}
+          >
             Remove
           </button>
         </div>

package.json

@@ -17,7 +17,6 @@
   "syncDir": "dist",
   "scripts": {
     "build": "lerna run build",
-    "prepare": "lerna run prepare",
     "changelog": "lerna-changelog",
     "bootstrap": "lerna bootstrap",
     "watch:core": "cd packages/core && yarn run watch",
@@ -41,7 +40,8 @@
     "pack:react": "cd packages/react && yarn run prepare && yarn run pack",
     "pack:multieditor": "cd packages/multieditor && yarn run prepare && yarn run pack",
     "pack:api": "cd packages/api && yarn run prepare && yarn run pack",
-    "pack:event": "cd packages/event && yarn run prepare && yarn run pack"
+    "pack:event": "cd packages/event && yarn run prepare && yarn run pack",
+    "install:clean": "shx rm -rf yarn.lock && shx rm -rf node_modules && yarn install && lerna run install:clean"
   },
   "repository": {
     "type": "git",

packages/api/package.json

@@ -26,7 +26,6 @@
   },
   "scripts": {
     "build": "shx rm -rf dist && rollup --c rollup.config.js",
-    "prepare": "yarn run build",
     "dev:publish": "yalc publish",
     "dev:push": "yalc push",
     "watch:push": "tsc-watch --onSuccess \"yarn run dev:push\"",

packages/core/package.json

@@ -37,7 +37,6 @@
   },
   "scripts": {
     "build": "shx rm -rf dist && rollup --c rollup.config.js",
-    "prepare": "yarn run build",
     "dev:publish": "yalc publish",
     "dev:push": "yalc push",
     "watch:push": "tsc-watch --onSuccess \"yarn run dev:push\"",

packages/core/src/collection/collection.persistent.ts

@@ -1,7 +1,7 @@
 import { defineConfig } from '@agile-ts/utils';
 import { logCodeManager } from '../logCodeManager';
 import { Collection, CollectionKey, DefaultItem, ItemKey } from './collection';
-import { Group, GroupKey } from './group';
+import type { Group, GroupKey } from './group';
 import {
   CreatePersistentConfigInterface,
   getSharedStorageManager,
@@ -137,9 +137,8 @@ export class CollectionPersistent<
         // that it was loaded completely.
         // After a successful loading assign the now valid Item to the Collection.
         else {
-          const placeholderItem = this.collection().getItemWithReference(
-            itemKey
-          );
+          const placeholderItem =
+            this.collection().getItemWithReference(itemKey);
           placeholderItem?.persist({
             key: itemStorageKey,
             loadValue: false,
@@ -148,7 +147,8 @@ export class CollectionPersistent<
             followCollectionPersistKeyPattern: false, // Because of the dynamic 'storageItemKey', the key is already formatted above
           });
           if (placeholderItem?.persistent?.ready) {
-            const loadedPersistedValueIntoItem = await placeholderItem.persistent.loadPersistedValue();
+            const loadedPersistedValueIntoItem =
+              await placeholderItem.persistent.loadPersistedValue();
 
             // If successfully loaded Item value, assign Item to Collection
             if (loadedPersistedValueIntoItem) {