fixed freezing issue when using useProxy

Author: bennobuilder

packages/core/src/collection/collection.ts

@@ -23,10 +23,7 @@ import { GroupIngestConfigInterface } from './group/group.observer';
 import { StorageKey } from '../storages';
 import { CollectionPersistent } from './collection.persistent';
 
-export class Collection<
-  DataType extends DefaultItem = DefaultItem,
-  GroupValueType = Array<ItemKey> // To extract the Group Type Value in Integration methods like 'useValue()'
-> {
+export class Collection<DataType extends DefaultItem = DefaultItem> {
   // Agile Instance the Collection belongs to
   public agileInstance: () => Agile;
 

packages/core/src/collection/group/group.observer.ts

@@ -16,12 +16,12 @@ export class GroupObserver<
   // Group the Observer belongs to
   public group: () => Group<DataType>;
 
-  // Next output applied to the Group
+  // Next vale (output) applied to the Group
   public nextGroupValue: DataType[];
 
-  // Current value of the Group (shared with the UI)
+  // Current value (output) of the Group (shared with the UI)
   public value?: DataType[];
-  // Previous value of the Group (for handling selectors)
+  // Previous value (output) of the Group (for handling selectors)
   public previousValue?: DataType[];
 
   /**
@@ -123,7 +123,7 @@ export class GroupObserver<
 
     // Assign new public output to the Observer (output used by the Integrations)
     observer.previousValue = Object.freeze(copy(observer.value)) as any;
-    observer.value = Object.freeze(copy(group._output)) as any;
+    observer.value = copy(group._output); // Object.freeze(copy(group._output)); // Not freezing because of 'useProxy' hook
   }
 }
 

packages/core/src/state/state.observer.ts

@@ -154,7 +154,7 @@ export class StateObserver<ValueType = any> extends Observer {
 
     // Assign new public value to the Observer (value used by the Integrations)
     job.observer.previousValue = Object.freeze(copy(observer.value));
-    job.observer.value = Object.freeze(copy(state._value));
+    job.observer.value = copy(state._value); // Object.freeze(copy(state._value)); // Not freezing because of 'useProxy' hook
   }
 
   /**

packages/react/src/core/hooks/useBaseAgile.ts

@@ -93,7 +93,7 @@ export const getReturnValue = (
 
 export type SubscribableAgileInstancesType =
   | State
-  | Collection<any, any> //https://stackoverflow.com/questions/66987727/type-classa-id-number-name-string-is-not-assignable-to-type-classar
+  | Collection<any> //https://stackoverflow.com/questions/66987727/type-classa-id-number-name-string-is-not-assignable-to-type-classar
   | Observer
   | undefined;
 

packages/react/src/core/hooks/useValue.ts

@@ -1,9 +1,9 @@
 import {
   Collection,
   Group,
-  Observer,
   State,
   defineConfig,
+  ItemKey,
 } from '@agile-ts/core';
 import { useAgile } from './useAgile';
 import {
@@ -39,35 +39,28 @@ export function useValue<
 // Array Type
 // https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-1.html
 export type AgileValueHookArrayType<T> = {
-  [K in keyof T]: T[K] extends
-    | Collection<infer U, infer Z>
-    | Group<infer U, infer Z>
-    ? Z
+  [K in keyof T]: T[K] extends Collection | Group
+    ? Array<ItemKey>
     : T[K] extends State<infer U>
     ? U
     : T[K] extends undefined
     ? undefined
-    : T[K] extends
-        | Collection<infer U, infer Z>
-        | Group<infer U, infer Z>
-        | undefined
-    ? Z | undefined
+    : T[K] extends Collection | Group | undefined
+    ? Array<ItemKey> | undefined
     : T[K] extends State<infer U> | undefined
     ? U | undefined
     : never;
 };
 
 // No Array Type
-export type AgileValueHookType<T> = T extends
-  | Collection<infer U, infer Z>
-  | Group<infer U, infer Z>
-  ? Z
+export type AgileValueHookType<T> = T extends Collection | Group
+  ? Array<ItemKey>
   : T extends State<infer U>
   ? U
   : T extends undefined
   ? undefined
-  : T extends Collection<infer U, infer Z> | Group<infer U, infer Z> | undefined
-  ? Z | undefined
+  : T extends Collection | Group | undefined
+  ? Array<ItemKey> | undefined
   : T extends State<infer U> | undefined
   ? U | undefined
   : never;

packages/react/src/proxy/hooks/useProxy.ts

@@ -87,7 +87,7 @@ export function useProxy<
 
   const handleReturn = (dep: Observer | undefined) => {
     if (dep == null) return undefined as any;
-    const value = dep.value;
+    const value = dep['value'];
 
     // If proxyBased and the value is of the type object.
     // Wrap a Proxy around the object to track the accessed properties.