Merge pull request h2non#70 from kaapstorm/exceptions

Exceptions

Author: h2non

jsonpath_ng/exceptions.py

@@ -0,0 +1,10 @@
+class JSONPathError(Exception):
+    pass
+
+
+class JsonPathLexerError(JSONPathError):
+    pass
+
+
+class JsonPathParserError(JSONPathError):
+    pass

jsonpath_ng/lexer.py

@@ -4,11 +4,9 @@
 
 import ply.lex
 
-logger = logging.getLogger(__name__)
-
+from jsonpath_ng.exceptions import JsonPathLexerError
 
-class JsonPathLexerError(Exception):
-    pass
+logger = logging.getLogger(__name__)
 
 
 class JsonPathLexer(object):

jsonpath_ng/parser.py

@@ -1,18 +1,26 @@
-from __future__ import print_function, absolute_import, division, generators, nested_scopes
+from __future__ import (
+    print_function,
+    absolute_import,
+    division,
+    generators,
+    nested_scopes,
+)
 import sys
 import os.path
-import logging
 
 import ply.yacc
 
+from jsonpath_ng.exceptions import JsonPathParserError
 from jsonpath_ng.jsonpath import *
 from jsonpath_ng.lexer import JsonPathLexer
 
 logger = logging.getLogger(__name__)
 
+
 def parse(string):
     return JsonPathParser().parse(string)
 
+
 class JsonPathParser(object):
     '''
     An LALR-parser for JsonPath
@@ -21,8 +29,12 @@ class JsonPathParser(object):
     tokens = JsonPathLexer.tokens
 
     def __init__(self, debug=False, lexer_class=None):
-        if self.__doc__ == None:
-            raise Exception('Docstrings have been removed! By design of PLY, jsonpath-rw requires docstrings. You must not use PYTHONOPTIMIZE=2 or python -OO.')
+        if self.__doc__ is None:
+            raise JsonPathParserError(
+                'Docstrings have been removed! By design of PLY, '
+                'jsonpath-rw requires docstrings. You must not use '
+                'PYTHONOPTIMIZE=2 or python -OO.'
+            )
 
         self.debug = debug
         self.lexer_class = lexer_class or JsonPathLexer # Crufty but works around statefulness in PLY
@@ -66,7 +78,8 @@ def parse_token_stream(self, token_iterator, start_symbol='jsonpath'):
     ]
 
     def p_error(self, t):
-        raise Exception('Parse error at %s:%s near token %s (%s)' % (t.lineno, t.col, t.value, t.type))
+        raise JsonPathParserError('Parse error at %s:%s near token %s (%s)'
+                                  % (t.lineno, t.col, t.value, t.type))
 
     def p_jsonpath_binop(self, p):
         """jsonpath : jsonpath '.' jsonpath
@@ -98,7 +111,8 @@ def p_jsonpath_named_operator(self, p):
         elif p[1] == 'parent':
             p[0] = Parent()
         else:
-            raise Exception('Unknown named operator `%s` at %s:%s' % (p[1], p.lineno(1), p.lexpos(1)))
+            raise JsonPathParserError('Unknown named operator `%s` at %s:%s'
+                                      % (p[1], p.lineno(1), p.lexpos(1)))
 
     def p_jsonpath_root(self, p):
         "jsonpath : '$'"

tests/test_exceptions.py

@@ -0,0 +1,20 @@
+import pytest
+
+from jsonpath_ng import parse as rw_parse
+from jsonpath_ng.exceptions import JSONPathError, JsonPathParserError
+from jsonpath_ng.ext import parse as ext_parse
+
+
+def test_rw_exception_class():
+    with pytest.raises(JSONPathError):
+        rw_parse('foo.bar.`grandparent`.baz')
+
+
+def test_rw_exception_subclass():
+    with pytest.raises(JsonPathParserError):
+        rw_parse('foo.bar.`grandparent`.baz')
+
+
+def test_ext_exception_subclass():
+    with pytest.raises(JsonPathParserError):
+        ext_parse('foo.bar.`grandparent`.baz')