[Java] Upgrade to Checkstyle 7.1.1.

Author: mjpt777

build.gradle

@@ -115,7 +115,7 @@ subprojects {
     [compileJava, compileTestJava]*.options*.encoding = 'UTF-8'
 
     dependencies {
-        checkstyle 'com.puppycrawl.tools:checkstyle:7.0'
+        checkstyle 'com.puppycrawl.tools:checkstyle:7.1.1'
         checkstyle 'com.github.sevntu.checkstyle:sevntu-checks:1.21.0'
 
         testCompile 'org.hamcrest:hamcrest-all:1.3'
@@ -126,7 +126,7 @@ subprojects {
 
     checkstyle {
         configFile = new File(rootDir, 'config/checkstyle.xml')
-        toolVersion = '7.0'
+        toolVersion = '7.1.1'
     }
 
     compileJava {

sbe-samples/src/main/java/uk/co/real_logic/sbe/examples/ExampleUsingGeneratedStub.java

@@ -82,7 +82,7 @@ public static void main(final String[] args) throws Exception
         final String encodingFilename = System.getProperty(ENCODING_FILENAME);
         if (encodingFilename != null)
         {
-            try (final FileChannel channel = new FileOutputStream(encodingFilename).getChannel())
+            try (FileChannel channel = new FileOutputStream(encodingFilename).getChannel())
             {
                 byteBuffer.limit(encodingLength);
                 channel.write(byteBuffer);

sbe-samples/src/main/java/uk/co/real_logic/sbe/examples/ExampleUsingGeneratedStubExtension.java

@@ -83,7 +83,7 @@ public static void main(final String[] args) throws Exception
         final String encodingFilename = System.getProperty(ENCODING_FILENAME);
         if (encodingFilename != null)
         {
-            try (final FileChannel channel = new FileOutputStream(encodingFilename).getChannel())
+            try (FileChannel channel = new FileOutputStream(encodingFilename).getChannel())
             {
                 byteBuffer.limit(encodingLength);
                 channel.write(byteBuffer);

sbe-samples/src/main/java/uk/co/real_logic/sbe/examples/OtfExample.java

@@ -93,11 +93,11 @@ public static void main(final String[] args) throws Exception
 
     private static void encodeSchema(final ByteBuffer byteBuffer) throws Exception
     {
-        try (final InputStream in = new FileInputStream("src/main/resources/example-schema.xml"))
+        try (InputStream in = new FileInputStream("src/main/resources/example-schema.xml"))
         {
             final MessageSchema schema = XmlSchemaParser.parse(in, ParserOptions.DEFAULT);
             final Ir ir = new IrGenerator().generate(schema);
-            try (final IrEncoder irEncoder = new IrEncoder(byteBuffer, ir))
+            try (IrEncoder irEncoder = new IrEncoder(byteBuffer, ir))
             {
                 irEncoder.encode();
             }
@@ -125,7 +125,7 @@ private static void encodeTestMessage(final ByteBuffer byteBuffer)
 
     private static Ir decodeIr(final ByteBuffer buffer) throws IOException
     {
-        try (final IrDecoder irDecoder = new IrDecoder(buffer))
+        try (IrDecoder irDecoder = new IrDecoder(buffer))
         {
             return irDecoder.decode();
         }

sbe-tool/src/main/java/uk/co/real_logic/sbe/SbeTool.java

@@ -205,7 +205,7 @@ else if (fileName.endsWith(".sbeir"))
 
                 final File fullPath = new File(outputDirName, namePart + ".sbeir");
 
-                try (final IrEncoder irEncoder = new IrEncoder(fullPath.getAbsolutePath(), ir))
+                try (IrEncoder irEncoder = new IrEncoder(fullPath.getAbsolutePath(), ir))
                 {
                     irEncoder.encode();
                 }
@@ -223,7 +223,7 @@ else if (fileName.endsWith(".sbeir"))
     public static void validateAgainstSchema(final String sbeSchemaFilename, final String xsdFilename)
         throws Exception
     {
-        try (final BufferedInputStream in = new BufferedInputStream(new FileInputStream(sbeSchemaFilename)))
+        try (BufferedInputStream in = new BufferedInputStream(new FileInputStream(sbeSchemaFilename)))
         {
             XmlSchemaParser.validate(xsdFilename, in);
         }
@@ -247,7 +247,7 @@ public static MessageSchema parseSchema(final String sbeSchemaFilename)
                 .warningsFatal(Boolean.parseBoolean(System.getProperty(VALIDATION_WARNINGS_FATAL)))
                 .suppressOutput(Boolean.parseBoolean(System.getProperty(VALIDATION_SUPPRESS_OUTPUT)));
 
-        try (final BufferedInputStream in = new BufferedInputStream(new FileInputStream(sbeSchemaFilename)))
+        try (BufferedInputStream in = new BufferedInputStream(new FileInputStream(sbeSchemaFilename)))
         {
             return XmlSchemaParser.parse(in, optionsBuilder.build());
         }

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/TargetCodeGenerator.java

@@ -61,7 +61,7 @@ public CodeGenerator newInstance(final Ir ir, final String outputDir) throws IOE
      * @return a new instance of a {@link CodeGenerator} for the given target language.
      * @throws IOException if an error occurs when dealing with the output directory.
      */
-    public abstract CodeGenerator newInstance(final Ir ir, final String outputDir) throws IOException;
+    public abstract CodeGenerator newInstance(Ir ir, String outputDir) throws IOException;
 
     /**
      * Do a case insensitive lookup of a target language for code generation.