[Java] Warnings cleanup.

Author: mjpt777

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/golang/GolangGenerator.java

@@ -81,9 +81,6 @@ public void generateTypeStubs() throws IOException
                     generateComposite(tokens, "");
                     break;
 
-                case BEGIN_MESSAGE:
-                    break;
-
                 default:
                     break;
             }
@@ -2112,24 +2109,10 @@ private void generateFields(
                 generateSinceActingDeprecated(sb, containingTypeName, propertyName, signalToken);
                 generateFieldMetaAttributeMethod(sb, containingTypeName, propertyName, signalToken);
 
-                switch (encodingToken.signal())
+                if (encodingToken.signal() == Signal.ENCODING)
                 {
-                    case ENCODING:
-                        generateMinMaxNull(sb, containingTypeName, propertyName, encodingToken);
-                        generateCharacterEncoding(sb, containingTypeName, propertyName, encodingToken);
-                        break;
-
-                    case BEGIN_ENUM:
-                        break;
-
-                    case BEGIN_SET:
-                        break;
-
-                    case BEGIN_COMPOSITE:
-                        break;
-
-                    default:
-                        break;
+                    generateMinMaxNull(sb, containingTypeName, propertyName, encodingToken);
+                    generateCharacterEncoding(sb, containingTypeName, propertyName, encodingToken);
                 }
             }
         }

sbe-tool/src/test/java/uk/co/real_logic/sbe/TargetCodeGeneratorTest.java

@@ -26,7 +26,7 @@
 public class TargetCodeGeneratorTest
 {
     @Test
-    public void shouldThrowOnNoTargetLanguage() throws Exception
+    public void shouldThrowOnNoTargetLanguage()
     {
         assertThrows(IllegalArgumentException.class, () ->
             SbeTool.generate(mock(Ir.class), ".", "none"));

sbe-tool/src/test/java/uk/co/real_logic/sbe/generation/csharp/Issue567GroupSizeTest.java

@@ -22,8 +22,8 @@ public class Issue567GroupSizeTest
     public static final String ERR_MSG =
         "WARNING: at <sbe:message name=\"issue567\"> <group name=\"group\"> \"numInGroup\" should be UINT8 or UINT16";
 
+    private final PrintStream mockErr = mock(PrintStream.class);
     private PrintStream err;
-    private PrintStream mockErr = mock(PrintStream.class);
 
     @BeforeEach
     public void before()
@@ -40,7 +40,7 @@ public void after()
     }
 
     @Test
-    public void shouldThrowWhenUsingATypeThatIsNotConstrainedToFitInAnIntAsTheGroupSize() throws Exception
+    public void shouldThrowWhenUsingATypeThatIsNotConstrainedToFitInAnIntAsTheGroupSize()
     {
         final ParserOptions options = ParserOptions.builder().stopOnError(true).build();
         assertThrows(IllegalArgumentException.class,

sbe-tool/src/test/java/uk/co/real_logic/sbe/xml/CompositeTypeTest.java

@@ -161,7 +161,6 @@ public void shouldHandleCompositeHasNullableType()
 
     @Test
     public void shouldThrowExceptionWhenCompositeTypeHasTypeNameDuplicates()
-        throws Exception
     {
         final String testXmlString =
             "<types>" +

sbe-tool/src/test/java/uk/co/real_logic/sbe/xml/EncodedDataTypeTest.java

@@ -128,7 +128,6 @@ public void shouldUseAppropriatePresence()
 
     @Test
     public void shouldThrowExceptionWhenUnknownPresenceSpecified()
-        throws Exception
     {
         final String testXmlString =
             "<types>" +
@@ -140,7 +139,6 @@ public void shouldThrowExceptionWhenUnknownPresenceSpecified()
 
     @Test
     public void shouldThrowExceptionWhenNoPrimitiveTypeSpecified()
-        throws Exception
     {
         final String testXmlString =
             "<types>" +
@@ -152,7 +150,6 @@ public void shouldThrowExceptionWhenNoPrimitiveTypeSpecified()
 
     @Test
     public void shouldThrowExceptionWhenNoNameSpecified()
-        throws Exception
     {
         final String testXmlString =
             "<types>" +
@@ -198,7 +195,6 @@ public void shouldUseAppropriatePrimitiveType()
 
     @Test
     public void shouldThrowExceptionWhenUnknownPrimitiveTypeSpecified()
-        throws Exception
     {
         final String testXmlString =
             "<types>" +
@@ -303,7 +299,6 @@ public void shouldReturnNullWhenSemanticTypeNotSpecified()
 
     @Test
     public void shouldThrowExceptionWhenConstantPresenceButNoDataSpecified()
-        throws Exception
     {
         final String testXmlString =
             "<types>" +

sbe-tool/src/test/java/uk/co/real_logic/sbe/xml/EnumTypeTest.java

@@ -183,7 +183,6 @@ public void shouldHandleCharEnumEncodingType()
 
     @Test
     public void shouldThrowExceptionWhenIllegalEncodingTypeSpecified()
-        throws Exception
     {
         final String testXmlString =
             "<types>" +
@@ -199,7 +198,6 @@ public void shouldThrowExceptionWhenIllegalEncodingTypeSpecified()
 
     @Test
     public void shouldThrowExceptionWhenDuplicateValueSpecified()
-        throws Exception
     {
         final String testXmlString =
             "<types>" +
@@ -216,7 +214,6 @@ public void shouldThrowExceptionWhenDuplicateValueSpecified()
 
     @Test
     public void shouldThrowExceptionWhenDuplicateNameSpecified()
-        throws Exception
     {
         final String testXmlString =
             "<types>" +

sbe-tool/src/test/java/uk/co/real_logic/sbe/xml/SetTypeTest.java

@@ -118,7 +118,6 @@ public void shouldHandleSetTypeList()
 
     @Test
     public void shouldThrowExceptionWhenIllegalEncodingTypeSpecified()
-        throws Exception
     {
         final String testXmlString =
             "<types>" +
@@ -134,7 +133,6 @@ public void shouldThrowExceptionWhenIllegalEncodingTypeSpecified()
 
     @Test
     public void shouldThrowExceptionWhenDuplicateValueSpecified()
-        throws Exception
     {
         final String testXmlString =
             "<types>" +
@@ -150,7 +148,6 @@ public void shouldThrowExceptionWhenDuplicateValueSpecified()
 
     @Test
     public void shouldThrowExceptionWhenDuplicateNameSpecified()
-        throws Exception
     {
         final String testXmlString =
             "<types>" +
@@ -166,7 +163,6 @@ public void shouldThrowExceptionWhenDuplicateNameSpecified()
 
     @Test
     public void shouldThrowExceptionWhenValueOutOfBoundsSpecified()
-        throws Exception
     {
         final String testXmlString =
             "<types>" +