Skip to content

Commit b25ad6a

Browse files
committed
[Java] Warnings clean up.
1 parent 6b33c11 commit b25ad6a

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

sbe-tool/src/main/java/uk/co/real_logic/sbe/PrimitiveValue.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ public static PrimitiveValue parse(final String value, final PrimitiveType primi
192192
{
193193
throw new IllegalArgumentException("Constant char value malformed: " + value);
194194
}
195-
return new PrimitiveValue((long)value.getBytes(US_ASCII)[0], 1);
195+
return new PrimitiveValue(value.getBytes(US_ASCII)[0], 1);
196196

197197
case INT8:
198198
return new PrimitiveValue(Byte.parseByte(value), 1);

sbe-tool/src/main/java/uk/co/real_logic/sbe/xml/SetType.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,12 @@ public SetType(final Node node, final String givenName, final String referencedN
7878

7979
default:
8080
// might not have ran into this type yet, so look for it
81-
final Node encodingTypeNode = (Node)xPath.compile(
82-
String.format("%s[@name=\'%s\']", XmlSchemaParser.TYPE_XPATH_EXPR, encodingTypeStr))
81+
final String expression = TYPE_XPATH_EXPR + "[@name='" + encodingTypeStr + "']";
82+
final Node encodingTypeNode = (Node)xPath
83+
.compile(expression)
8384
.evaluate(node.getOwnerDocument(), XPathConstants.NODE);
8485

85-
if (encodingTypeNode == null)
86+
if (null == encodingTypeNode)
8687
{
8788
encodingType = null;
8889
}

0 commit comments

Comments
 (0)