Merge pull request #390 from vdidenko/cpp_simple_bool_returns

[C++]: Simplify bool method returns

Author: tmontgomery

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/cpp/CppGenerator.java

@@ -525,7 +525,7 @@ private void generateVarDataDescriptors(
             indent + "    }\n\n" +
             indent + "    bool %1$sInActingVersion(void)\n" +
             indent + "    {\n" +
-            indent + "        return (m_actingVersion >= %1$sSinceVersion()) ? true : false;\n" +
+            indent + "        return m_actingVersion >= %1$sSinceVersion();\n" +
             indent + "    }\n\n" +
             indent + "    static SBE_CONSTEXPR const std::uint16_t %1$sId(void)\n" +
             indent + "    {\n" +
@@ -661,7 +661,7 @@ private CharSequence generateChoices(final String bitsetClassName, final List<To
                         "    bool %1$s(void) const\n" +
                         "    {\n" +
                         "%2$s" +
-                        "        return (%3$s(*((%4$s *)(m_buffer + m_offset))) & (0x1L << %5$s)) ? true : false;\n" +
+                        "        return %3$s(*((%4$s *)(m_buffer + m_offset))) & (0x1L << %5$s);\n" +
                         "    }\n\n",
                         choiceName,
                         generateChoiceNotPresentCondition(token.version(), BASE_INDENT),
@@ -1490,7 +1490,7 @@ private CharSequence generateFields(final String containingClassName, final List
                     indent + "    }\n\n" +
                     indent + "    bool %1$sInActingVersion(void)\n" +
                     indent + "    {\n" +
-                    indent + "        return (m_actingVersion >= %1$sSinceVersion()) ? true : false;\n" +
+                    indent + "        return m_actingVersion >= %1$sSinceVersion();\n" +
                     indent + "    }\n\n",
                     propertyName,
                     (long)signalToken.version()