Skip to content

Commit 690e833

Browse files
committed
[C++] Warnings cleanup.
1 parent 32b963f commit 690e833

File tree

1 file changed

+22
-19
lines changed

1 file changed

+22
-19
lines changed

sbe-tool/src/test/cpp/CodeGenTest.cpp

Lines changed: 22 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* limitations under the License.
1515
*/
1616
#include <iostream>
17+
#include <cstring>
1718

1819
#include "gtest/gtest.h"
1920
#include "code_generation_test/MessageHeader.h"
@@ -43,15 +44,15 @@ static const char *MODEL = "Civic VTi";
4344
static const char *ACTIVATION_CODE = "deadbeef";
4445
static const char *COLOR = "racing green";
4546

46-
static const std::uint64_t VEHICLE_CODE_LENGTH = sizeof(VEHICLE_CODE);
47-
static const std::uint64_t MANUFACTURER_CODE_LENGTH = sizeof(MANUFACTURER_CODE);
48-
static const std::uint64_t FUEL_FIGURES_1_USAGE_DESCRIPTION_LENGTH = 11;
49-
static const std::uint64_t FUEL_FIGURES_2_USAGE_DESCRIPTION_LENGTH = 14;
50-
static const std::uint64_t FUEL_FIGURES_3_USAGE_DESCRIPTION_LENGTH = 13;
51-
static const std::uint64_t MANUFACTURER_LENGTH = 5;
52-
static const std::uint64_t MODEL_LENGTH = 9;
53-
static const std::uint64_t ACTIVATION_CODE_LENGTH = 8;
54-
static const std::uint64_t COLOR_LENGTH = 12;
47+
static const std::size_t VEHICLE_CODE_LENGTH = sizeof(VEHICLE_CODE);
48+
static const std::size_t MANUFACTURER_CODE_LENGTH = sizeof(MANUFACTURER_CODE);
49+
static const std::size_t FUEL_FIGURES_1_USAGE_DESCRIPTION_LENGTH = strlen(FUEL_FIGURES_1_USAGE_DESCRIPTION);
50+
static const std::size_t FUEL_FIGURES_2_USAGE_DESCRIPTION_LENGTH = strlen(FUEL_FIGURES_2_USAGE_DESCRIPTION);
51+
static const std::size_t FUEL_FIGURES_3_USAGE_DESCRIPTION_LENGTH = strlen(FUEL_FIGURES_3_USAGE_DESCRIPTION);
52+
static const std::size_t MANUFACTURER_LENGTH = strlen(MANUFACTURER);
53+
static const std::size_t MODEL_LENGTH = strlen(MODEL);
54+
static const std::size_t ACTIVATION_CODE_LENGTH = strlen(ACTIVATION_CODE);
55+
static const std::size_t COLOR_LENGTH = strlen(COLOR);
5556
static const std::uint8_t PERFORMANCE_FIGURES_COUNT = 2;
5657
static const std::uint8_t FUEL_FIGURES_COUNT = 3;
5758
static const std::uint8_t ACCELERATION_COUNT = 3;
@@ -657,13 +658,14 @@ TEST_F(CodeGenTest, shouldBeAbleUseOnStackCodecsAndGroupForEach)
657658
EXPECT_EQ(fuelFigures.count(), FUEL_FIGURES_COUNT);
658659

659660
#if __cplusplus >= 201103L
660-
fuelFigures.forEach([&](Car::FuelFigures &figures)
661-
{
662-
cbs.countOfFuelFigures++;
661+
fuelFigures.forEach(
662+
[&](Car::FuelFigures &figures)
663+
{
664+
cbs.countOfFuelFigures++;
663665

664-
char tmp[256];
665-
figures.getUsageDescription(tmp, sizeof(tmp));
666-
});
666+
char tmp[256];
667+
figures.getUsageDescription(tmp, sizeof(tmp));
668+
});
667669
#else
668670
fuelFigures.forEach(cbs);
669671
#endif
@@ -677,10 +679,11 @@ TEST_F(CodeGenTest, shouldBeAbleUseOnStackCodecsAndGroupForEach)
677679
Car::PerformanceFigures::Acceleration acceleration = figures.acceleration();
678680

679681
cbs.countOfPerformanceFigures++;
680-
acceleration.forEach([&](Car::PerformanceFigures::Acceleration&)
681-
{
682-
cbs.countOfAccelerations++;
683-
});
682+
acceleration.forEach(
683+
[&](Car::PerformanceFigures::Acceleration&)
684+
{
685+
cbs.countOfAccelerations++;
686+
});
684687
});
685688
#else
686689
performanceFigures.forEach(cbs);

0 commit comments

Comments
 (0)