Skip to content

Commit 68e1b7f

Browse files
authored
Merge pull request #726 from rigtorp/no-uninitialized
[C++] Make sure all members are initilized
2 parents b32cbfa + 0ef9693 commit 68e1b7f

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/cpp/CppGenerator.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -197,14 +197,14 @@ private static void generateGroupClassHeader(
197197
indent + "class %1$s\n" +
198198
indent + "{\n" +
199199
indent + "private:\n" +
200-
indent + " char *m_buffer;\n" +
201-
indent + " std::uint64_t m_bufferLength;\n" +
202-
indent + " std::uint64_t *m_positionPtr;\n" +
203-
indent + " std::uint64_t m_blockLength;\n" +
204-
indent + " std::uint64_t m_count;\n" +
205-
indent + " std::uint64_t m_index;\n" +
206-
indent + " std::uint64_t m_offset;\n" +
207-
indent + " std::uint64_t m_actingVersion;\n\n" +
200+
indent + " char *m_buffer = nullptr;\n" +
201+
indent + " std::uint64_t m_bufferLength = 0;\n" +
202+
indent + " std::uint64_t *m_positionPtr = nullptr;\n" +
203+
indent + " std::uint64_t m_blockLength = 0;\n" +
204+
indent + " std::uint64_t m_count = 0;\n" +
205+
indent + " std::uint64_t m_index = 0;\n" +
206+
indent + " std::uint64_t m_offset = 0;\n" +
207+
indent + " std::uint64_t m_actingVersion = 0;\n\n" +
208208

209209
indent + " SBE_NODISCARD std::uint64_t *sbePositionPtr() SBE_NOEXCEPT\n" +
210210
indent + " {\n" +
@@ -1637,9 +1637,9 @@ private CharSequence generateFixedFlyweightCode(final String className, final in
16371637
return String.format(
16381638
"private:\n" +
16391639
" char *m_buffer = nullptr;\n" +
1640-
" std::uint64_t m_bufferLength;\n" +
1640+
" std::uint64_t m_bufferLength = 0;\n" +
16411641
" std::uint64_t m_offset = 0;\n" +
1642-
" std::uint64_t m_actingVersion;\n\n" +
1642+
" std::uint64_t m_actingVersion = 0;\n\n" +
16431643

16441644
"public:\n" +
16451645
" enum MetaAttribute\n" +
@@ -1790,8 +1790,8 @@ private CharSequence generateMessageFlyweightCode(final String className, final
17901790
" char *m_buffer = nullptr;\n" +
17911791
" std::uint64_t m_bufferLength = 0;\n" +
17921792
" std::uint64_t m_offset = 0;\n" +
1793-
" std::uint64_t m_position;\n" +
1794-
" std::uint64_t m_actingVersion;\n\n" +
1793+
" std::uint64_t m_position = 0;\n" +
1794+
" std::uint64_t m_actingVersion = 0;\n\n" +
17951795

17961796
" inline std::uint64_t *sbePositionPtr() SBE_NOEXCEPT\n" +
17971797
" {\n" +

0 commit comments

Comments
 (0)